feat(types): Add type for measurement unit#5313
Merged
Merged
Conversation
Folks gave some feedback that we should be explicit about the units we support. Let's add TypeScript types for these so we don't add any runtime logic, but it should have helpful autocomplete for users.
AbhiPrasad
commented
Jun 24, 2022
|
|
||
| __DEBUG_BUILD__ && logger.log('[Measurements] Adding CLS'); | ||
| _measurements['cls'] = { value: metric.value, unit: 'none' }; | ||
| _measurements['cls'] = { value: metric.value, unit: '' }; |
Contributor
Author
There was a problem hiding this comment.
'none' === '' here, but this saves us some bytes.
k-fish
approved these changes
Jun 24, 2022
Member
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
Appreciate it 👍 this makes it far easier to use without looking things up.
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jun 25, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folks gave some feedback that we should be explicit about the units we
support. Let's add TypeScript types for these so we don't add any
runtime logic, but it should have helpful autocomplete for users.
cc @k-fish who brought this up with getsentry/sentry#36012