Skip to content

Conversation

@ulgens
Copy link

@ulgens ulgens commented Dec 26, 2025

Description

I was checking the lint setup and realized running pre-commit locally on latest main doesn't produce a clean result. I checked why this wasn't the case on CI and found out that pre-commit ruff and CI ruff use slightly different configuration. I tried to centralize that config, and found out there is a bug with ruff-pre-commit but still DRY'ed the ruff calls.

Considering the removal of the "include" setting causes only a single change in a single file, I think that settings can be removed compeletely but I didn't want to change configuration without asking about it first.

Issues

Reminders

@ulgens ulgens requested a review from a team as a code owner December 26, 2025 12:54
pre-commit run --all-files
mypy sentry_sdk

This comment was marked as outdated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is okay. Explicitly saying that files shouldn't be changed doesn't yield a benefit on CI.

@ulgens ulgens changed the title fix: DRY ruff calls ci: DRY ruff calls Dec 26, 2025
@ulgens ulgens force-pushed the simplify-ruff-call branch from 6037f2a to ade2e99 Compare January 7, 2026 12:16
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.17%. Comparing base (2ce4379) to head (ade2e99).
⚠️ Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5267      +/-   ##
==========================================
- Coverage   84.25%   84.17%   -0.08%     
==========================================
  Files         181      182       +1     
  Lines       18463    18656     +193     
  Branches     3288     3316      +28     
==========================================
+ Hits        15556    15704     +148     
- Misses       1894     1938      +44     
- Partials     1013     1014       +1     

see 17 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant