Skip to content

test(pyramid): Add span streaming support to integration tests#6385

Merged
ericapisani merged 3 commits into
masterfrom
py-2350-migrate-pyramid
May 22, 2026
Merged

test(pyramid): Add span streaming support to integration tests#6385
ericapisani merged 3 commits into
masterfrom
py-2350-migrate-pyramid

Conversation

@ericapisani
Copy link
Copy Markdown
Member

@ericapisani ericapisani commented May 21, 2026

This integration gets span streaming automatically via the SentryWsgiMiddleware and the branching logic in helper methods like set_transaction_name.

Added test coverage to confirm span streaming works as expected.

Fixes PY-2350
Fixes #6048

This integration gets span streaming automatically via
the SentryWsgiMiddleware and the branching logic in helper
methods like `set_transaction_name`.

Added test coverage to confirm span streaming works as expected.

Fixes PY-2350
Fixes #6048
@ericapisani ericapisani requested a review from a team as a code owner May 21, 2026 19:43
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 21, 2026

PY-2350

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Codecov Results 📊

282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.55s

All tests are passing successfully.

❌ Patch coverage is 60.00%. Project has 14702 uncovered lines.

Files with missing lines (1)
File Patch % Lines
pyramid.py 15.04% ⚠️ 96 Missing

Generated by Codecov Action

Copy link
Copy Markdown
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on the diff since there is none for the main integration file, so just a separate comment:

  • _set_transaction_name_and_source technically works as is, but would be nice to use SegmentSource instead of TransactionSource in it when span streaming. There's a streaming SOURCE_FOR_STYLE equivalent in traces.py.
  • The integration defines an event_processor; is the data that would be set there set on the span elsewhere (e.g. WSGI), or is there anything we're missing?

@ericapisani
Copy link
Copy Markdown
Member Author

@sentrivana

_set_transaction_name_and_source technically works as is, but would be nice to use SegmentSource instead of TransactionSource in it when span streaming. There's a streaming SOURCE_FOR_STYLE equivalent in traces.py.

👍🏻

The integration defines an event_processor; is the data that would be set there set on the span elsewhere (e.g. WSGI), or is there anything we're missing?

The event processor adds the parsed request body to the event, so we're technically missing data, but given we had discussed not adding the http.request.body.data span attribute for now on streamed spans, I made no changes there.

@ericapisani ericapisani enabled auto-merge (squash) May 22, 2026 12:39
@ericapisani ericapisani merged commit 4e30693 into master May 22, 2026
157 checks passed
@ericapisani ericapisani deleted the py-2350-migrate-pyramid branch May 22, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate pyramid to span first

3 participants