From b13b12294e81b2f9d4e27dd39e0f8d7376f61a35 Mon Sep 17 00:00:00 2001 From: sjh Date: Fri, 5 Feb 2021 15:06:53 +0800 Subject: [PATCH] raise error when send_event failed --- sentry-ruby/lib/sentry/transport.rb | 2 +- sentry-ruby/spec/sentry/transport_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sentry-ruby/lib/sentry/transport.rb b/sentry-ruby/lib/sentry/transport.rb index 345383998..74dde2b25 100644 --- a/sentry-ruby/lib/sentry/transport.rb +++ b/sentry-ruby/lib/sentry/transport.rb @@ -33,7 +33,7 @@ def send_event(event) event rescue => e failed_for_exception(e, event) - nil + raise e end def generate_auth_header diff --git a/sentry-ruby/spec/sentry/transport_spec.rb b/sentry-ruby/spec/sentry/transport_spec.rb index a5433b56c..96decdda0 100644 --- a/sentry-ruby/spec/sentry/transport_spec.rb +++ b/sentry-ruby/spec/sentry/transport_spec.rb @@ -125,12 +125,12 @@ allow(subject).to receive(:send_data).and_raise(StandardError) end - it "returns nil" do - expect(subject.send_event(event)).to eq(nil) + it "raises error" do + expect { subject.send_event(event) }.to raise_error end it "logs correct message" do - subject.send_event(event) + subject.send_event(event) rescue nil log = io.string expect(log).to match(