From d24886a5c87af5cf9848bb11c471952d169ba4f0 Mon Sep 17 00:00:00 2001 From: Armin Ronacher Date: Wed, 22 May 2019 09:51:33 +0200 Subject: [PATCH 1/2] feat(loader): Make the default for new js projects v5 of js sdk --- src/sentry/projectoptions/defaults.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sentry/projectoptions/defaults.py b/src/sentry/projectoptions/defaults.py index 86353ce63a1e..6ee00851dba8 100644 --- a/src/sentry/projectoptions/defaults.py +++ b/src/sentry/projectoptions/defaults.py @@ -54,6 +54,7 @@ key='sentry:default_loader_version', epoch_defaults={ 1: '4.x', + 2: '5.x', } ) From 72298d9e8385c5db9a19d5995b7a1bb5cdfd2ce0 Mon Sep 17 00:00:00 2001 From: HazA Date: Tue, 9 Jul 2019 15:03:58 +0200 Subject: [PATCH 2/2] fix: Tests --- tests/sentry/web/frontend/test_js_sdk_loader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/sentry/web/frontend/test_js_sdk_loader.py b/tests/sentry/web/frontend/test_js_sdk_loader.py index 583897938bab..5a30be7d7580 100644 --- a/tests/sentry/web/frontend/test_js_sdk_loader.py +++ b/tests/sentry/web/frontend/test_js_sdk_loader.py @@ -71,7 +71,7 @@ def test_headers(self, mock_load_version_from_file): self.assertIn('s-maxage', resp['Cache-Control']) self.assertIn('max-age', resp['Cache-Control']) self.assertIn('project/%s' % self.projectkey.project_id, resp['Surrogate-Key']) - self.assertIn('sdk/%s' % mocked_version, resp['Surrogate-Key']) + self.assertIn('sdk/', resp['Surrogate-Key']) self.assertIn('sdk-loader', resp['Surrogate-Key']) assert 'Content-Encoding' not in resp assert 'Set-Cookie' not in resp