From ee35d7bf763f96db1be078a63dec51d81a6c4c8f Mon Sep 17 00:00:00 2001 From: M Hickford Date: Fri, 20 Oct 2023 19:48:25 +0100 Subject: [PATCH] default OAuth redirect URI to http://127.0.0.1 --- docs/generic-oauth.md | 2 +- src/shared/Core/GenericOAuthConfig.cs | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/generic-oauth.md b/docs/generic-oauth.md index 6620134fc..08b735ccb 100644 --- a/docs/generic-oauth.md +++ b/docs/generic-oauth.md @@ -40,7 +40,7 @@ following values in your Git configuration: - Client ID - Client Secret (optional) -- Redirect URL +- Redirect URL (optional, defaults to `http://127.0.0.1`) - Scopes (optional) - OAuth Endpoints - Authorization Endpoint diff --git a/src/shared/Core/GenericOAuthConfig.cs b/src/shared/Core/GenericOAuthConfig.cs index 0e2a74b75..1f8aa16fb 100644 --- a/src/shared/Core/GenericOAuthConfig.cs +++ b/src/shared/Core/GenericOAuthConfig.cs @@ -81,9 +81,7 @@ public static bool TryGet(ITrace trace, ISettings settings, Uri remoteUri, out G } else { - trace.WriteLine($"Invalid OAuth configuration - missing/invalid redirect URI: {redirectUrl}"); - config = null; - return false; + config.RedirectUri = new Uri("http://127.0.0.1"); } if (settings.TryGetSetting(