Make the Text Size preference apply to the text in the diff view, not just the line numbers#2727
Merged
lucasderraugh merged 1 commit intoOct 23, 2025
Conversation
…e diff view instead of just the line numbers.
lucasderraugh
approved these changes
Oct 23, 2025
Collaborator
lucasderraugh
left a comment
lucasderraugh
left a comment
There was a problem hiding this comment.
Good catch! This seems like a reasonable approach without having us unnecessarily calling logic in -updateLayoutForWidth:
Collaborator
|
To be clear, this was only a bug when updating while the view was visible, it would work if you updated outside of this being presented. Looks like UnifiedDiffView doesn't have the same checks so it already dynamically changes. |
Contributor
Author
I tried changing the setting without the diff view being visible, but it still only changed the line number sizing. However, not important now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Text Size setting in the preference pane currently only changes the size of the line numbers in the diff viewer, which is not that useful. Presumably it is supposed to also change the text size in the diff content.
This PR makes that change. The Text Size setting will now correctly change the size of the text in the diff content, not just the line numbers.
This addresses #470
Below are two screen shots with this change using the smallest and largest text settings.