Fix implementation of barrierNode for barrier models

owen-mc · owen-mc · commit d13e9ee935f3 · 2026-01-29T13:59:44.000Z
diff --git a/python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModels.qll b/python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModels.qll
@@ -878,7 +878,7 @@ module ModelOutput {
    * Holds if `node` is specified as a barrier with the given kind in an external model.
    */
   predicate barrierNode(DataFlow::Node node, string kind) {
-    node = getABarrierNode(kind).asSource()
+    node = getABarrierNode(kind).asSink()
     or
     node = DataFlow::ExternalBarrierGuard::getAnExternalBarrierNode(kind)
   }

Original file line number	Diff line number	Diff line change
`@@ -878,7 +878,7 @@ module ModelOutput {`
`878`	`878`	* Holds if `node` is specified as a barrier with the given kind in an external model.
`879`	`879`	`*/`
`880`	`880`	`predicate barrierNode(DataFlow::Node node, string kind) {`
`881`		`- node = getABarrierNode(kind).asSource()`
	`881`	`+ node = getABarrierNode(kind).asSink()`
`882`	`882`	`or`
`883`	`883`	`node = DataFlow::ExternalBarrierGuard::getAnExternalBarrierNode(kind)`
`884`	`884`	`}`