From 96062e1ff1a59d0b253f631266eb4d3cc570fa24 Mon Sep 17 00:00:00 2001 From: Ed Burns Date: Wed, 25 Mar 2026 01:11:17 -0400 Subject: [PATCH 1/2] On branch edburns/dd-2855288-add-smoke-test-to-build-and-test Make smoke test a pre-condition for the build-test.yml. modified: .github/workflows/build-test.yml modified: .github/workflows/run-smoke-test.yml Signed-off-by: Ed Burns --- .github/workflows/build-test.yml | 9 ++++++++- .github/workflows/run-smoke-test.yml | 4 ++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 254db8c7b..42cfebc6e 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -24,8 +24,15 @@ permissions: jobs: + smoke-test: + name: "Smoke Test" + uses: ./.github/workflows/run-smoke-test.yml + secrets: + COPILOT_GITHUB_TOKEN: ${{ secrets.COPILOT_GITHUB_TOKEN }} + java-sdk: name: "Java SDK Tests" + needs: smoke-test runs-on: ubuntu-latest defaults: @@ -39,7 +46,7 @@ jobs: - uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5 with: java-version: "17" - distribution: "temurin" + distribution: "microsoft" cache: "maven" - name: Run spotless check diff --git a/.github/workflows/run-smoke-test.yml b/.github/workflows/run-smoke-test.yml index d30ff01a4..d5181e038 100644 --- a/.github/workflows/run-smoke-test.yml +++ b/.github/workflows/run-smoke-test.yml @@ -2,6 +2,10 @@ name: Run smoke test on: workflow_dispatch: + workflow_call: + secrets: + COPILOT_GITHUB_TOKEN: + required: true permissions: contents: read From 0842fe0c3fb7445d1ff52d16ca9c5bbbcb963c4a Mon Sep 17 00:00:00 2001 From: Ed Burns Date: Wed, 25 Mar 2026 01:21:41 -0400 Subject: [PATCH 2/2] On branch edburns/dd-2855288-add-smoke-test-to-build-and-test modified: .github/workflows/build-test.yml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit More absolutely excellent copilot review feedback. > java-sdk now has needs: smoke-test, but the called workflow’s only job is gated by if: github.ref == 'refs/heads/main' (.github/workflows/run-smoke-test.yml:17). On pull_request and merge_group runs, smoke-test will be skipped, which will cause java-sdk to be skipped as well (no tests run). Consider either removing the hard dependency, or adding an explicit job if: ${{ always() && needs.smoke-test.result != 'failure' }} (or similar) so java-sdk still runs when smoke-test is skipped. Signed-off-by: Ed Burns --- .github/workflows/build-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 42cfebc6e..f5df31e8d 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -33,6 +33,7 @@ jobs: java-sdk: name: "Java SDK Tests" needs: smoke-test + if: ${{ always() && needs.smoke-test.result != 'failure' }} runs-on: ubuntu-latest defaults: