From fd1ed1989cf4619e7321d4491985337d4e65c7aa Mon Sep 17 00:00:00 2001 From: Rachael Sewell Date: Tue, 19 Jan 2021 13:38:53 -0800 Subject: [PATCH] Use javascript not shell * Revert "Fail workflow when pr includes unallowed contributions (#17333)" This reverts commit 871d886c16c6f50ef8223e7c767dd680f23047b2. * actually use javascript * remove space * lint --- .github/workflows/triage-unallowed-contributions.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/triage-unallowed-contributions.yml b/.github/workflows/triage-unallowed-contributions.yml index 662d1f19a1d6..9cbee56a77a9 100644 --- a/.github/workflows/triage-unallowed-contributions.yml +++ b/.github/workflows/triage-unallowed-contributions.yml @@ -104,7 +104,8 @@ jobs: body: reviewMessage, event: 'REQUEST_CHANGES' }) - exit 1 # prevents further steps from running and fails workflow + + core.setFailed("It looks like you've modified some files we don't accept contributions for. Please see the review with requested changes for details.") # When the most recent review was CHANGES_REQUESTED and the existing # PR no longer contains unallowed changes, dismiss the previous review - name: Dismiss pull request review