From a6fb87f22778b9b1bb7ac49f50589944189763a6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 3 May 2026 13:54:16 +0000 Subject: [PATCH 1/3] Initial plan From 4a7754cc4bd4a805668a64d2157121142e36ca99 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 3 May 2026 13:55:21 +0000 Subject: [PATCH 2/3] Remove export keyword from internal interfaces in src/cli.ts Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/bc9df357-7482-49d1-a6ba-892014a7c40e Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --- src/cli.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cli.ts b/src/cli.ts index 35cf0794c..8e37ae832 100644 --- a/src/cli.ts +++ b/src/cli.ts @@ -1095,12 +1095,12 @@ export function joinShellArgs(args: string[]): string { /** * Result of parsing environment variables */ -export interface ParseEnvResult { +interface ParseEnvResult { success: true; env: Record; } -export interface ParseEnvError { +interface ParseEnvError { success: false; invalidVar: string; } @@ -1108,12 +1108,12 @@ export interface ParseEnvError { /** * Result of parsing volume mounts */ -export interface ParseVolumeMountsResult { +interface ParseVolumeMountsResult { success: true; mounts: string[]; } -export interface ParseVolumeMountsError { +interface ParseVolumeMountsError { success: false; invalidMount: string; reason: string; From 4092ebbd92834b2fa81a42be90bd3a1d5bca96ae Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 3 May 2026 23:16:16 +0000 Subject: [PATCH 3/3] refactor(cli): inline return types; remove named interfaces --- src/cli.ts | 39 ++++++++------------------------------- 1 file changed, 8 insertions(+), 31 deletions(-) diff --git a/src/cli.ts b/src/cli.ts index 8e37ae832..ceb8b59d2 100644 --- a/src/cli.ts +++ b/src/cli.ts @@ -1092,39 +1092,14 @@ export function joinShellArgs(args: string[]): string { return args.map(escapeShellArg).join(' '); } -/** - * Result of parsing environment variables - */ -interface ParseEnvResult { - success: true; - env: Record; -} - -interface ParseEnvError { - success: false; - invalidVar: string; -} - -/** - * Result of parsing volume mounts - */ -interface ParseVolumeMountsResult { - success: true; - mounts: string[]; -} - -interface ParseVolumeMountsError { - success: false; - invalidMount: string; - reason: string; -} - /** * Parses environment variables from an array of KEY=VALUE strings * @param envVars Array of environment variable strings in KEY=VALUE format - * @returns ParseEnvResult with parsed key-value pairs on success, or ParseEnvError with the invalid variable on failure + * @returns Object with parsed key-value pairs on success, or error details on failure */ -export function parseEnvironmentVariables(envVars: string[]): ParseEnvResult | ParseEnvError { +export function parseEnvironmentVariables( + envVars: string[] +): { success: true; env: Record } | { success: false; invalidVar: string } { const result: Record = {}; for (const envVar of envVars) { @@ -1142,9 +1117,11 @@ export function parseEnvironmentVariables(envVars: string[]): ParseEnvResult | P /** * Parses and validates volume mount specifications * @param mounts Array of volume mount strings in host_path:container_path[:mode] format - * @returns ParseVolumeMountsResult on success, or ParseVolumeMountsError with details on failure + * @returns Object with parsed mount strings on success, or error details on failure */ -export function parseVolumeMounts(mounts: string[]): ParseVolumeMountsResult | ParseVolumeMountsError { +export function parseVolumeMounts( + mounts: string[] +): { success: true; mounts: string[] } | { success: false; invalidMount: string; reason: string } { const result: string[] = []; for (const mount of mounts) {