From dc9278c7385cd74786d1f91aec16e0c225ba376f Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 26 May 2026 17:44:27 +0000 Subject: [PATCH] Add tests for logger.RPCMessageType.JSONLEvent default branch Adds a table-driven test TestRPCMessageType_JSONLEvent covering all four cases of the JSONLEvent() method: RPCMessageRequest, RPCMessageResponse, an unknown type, and an empty string. The default branch ('rpc_unknown') was previously uncovered (75% coverage). This change brings JSONLEvent to 100% coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- internal/logger/rpc_logger_test.go | 38 ++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/internal/logger/rpc_logger_test.go b/internal/logger/rpc_logger_test.go index 71b6528fc..27da8a9e4 100644 --- a/internal/logger/rpc_logger_test.go +++ b/internal/logger/rpc_logger_test.go @@ -657,6 +657,44 @@ func TestLogRPCMessage(t *testing.T) { assert.Contains(t, string(mdContent), "**custom-server**→`custom/method`") } +// TestRPCMessageType_JSONLEvent verifies that JSONLEvent returns the correct +// event name for each RPCMessageType, including the default/unknown case. +func TestRPCMessageType_JSONLEvent(t *testing.T) { + tests := []struct { + name string + msgType RPCMessageType + wantEvent string + }{ + { + name: "request type returns rpc_request", + msgType: RPCMessageRequest, + wantEvent: "rpc_request", + }, + { + name: "response type returns rpc_response", + msgType: RPCMessageResponse, + wantEvent: "rpc_response", + }, + { + name: "unknown type returns rpc_unknown", + msgType: RPCMessageType("UNKNOWN"), + wantEvent: "rpc_unknown", + }, + { + name: "empty type returns rpc_unknown", + msgType: RPCMessageType(""), + wantEvent: "rpc_unknown", + }, + } + + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + got := tt.msgType.JSONLEvent() + assert.Equal(t, tt.wantEvent, got) + }) + } +} + func TestLogRPCResponse_NoError(t *testing.T) { tmpDir := t.TempDir() logDir := filepath.Join(tmpDir, "logs")