From c9188c358cb32ee6f07215cfa9d2c032613ee3b6 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 1 Jun 2026 14:49:29 +0000 Subject: [PATCH] refactor(tracing): unify semconv import to v1.34.0 in span_helpers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit span_helpers.go and span_helpers_test.go imported semconv/v1.27.0 while every other file in internal/tracing/ used semconv/v1.34.0. Both versions expose URLPathKey identically (url.path), so this is a zero-risk change that eliminates mixed schema URL inconsistency in exported traces. No go.mod changes required — semconv/v1.27.0 and v1.34.0 are both sub-packages within the existing go.opentelemetry.io/otel v1.43.0 module. Addresses recommendation from #6841 (Go Fan review). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- internal/tracing/span_helpers.go | 2 +- internal/tracing/span_helpers_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/tracing/span_helpers.go b/internal/tracing/span_helpers.go index e636aa233..2c2648294 100644 --- a/internal/tracing/span_helpers.go +++ b/internal/tracing/span_helpers.go @@ -6,7 +6,7 @@ import ( "context" "go.opentelemetry.io/otel/codes" - semconv "go.opentelemetry.io/otel/semconv/v1.27.0" + semconv "go.opentelemetry.io/otel/semconv/v1.34.0" oteltrace "go.opentelemetry.io/otel/trace" ) diff --git a/internal/tracing/span_helpers_test.go b/internal/tracing/span_helpers_test.go index 18ccf8910..97db92eb7 100644 --- a/internal/tracing/span_helpers_test.go +++ b/internal/tracing/span_helpers_test.go @@ -10,7 +10,7 @@ import ( "go.opentelemetry.io/otel/attribute" sdktrace "go.opentelemetry.io/otel/sdk/trace" "go.opentelemetry.io/otel/sdk/trace/tracetest" - semconv "go.opentelemetry.io/otel/semconv/v1.27.0" + semconv "go.opentelemetry.io/otel/semconv/v1.34.0" oteltrace "go.opentelemetry.io/otel/trace" )