From 467ea71272a195954ac70fc23502d7b1e0432a4d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 15 Jul 2026 00:11:42 +0000 Subject: [PATCH 1/3] Improve tests for server/difc_log: cover desc-only and reason-only branches MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add TestBuildDIFCFilteredNotice_ItemWithDescOnly and TestBuildDIFCFilteredNotice_ItemWithReasonOnly to cover the two previously-untested branches in buildDIFCFilteredNotice (lines 150–154): - else if desc != : item has a description but no reason - else: item has a reason but no description buildDIFCFilteredNotice coverage: 87.5% → 100% internal/server package coverage: 92.4% → 92.6% Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- internal/server/difc_log_test.go | 41 ++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/internal/server/difc_log_test.go b/internal/server/difc_log_test.go index 2b44bd823..d364ff193 100644 --- a/internal/server/difc_log_test.go +++ b/internal/server/difc_log_test.go @@ -466,6 +466,47 @@ func TestBuildDIFCFilteredNotice_ItemWithNoDescription(t *testing.T) { assert.Contains(t, notice, "1 item(s)") } +// TestBuildDIFCFilteredNotice_ItemWithDescOnly verifies that an item with a description +// but no reason is included in the inline notice using only the description. +func TestBuildDIFCFilteredNotice_ItemWithDescOnly(t *testing.T) { + f := &difc.FilteredCollectionLabeledData{ + Filtered: []difc.FilteredItemDetail{ + newTestFilteredItem(nil, "issue:org/repo#42", "", nil, nil), + }, + TotalCount: 1, + } + + notice := buildDIFCFilteredNotice(f) + + assert.NotEmpty(t, notice) + assert.Contains(t, notice, "[Filtered]") + assert.Contains(t, notice, "1 item(s)") + assert.Contains(t, notice, "issue:org/repo#42") + // No parenthesized reason should appear. + assert.NotContains(t, notice, "()") +} + +// TestBuildDIFCFilteredNotice_ItemWithReasonOnly verifies that an item with a reason +// but no description is included in the inline notice using only the reason. +func TestBuildDIFCFilteredNotice_ItemWithReasonOnly(t *testing.T) { + f := &difc.FilteredCollectionLabeledData{ + Filtered: []difc.FilteredItemDetail{ + { + Item: difc.LabeledItem{Data: "raw", Labels: difc.NewLabeledResource("")}, + Reason: "integrity too low", + }, + }, + TotalCount: 1, + } + + notice := buildDIFCFilteredNotice(f) + + assert.NotEmpty(t, notice) + assert.Contains(t, notice, "[Filtered]") + assert.Contains(t, notice, "1 item(s)") + assert.Contains(t, notice, "integrity too low") +} + // TestBuildDIFCFilteredNotice_SecrecyViolation verifies that secrecy-blocked items // produce a notice that says "secrecy policy", not "integrity policy". func TestBuildDIFCFilteredNotice_SecrecyViolation(t *testing.T) { From 8206201f56a41c5d61da3258bfc31cd1b5b9addf Mon Sep 17 00:00:00 2001 From: Landon Cox Date: Wed, 15 Jul 2026 08:51:11 -0700 Subject: [PATCH 2/3] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- internal/server/difc_log_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/server/difc_log_test.go b/internal/server/difc_log_test.go index d364ff193..fc2bfc5aa 100644 --- a/internal/server/difc_log_test.go +++ b/internal/server/difc_log_test.go @@ -481,9 +481,9 @@ func TestBuildDIFCFilteredNotice_ItemWithDescOnly(t *testing.T) { assert.NotEmpty(t, notice) assert.Contains(t, notice, "[Filtered]") assert.Contains(t, notice, "1 item(s)") - assert.Contains(t, notice, "issue:org/repo#42") - // No parenthesized reason should appear. - assert.NotContains(t, notice, "()") + assert.Contains(t, notice, "are not shown: issue:org/repo#42") + // Ensure the description is not formatted with a parenthesized reason. + assert.NotContains(t, notice, "issue:org/repo#42 (") } // TestBuildDIFCFilteredNotice_ItemWithReasonOnly verifies that an item with a reason From 2316398398b6411cd61ed2307572752296ed0d6b Mon Sep 17 00:00:00 2001 From: Landon Cox Date: Wed, 15 Jul 2026 08:51:17 -0700 Subject: [PATCH 3/3] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- internal/server/difc_log_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/server/difc_log_test.go b/internal/server/difc_log_test.go index fc2bfc5aa..dac825165 100644 --- a/internal/server/difc_log_test.go +++ b/internal/server/difc_log_test.go @@ -504,7 +504,8 @@ func TestBuildDIFCFilteredNotice_ItemWithReasonOnly(t *testing.T) { assert.NotEmpty(t, notice) assert.Contains(t, notice, "[Filtered]") assert.Contains(t, notice, "1 item(s)") - assert.Contains(t, notice, "integrity too low") + assert.Contains(t, notice, "are not shown: integrity too low") + assert.NotContains(t, notice, "raw") } // TestBuildDIFCFilteredNotice_SecrecyViolation verifies that secrecy-blocked items