[eslint-refiner] ESLint Refiner — Daily Report 2026-07-14

[github-actions[bot]]

Overview

The eslint-factory plugin grew from 12 → 17 rules since the last run (2026-07-08). All 5 new rules were reviewed for the first time today; each was grounded against the live actions/setup/js/** corpus (370 non-test .cjs files). Filed 2 concrete, non-duplicate refinement issues (quality over cap); heavy dedup avoided refiling the already-saturated request rule.

Key metrics

Metric	Value
Rules in plugin	17 (index.ts)
New rules reviewed today	5
Issues filed	2
Duplicates skipped	3 open (#45206/#45207/#45364) + 2 closed (#45334/#45299)
Corpus files scanned	370 non-test .cjs

New rules — findings

Per-rule verdict (5 new rules)

• require-return-after-core-setfailed → FILED. Braceless if/else/loop consequents bypass analysis: the rule only scans statement lists (BlockStatement.body, SwitchCase.consequent, Program.body), so if (bad) core.setFailed("x"); doMore(); is never checked — while the braced equivalent is caught. Latent soundness gap (0 live braceless sites; all current sites return immediately). Distinct from the already-fixed callee-form detection (eslint-factory: detect aliased/destructured/computed core.setFailed in require-return-after-core-setfailed #45334).
• require-spawnsync-error-check → FILED. (1) Only const <id> = spawnSync() is analyzed, so const { status } = spawnSync() (where .error is unbindable — the worst case) escapes entirely; (2) hasErrorCheck accepts any .error read, including a non-guarding log. Rule otherwise works: real TPs at apply_samples.cjs:97, artifact_client.cjs, send_otlp_span.cjs:823; correct TN at git_helpers.cjs:87 (if (result.error) ... throw).
• no-github-request-interpolated-route → skipped (duplicate). FPs/FNs already tracked: opaque whole-route helper remedy-inapplicable (eslint-factory: no-github-request-interpolated-route — diagnostic remedy is inapplicable for opaque whole-route helpers (\\$\{ [Content truncated due to length] #45207/Refine interpolated-route diagnostics for opaque Octokit route helpers #45364, grounded at add_reaction.cjs:193) and scope-resolution FNs (eslint-factory: no-github-request-interpolated-route — scope-resolution false negatives (global.getOctokit client alias + route- [Content truncated due to length] #45206). Rule correctly flags true positives at route_slash_command.cjs:180-216.
• no-throw-plain-object → no defect. ~23 live throw { code, message } sites (mcp_server_core.cjs, safe_outputs_handlers.cjs) are JSON-RPC error objects; the catch at mcp_server_core.cjs:834 reads only err.code/err.message, so the rule's Object.assign(new Error(msg), { code }) suggestion is behavior-preserving. Genuine, safely-fixable tech-debt — not a false positive. Suggestion support already shipped (feat(eslint-factory): add Object.assign suggestion to no-throw-plain-object rule #45299).
• no-core-exportvariable-non-string → deferred. All 15 live core.exportVariable args are strings/templates, so consistency gaps (misses UnaryExpression numerics, .size/.byteLength, and object aliases — mirroring setoutput eslint-factory: no-core-setoutput-non-string misses negative/unary numeric literals (e.g. -1, +5) #42680/eslint-factory: no-core-setoutput-non-string only recognizes .length; misses .number/.size (live FN in close_entity_helpers.cjs) #42682) are ungrounded. Will file when a live non-string arg appears.

Next actions

• On merge of the two filed issues: verify braced setFailed cases stay unregressed and git_helpers.cjs:87 remains valid while apply_samples.cjs:97 stays flagged.
• Watch for an 18th rule (cadence ~1/day) — re-diff index.ts against the tracked inventory next run.
• Revisit no-core-exportvariable-non-string consistency once a live non-string arg lands.

References:

• §29309802847

Generated by 🤖 ESLint Refiner · 360.4 AIC · ⌖ 12.5 AIC · ⊞ 4.6K · ◷

• expires on Jul 14, 2026, 10:11 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by ESLint Refiner.

A newer discussion is available at Discussion #45651.