diff --git a/pkg/cli/codemod_playwright_domains.go b/pkg/cli/codemod_playwright_domains.go index e98fae60b0c..f50b5bd3c7d 100644 --- a/pkg/cli/codemod_playwright_domains.go +++ b/pkg/cli/codemod_playwright_domains.go @@ -9,9 +9,9 @@ import ( var playwrightDomainsCodemodLog = logger.New("cli:codemod_playwright_domains") -// getPlaywrightDomainsCodemod creates a codemod that migrates tools.playwright.allowed_domains +// getPlaywrightDomainsToNetworkAllowedCodemod creates a codemod that migrates tools.playwright.allowed_domains // to network.allowed. Network egress for Playwright is now controlled by the workflow firewall. -func getPlaywrightDomainsCodemod() Codemod { +func getPlaywrightDomainsToNetworkAllowedCodemod() Codemod { return Codemod{ ID: "playwright-allowed-domains-migration", Name: "Migrate playwright allowed_domains to network.allowed", diff --git a/pkg/cli/codemod_playwright_domains_test.go b/pkg/cli/codemod_playwright_domains_test.go index 772706a8bec..6c80dfdb088 100644 --- a/pkg/cli/codemod_playwright_domains_test.go +++ b/pkg/cli/codemod_playwright_domains_test.go @@ -11,7 +11,7 @@ import ( ) func TestGetPlaywrightDomainsCodemod(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() assert.Equal(t, "playwright-allowed-domains-migration", codemod.ID, "Codemod ID should match") assert.Equal(t, "Migrate playwright allowed_domains to network.allowed", codemod.Name, "Codemod name should match") @@ -21,7 +21,7 @@ func TestGetPlaywrightDomainsCodemod(t *testing.T) { } func TestPlaywrightDomainsCodemod_NoTools(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() content := `--- on: workflow_dispatch @@ -43,7 +43,7 @@ permissions: } func TestPlaywrightDomainsCodemod_NoPlaywright(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() content := `--- on: workflow_dispatch @@ -69,7 +69,7 @@ tools: } func TestPlaywrightDomainsCodemod_NoAllowedDomains(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() content := `--- on: workflow_dispatch @@ -95,7 +95,7 @@ tools: } func TestPlaywrightDomainsCodemod_BasicMigration(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() content := `--- on: workflow_dispatch @@ -129,7 +129,7 @@ tools: } func TestPlaywrightDomainsCodemod_PreservesVersion(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() content := `--- on: workflow_dispatch @@ -164,7 +164,7 @@ tools: } func TestPlaywrightDomainsCodemod_MergesWithExistingNetwork(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() content := `--- on: workflow_dispatch @@ -203,7 +203,7 @@ network: } func TestPlaywrightDomainsCodemod_DeduplicatesDomains(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() content := `--- on: workflow_dispatch @@ -255,7 +255,7 @@ network: } func TestPlaywrightDomainsCodemod_SingleDomainString(t *testing.T) { - codemod := getPlaywrightDomainsCodemod() + codemod := getPlaywrightDomainsToNetworkAllowedCodemod() content := `--- on: workflow_dispatch diff --git a/pkg/cli/fix_codemods.go b/pkg/cli/fix_codemods.go index 6bd31bbc886..18b07b241df 100644 --- a/pkg/cli/fix_codemods.go +++ b/pkg/cli/fix_codemods.go @@ -38,20 +38,20 @@ func GetAllCodemods() []Codemod { getDiscussionFlagRemovalCodemod(), getMCPModeToTypeCodemod(), getInstallScriptURLCodemod(), - getBashAnonymousRemovalCodemod(), // Replace bash: with bash: false - newActivationOutputsCodemod(), // Transform needs.activation.outputs.* to steps.sanitized.outputs.* - getRolesToOnRolesCodemod(), // Move top-level roles to on.roles - getBotsToOnBotsCodemod(), // Move top-level bots to on.bots - getEngineStepsToTopLevelCodemod(), // Move engine.steps to top-level steps - getAssignToAgentDefaultAgentCodemod(), // Rename deprecated default-agent to name in assign-to-agent - getPlaywrightDomainsCodemod(), // Migrate tools.playwright.allowed_domains to network.allowed - getExpiresIntegerToStringCodemod(), // Convert expires integer (days) to string with 'd' suffix - getSerenaLocalModeCodemod(), // Replace tools.serena mode: local with mode: docker - getGitHubAppCodemod(), // Rename deprecated 'app' to 'github-app' - getSafeInputsToMCPScriptsCodemod(), // Rename safe-inputs to mcp-scripts - getPluginsToDependenciesCodemod(), // Migrate plugins to dependencies (plugins removed in favour of APM) - getGitHubReposToAllowedReposCodemod(), // Rename deprecated tools.github.repos to tools.github.allowed-repos - getDependenciesToImportsAPMPackagesCodemod(), // Migrate dependencies to imports.apm-packages (dependencies deprecated) + getBashAnonymousRemovalCodemod(), // Replace bash: with bash: false + newActivationOutputsCodemod(), // Transform needs.activation.outputs.* to steps.sanitized.outputs.* + getRolesToOnRolesCodemod(), // Move top-level roles to on.roles + getBotsToOnBotsCodemod(), // Move top-level bots to on.bots + getEngineStepsToTopLevelCodemod(), // Move engine.steps to top-level steps + getAssignToAgentDefaultAgentCodemod(), // Rename deprecated default-agent to name in assign-to-agent + getPlaywrightDomainsToNetworkAllowedCodemod(), // Migrate tools.playwright.allowed_domains to network.allowed + getExpiresIntegerToStringCodemod(), // Convert expires integer (days) to string with 'd' suffix + getSerenaLocalModeCodemod(), // Replace tools.serena mode: local with mode: docker + getGitHubAppCodemod(), // Rename deprecated 'app' to 'github-app' + getSafeInputsToMCPScriptsCodemod(), // Rename safe-inputs to mcp-scripts + getPluginsToDependenciesCodemod(), // Migrate plugins to dependencies (plugins removed in favour of APM) + getGitHubReposToAllowedReposCodemod(), // Rename deprecated tools.github.repos to tools.github.allowed-repos + getDependenciesToImportsAPMPackagesCodemod(), // Migrate dependencies to imports.apm-packages (dependencies deprecated) } fixCodemodsLog.Printf("Loaded codemod registry: %d codemods available", len(codemods)) return codemods