From 002819080630a551e06e013c39e91fc61349d42e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 11 Nov 2025 02:55:56 +0000 Subject: [PATCH 1/3] Initial plan From 8e4391663fb0f9d9422acb1aaa61a6e37a4dea7b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 11 Nov 2025 03:06:16 +0000 Subject: [PATCH 2/3] Remove docker-image field from cache-memory schema The docker-image field was defined in the JSON schema but not implemented in the Go parser (CacheMemoryEntry struct). This caused a mismatch where users could configure docker-image in their workflows, but the setting was silently ignored. Per @pelikhan's directive, removing the field from the schema to align with the actual implementation rather than implementing the feature. Changes: - Removed docker-image property from cache-memory object schema - Schema now correctly reflects supported fields: key, description, retention-days - Validation now properly rejects docker-image configuration - All existing tests pass Testing: - Verified schema rejects docker-image field with clear error message - Verified valid cache-memory configurations still work (object and array notation) - All unit tests pass (make test) - All linting passes (make lint) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- pkg/parser/schemas/main_workflow_schema.json | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkg/parser/schemas/main_workflow_schema.json b/pkg/parser/schemas/main_workflow_schema.json index 98b1de1d217..1973beb1559 100644 --- a/pkg/parser/schemas/main_workflow_schema.json +++ b/pkg/parser/schemas/main_workflow_schema.json @@ -2038,10 +2038,6 @@ "type": "string", "description": "Optional description for the cache that will be shown in the agent prompt" }, - "docker-image": { - "type": "string", - "description": "Docker image to use for the memory MCP server (default: mcp/memory)" - }, "retention-days": { "type": "integer", "minimum": 1, From 1a53496e430aaf5a779d0fc99d7fb048faa921da Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 11 Nov 2025 03:16:09 +0000 Subject: [PATCH 3/3] Remove docker-image from all schema files and update tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Complete removal of the docker-image field from cache-memory configuration: 1. Removed from included_file_schema.json (used for imported workflow files) 2. Updated schema_test.go: - Changed "all options" test to use valid fields only (key, retention-days, description) - Added explicit test case to verify docker-image is rejected - Fixed error message assertion for included file schema 3. Removed from documentation (frontmatter-full.md) All changes ensure schema and parser are fully aligned: - Both main and included file schemas reject docker-image - Tests verify rejection with appropriate error messages - Documentation no longer advertises unsupported feature Verification: ✅ Schema rejects docker-image with clear error: "additional properties 'docker-image' not allowed" ✅ All unit tests pass (make test) ✅ All linting passes (make lint) ✅ Manual compilation tests confirm rejection works Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .../content/docs/reference/frontmatter-full.md | 4 ---- pkg/parser/schema_test.go | 16 ++++++++++++++-- pkg/parser/schemas/included_file_schema.json | 4 ---- 3 files changed, 14 insertions(+), 10 deletions(-) diff --git a/docs/src/content/docs/reference/frontmatter-full.md b/docs/src/content/docs/reference/frontmatter-full.md index f3dac260916..519dc04e5cb 100644 --- a/docs/src/content/docs/reference/frontmatter-full.md +++ b/docs/src/content/docs/reference/frontmatter-full.md @@ -1158,10 +1158,6 @@ tools: # (optional) description: "Description of the workflow" - # Docker image to use for the memory MCP server (default: mcp/memory) - # (optional) - docker-image: "example-value" - # Number of days to retain uploaded artifacts (1-90 days, default: repository # setting) # (optional) diff --git a/pkg/parser/schema_test.go b/pkg/parser/schema_test.go index 9ae4c0effb0..86496f386a9 100644 --- a/pkg/parser/schema_test.go +++ b/pkg/parser/schema_test.go @@ -1178,13 +1178,13 @@ func TestValidateIncludedFileFrontmatterWithSchema(t *testing.T) { wantErr: false, }, { - name: "valid frontmatter with cache-memory with all options", + name: "valid frontmatter with cache-memory with all valid options", frontmatter: map[string]any{ "tools": map[string]any{ "cache-memory": map[string]any{ "key": "custom-key", "retention-days": 30, - "docker-image": "custom/memory:latest", + "description": "Test cache description", }, }, }, @@ -1214,6 +1214,18 @@ func TestValidateIncludedFileFrontmatterWithSchema(t *testing.T) { wantErr: true, errContains: "got 91, want 90", }, + { + name: "invalid cache-memory with unsupported docker-image field", + frontmatter: map[string]any{ + "tools": map[string]any{ + "cache-memory": map[string]any{ + "docker-image": "custom/memory:latest", + }, + }, + }, + wantErr: true, + errContains: "additional properties 'docker-image' not allowed", + }, { name: "invalid cache-memory with additional property", frontmatter: map[string]any{ diff --git a/pkg/parser/schemas/included_file_schema.json b/pkg/parser/schemas/included_file_schema.json index 2f71d66c675..100fef29c9b 100644 --- a/pkg/parser/schemas/included_file_schema.json +++ b/pkg/parser/schemas/included_file_schema.json @@ -120,10 +120,6 @@ "type": "string", "description": "Optional description for the cache that will be shown in the agent prompt" }, - "docker-image": { - "type": "string", - "description": "Docker image to use for the memory MCP server (default: mcp/memory)" - }, "retention-days": { "type": "integer", "minimum": 1,