From a8d27a3d4449478e5ae10850af913d9753006bea Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 9 Jun 2026 02:19:02 +0000 Subject: [PATCH] Clarify pr-finisher handling for GitHub Actions bot reviews Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/skills/pr-finisher/SKILL.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/skills/pr-finisher/SKILL.md b/.github/skills/pr-finisher/SKILL.md index 2235c19c1bb..439ac39187c 100644 --- a/.github/skills/pr-finisher/SKILL.md +++ b/.github/skills/pr-finisher/SKILL.md @@ -23,7 +23,7 @@ A PR is merge-ready when **all three** are satisfied. Work them **concurrently** | Condition | Definition | Agent's signal | |---|---|---| -| **Reviews** | Every unresolved review thread is addressed on its merits, replied to, and resolved. Code changes alone do not satisfy this. | `copilot-review` skill + GraphQL `reviewThreads` | +| **Reviews** | Every unresolved in-scope review thread is addressed on its merits, replied to, and resolved, including GitHub Actions bot threads/comments (`github-actions[bot]`). Code changes alone do not satisfy this. | `copilot-review` skill + GraphQL `reviewThreads` | | **Checks** | Local `make fmt` / `make lint` / `make test-unit` / `make test` pass. Last-known CI runs reviewed at log level. | `make` targets locally; `gh pr checks` / `gh run view --log-failed` for prior runs | | **Mergeable** | PR is OPEN, not draft, `mergeable: MERGEABLE`, not `BEHIND` if the repo requires up-to-date branches. | `gh pr view --json mergeable,mergeStateStatus,state,isDraft` | @@ -74,7 +74,7 @@ If merged/closed, report and stop. Otherwise classify each condition as ✅ / ### 2. Address Reviews -Delegate to the `copilot-review` skill. For each unresolved thread: make change → run relevant local validation → commit → push → reply → resolve. A thread is not handled until reply + resolve both succeed. +Delegate to the `copilot-review` skill. For each unresolved in-scope thread (including `github-actions[bot]`): make change → run relevant local validation → commit → push → reply → resolve. A thread is not handled until reply + resolve both succeed. ### 3. Address Mergeable @@ -152,7 +152,7 @@ The task is complete only when all are true: - `make fmt`, `make lint`, `make test-unit` all pass (or unrelated pre-existing failures explicitly identified). - `make test` was run and fixed when it was part of the failing state; wasm goldens regenerated when required. -- The `copilot-review` skill addressed all in-scope review threads (reply + resolve succeeded for each). +- The `copilot-review` skill addressed all in-scope review threads, including GitHub Actions bot review comments/threads (`github-actions[bot]`) (reply + resolve succeeded for each). - Mergeable condition was checked; conflicts resolved and `BEHIND` updated when present. - Prior CI failures were inspected at the log level and either fixed at the root cause (with a local reproduction where possible) or explicitly flagged as not locally reproducible / escalated. - Every iteration that changed files was committed and pushed, and no local changes were left unpushed at stop. No post-push re-check loop.