From bb12ecd3d9de899f658db106eab6ace29923f058 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 29 Jun 2026 22:55:24 +0000 Subject: [PATCH] fix: update Matt Pocock skill references Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .../mattpocock-skills-reviewer.lock.yml | 4 +-- .../workflows/mattpocock-skills-reviewer.md | 31 ++++++++++--------- 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/.github/workflows/mattpocock-skills-reviewer.lock.yml b/.github/workflows/mattpocock-skills-reviewer.lock.yml index b5b839c7fb5..1765bc0c3b6 100644 --- a/.github/workflows/mattpocock-skills-reviewer.lock.yml +++ b/.github/workflows/mattpocock-skills-reviewer.lock.yml @@ -1,4 +1,4 @@ -# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"c8091a0ce82ed2c24d53b81ad0a4b960d4d071ed25167d1a09c769a584538ccc","body_hash":"753cc274467b9c3d937782c9d2031e596dfd90da4926d9152d25a236721b8823","strict":true,"agent_id":"copilot","agent_model":"claude-sonnet-4.6","engine_versions":{"copilot":"1.0.65"}} +# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"8d55df2fd4892893c54938eeb7b5003444a04e43648ebc15b82637bcaa3675d1","body_hash":"62ce0bd5c9851424f73f018934c48ae0ca6493b0bc7415fdc5564e808707829a","strict":true,"agent_id":"copilot","agent_model":"claude-sonnet-4.6","engine_versions":{"copilot":"1.0.65"}} # gh-aw-manifest: {"version":1,"secrets":["GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GH_AW_OTEL_GRAFANA_AUTHORIZATION","GH_AW_OTEL_GRAFANA_ENDPOINT","GH_AW_OTEL_SENTRY_AUTHORIZATION","GH_AW_OTEL_SENTRY_ENDPOINT","GITHUB_TOKEN"],"actions":[{"repo":"actions/cache/restore","sha":"55cc8345863c7cc4c66a329aec7e433d2d1c52a9","version":"v6.1.0"},{"repo":"actions/cache/save","sha":"55cc8345863c7cc4c66a329aec7e433d2d1c52a9","version":"v6.1.0"},{"repo":"actions/checkout","sha":"9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0","version":"v7.0.0"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-node","sha":"48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.27.13","digest":"sha256:691a06b64961b5b35aac117eaace202fa721e91da19d1d2e22dcdd6663cd571b","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.27.13@sha256:691a06b64961b5b35aac117eaace202fa721e91da19d1d2e22dcdd6663cd571b"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.13","digest":"sha256:c57febf4aeeefbb4fd96f5b12c07f4279ca55edca6a700032debf9dd0787286e","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.13@sha256:c57febf4aeeefbb4fd96f5b12c07f4279ca55edca6a700032debf9dd0787286e"},{"image":"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.13","digest":"sha256:79dfd3a5d139bd1956ba6d7d1782b831a07175cf5afa29c45cb20bb0140f23c5","pinned_image":"ghcr.io/github/gh-aw-firewall/cli-proxy:0.27.13@sha256:79dfd3a5d139bd1956ba6d7d1782b831a07175cf5afa29c45cb20bb0140f23c5"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.27.13","digest":"sha256:700b1b5a73098373b04fb684f291e95d9be0124ab559717b04f27acaf8b41bed","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.27.13@sha256:700b1b5a73098373b04fb684f291e95d9be0124ab559717b04f27acaf8b41bed"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.32","digest":"sha256:63e46b56dfd70895a701b6fc6dd0189e11e2d875f327f1781e81b31848735477","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.32@sha256:63e46b56dfd70895a701b6fc6dd0189e11e2d875f327f1781e81b31848735477"},{"image":"ghcr.io/github/gh-aw-node","digest":"sha256:529d02eb970b1161aa25c593a9c3df57fdfad5a8add328cb3b6eccef66f3183b","pinned_image":"ghcr.io/github/gh-aw-node@sha256:529d02eb970b1161aa25c593a9c3df57fdfad5a8add328cb3b6eccef66f3183b"},{"image":"ghcr.io/github/github-mcp-server:v1.5.0","digest":"sha256:e25564dccc9110a70a77b9df560cbde11aa392fcb5f08b9abe5c4ebc6d146ea4","pinned_image":"ghcr.io/github/github-mcp-server:v1.5.0@sha256:e25564dccc9110a70a77b9df560cbde11aa392fcb5f08b9abe5c4ebc6d146ea4"}]} # This file was automatically generated by gh-aw. DO NOT EDIT. To debug this workflow, load the skill at https://github.com/github/gh-aw/blob/main/debug.md # @@ -590,7 +590,7 @@ jobs: - env: GH_TOKEN: ${{ github.token }} name: Install Matt Pocock skills - run: "set -euo pipefail\nSKILLS_DST=\"${RUNNER_TEMP}/gh-aw/mattpocock-skills\"\nmkdir -p \"${SKILLS_DST}\"\n# Install only the skills referenced in this workflow's prompt, rather than\n# all published skills, to reduce install time and network overhead.\nfor skill in diagnose tdd zoom-out improve-codebase-architecture grill-with-docs to-prd; do\n gh skill install mattpocock/skills \"${skill}\" --dir \"${SKILLS_DST}\" --force\ndone\nSKILL_COUNT=$(find \"${SKILLS_DST}\" -name \"SKILL.md\" | wc -l)\necho \"Installed ${SKILL_COUNT} skill(s):\"\nfind \"${SKILLS_DST}\" -name \"SKILL.md\" | head -20\nif [ \"${SKILL_COUNT}\" -eq 0 ]; then\n echo \"::error::No SKILL.md files found after installing mattpocock/skills\"\n exit 1\nfi\n" + run: "set -euo pipefail\nSKILLS_DST=\"${RUNNER_TEMP}/gh-aw/mattpocock-skills\"\nmkdir -p \"${SKILLS_DST}\"\n# Install only the skills referenced in this workflow's prompt, rather than\n# all published skills, to reduce install time and network overhead.\nfor skill in diagnosing-bugs tdd improve-codebase-architecture grill-with-docs to-prd codebase-design domain-modeling; do\n gh skill install mattpocock/skills \"${skill}\" --dir \"${SKILLS_DST}\" --force\ndone\nSKILL_COUNT=$(find \"${SKILLS_DST}\" -name \"SKILL.md\" | wc -l)\necho \"Installed ${SKILL_COUNT} skill(s):\"\nfind \"${SKILLS_DST}\" -name \"SKILL.md\" | head -20\nif [ \"${SKILL_COUNT}\" -eq 0 ]; then\n echo \"::error::No SKILL.md files found after installing mattpocock/skills\"\n exit 1\nfi\n" - env: EXPR_GITHUB_REPOSITORY: ${{ github.repository }} GH_TOKEN: ${{ github.token }} diff --git a/.github/workflows/mattpocock-skills-reviewer.md b/.github/workflows/mattpocock-skills-reviewer.md index f0380b1bdce..4e022c5b4ba 100644 --- a/.github/workflows/mattpocock-skills-reviewer.md +++ b/.github/workflows/mattpocock-skills-reviewer.md @@ -47,7 +47,7 @@ pre-agent-steps: mkdir -p "${SKILLS_DST}" # Install only the skills referenced in this workflow's prompt, rather than # all published skills, to reduce install time and network overhead. - for skill in diagnose tdd zoom-out improve-codebase-architecture grill-with-docs to-prd; do + for skill in diagnosing-bugs tdd improve-codebase-architecture grill-with-docs to-prd codebase-design domain-modeling; do gh skill install mattpocock/skills "${skill}" --dir "${SKILLS_DST}" --force done SKILL_COUNT=$(find "${SKILLS_DST}" -name "SKILL.md" | wc -l) @@ -117,10 +117,11 @@ You are a skilled engineering reviewer who applies [Matt Pocock's engineering sk The following skills have been installed via `gh skill` and are available under `${RUNNER_TEMP}/gh-aw/mattpocock-skills/`. Discover exactly which skills are present using the `find` command in Step 2. -- **`/diagnose`** — Disciplined debugging loop: reproduce → minimise → hypothesise → instrument → fix → regression-test. Use for PRs that fix bugs or address performance regressions. +- **`/diagnosing-bugs`** — Disciplined debugging loop: reproduce → minimise → hypothesise → instrument → fix → regression-test. Use for PRs that fix bugs or address performance regressions. - **`/tdd`** — Test-driven development: red-green-refactor loop. Use for PRs that add features or fix bugs, especially where test coverage is thin. -- **`/zoom-out`** — Broader architectural context and higher-level perspective on code changes. Use for large refactors or when reviewing unfamiliar modules. +- **`/codebase-design`** — Shared vocabulary for deep modules, interface seams, and codebase navigability. Use for large refactors or when reviewing unfamiliar modules. - **`/improve-codebase-architecture`** — Find deepening opportunities informed by the domain language. Use for PRs that restructure or extend the architecture. +- **`/domain-modeling`** — Sharpen project terminology and architectural context. Use when changes introduce or rename concepts. - **`/grill-with-docs`** — Challenges the plan against the existing domain model and terminology. Use when changes introduce new concepts or abstractions. - **`/to-prd`** — Turn context into a PRD. Use when the PR description is unclear or the scope is hard to understand. @@ -166,13 +167,13 @@ Focus your skill application on files listed in `pr-triage`'s `high_impact_files Apply the skill(s) to review the changed lines. For each issue you find: - **Identify the file and line number** in the diff -- **Explain the issue** in terms of the skill's principles (e.g. missing test coverage per `/tdd`, unclear abstraction per `/zoom-out`) +- **Explain the issue** in terms of the skill's principles (e.g. missing test coverage per `/tdd`, unclear abstraction per `/codebase-design`) - **Provide a concrete suggestion** — what to do differently and why - **Keep it actionable** — the author should know exactly what to change Focus areas by skill: -**`/diagnose` guidance:** +**`/diagnosing-bugs` guidance:** - Is the bug fix accompanied by a regression test? - Is the root cause properly addressed, or only the symptom? - Are error paths instrumented to surface future regressions? @@ -183,7 +184,7 @@ Focus areas by skill: - Are test names descriptive — do they read as specifications? - Is test structure clear: Arrange / Act / Assert? -**`/zoom-out` guidance:** +**`/codebase-design` guidance:** - Does the change fit the broader architecture? - Are new abstractions consistent with existing patterns? - Could this change make the codebase harder to navigate? @@ -211,7 +212,7 @@ For each issue found, create a review comment using `create-pull-request-review- ``` Guidelines: -- Prefix each comment with the skill name in brackets: `**[/diagnose]**`, `**[/tdd]**`, etc. +- Prefix each comment with the skill name in brackets: `**[/diagnosing-bugs]**`, `**[/tdd]**`, etc. - Keep the **immediately visible text brief** (1–2 sentences): state the issue and its impact - Wrap code examples, detailed explanations, and multi-step suggestions in `
💡 …` blocks - Be specific: file path, line number, exact issue @@ -234,7 +235,7 @@ The review body should apply progressive disclosure — keep the immediately vis ```markdown ### Skills-Based Review 🧠 -Applied **`/tdd`** and **`/zoom-out`** — requesting changes on test coverage gaps. +Applied **`/tdd`** and **`/codebase-design`** — requesting changes on test coverage gaps.
📋 Key Themes & Highlights @@ -299,28 +300,28 @@ Tasks: - `documentation` - `mixed_unclear` 3. Choose 1–2 `recommended_skills` from: - - `/diagnose` + - `/diagnosing-bugs` - `/tdd` - - `/zoom-out` + - `/codebase-design` - `/improve-codebase-architecture` - `/grill-with-docs` 4. Rank changed files as `high_impact_files` (most important first), including enough files to cover the key risk areas. 5. Provide concise `key_signals` that justify classification and ranking. Skill mapping: -- `bug_fix` → `/diagnose`, `/tdd` +- `bug_fix` → `/diagnosing-bugs`, `/tdd` - `new_feature` → `/tdd`, `/grill-with-docs` -- `refactor_cleanup` → `/zoom-out`, `/improve-codebase-architecture` -- `architecture_change` → `/improve-codebase-architecture`, `/zoom-out` +- `refactor_cleanup` → `/codebase-design`, `/improve-codebase-architecture` +- `architecture_change` → `/improve-codebase-architecture`, `/codebase-design` - `tests_only` → `/tdd` - `documentation` → `/grill-with-docs` -- `mixed_unclear` → `/zoom-out`, `/tdd` +- `mixed_unclear` → `/codebase-design`, `/tdd` Return JSON only (no markdown) in this exact shape: ```json { "change_type": "bug_fix", - "recommended_skills": ["/diagnose", "/tdd"], + "recommended_skills": ["/diagnosing-bugs", "/tdd"], "high_impact_files": [ { "path": "pkg/example/file.go",