From c05d133b19d12220f88629c37f0eeb442882582a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:36:06 +0000 Subject: [PATCH 1/8] Initial plan From b2846c32edfc734d5a57005b108117f6c53f65c3 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:47:12 +0000 Subject: [PATCH 2/8] Move noop JavaScript step to conclusion job and remove noop job - Modified notify_comment.go to add noop processing step to conclusion job - Added noop_message output to conclusion job when noop is configured - Removed noop job generation from compiler_jobs.go - Verified all test workflows compile correctly with new structure - All unit tests pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/workflows/ai-triage-campaign.lock.yml | 212 ++++++++--------- .github/workflows/archie.lock.yml | 212 ++++++++--------- .github/workflows/artifacts-summary.lock.yml | 212 ++++++++--------- .github/workflows/audit-workflows.lock.yml | 214 ++++++++--------- .github/workflows/blog-auditor.lock.yml | 214 ++++++++--------- .github/workflows/brave.lock.yml | 212 ++++++++--------- .github/workflows/changeset.lock.yml | 212 ++++++++--------- .github/workflows/ci-doctor.lock.yml | 216 ++++++++---------- .../cli-consistency-checker.lock.yml | 212 ++++++++--------- .../workflows/cli-version-checker.lock.yml | 212 ++++++++--------- .github/workflows/cloclo.lock.yml | 212 ++++++++--------- .../commit-changes-analyzer.lock.yml | 212 ++++++++--------- .../workflows/copilot-agent-analysis.lock.yml | 212 ++++++++--------- .../copilot-pr-nlp-analysis.lock.yml | 212 ++++++++--------- .../copilot-pr-prompt-analysis.lock.yml | 212 ++++++++--------- .../copilot-session-insights.lock.yml | 212 ++++++++--------- .github/workflows/craft.lock.yml | 212 ++++++++--------- .github/workflows/daily-code-metrics.lock.yml | 212 ++++++++--------- .github/workflows/daily-doc-updater.lock.yml | 212 ++++++++--------- .github/workflows/daily-file-diet.lock.yml | 212 ++++++++--------- .../workflows/daily-firewall-report.lock.yml | 212 ++++++++--------- .../daily-multi-device-docs-tester.lock.yml | 212 ++++++++--------- .github/workflows/daily-news.lock.yml | 214 ++++++++--------- .../workflows/daily-repo-chronicle.lock.yml | 214 ++++++++--------- .github/workflows/daily-team-status.lock.yml | 216 ++++++++---------- .../workflows/dependabot-go-checker.lock.yml | 212 ++++++++--------- .github/workflows/dev-hawk.lock.yml | 212 ++++++++--------- .github/workflows/dev.lock.yml | 212 ++++++++--------- .../developer-docs-consolidator.lock.yml | 212 ++++++++--------- .github/workflows/dictation-prompt.lock.yml | 212 ++++++++--------- .github/workflows/docs-noob-tester.lock.yml | 212 ++++++++--------- .../duplicate-code-detector.lock.yml | 212 ++++++++--------- .../example-workflow-analyzer.lock.yml | 212 ++++++++--------- .../github-mcp-tools-report.lock.yml | 212 ++++++++--------- .github/workflows/go-logger.lock.yml | 212 ++++++++--------- .../workflows/go-pattern-detector.lock.yml | 212 ++++++++--------- .github/workflows/grumpy-reviewer.lock.yml | 212 ++++++++--------- .../workflows/instructions-janitor.lock.yml | 212 ++++++++--------- .github/workflows/issue-classifier.lock.yml | 212 ++++++++--------- .github/workflows/lockfile-stats.lock.yml | 212 ++++++++--------- .github/workflows/mcp-inspector.lock.yml | 212 ++++++++--------- .github/workflows/mergefest.lock.yml | 212 ++++++++--------- .github/workflows/pdf-summary.lock.yml | 212 ++++++++--------- .github/workflows/plan.lock.yml | 212 ++++++++--------- .github/workflows/poem-bot.lock.yml | 212 ++++++++--------- .../workflows/pr-nitpick-reviewer.lock.yml | 212 ++++++++--------- .../prompt-clustering-analysis.lock.yml | 212 ++++++++--------- .github/workflows/python-data-charts.lock.yml | 212 ++++++++--------- .github/workflows/q.lock.yml | 212 ++++++++--------- .github/workflows/repo-tree-map.lock.yml | 212 ++++++++--------- .../repository-quality-improver.lock.yml | 212 ++++++++--------- .github/workflows/research.lock.yml | 212 ++++++++--------- .github/workflows/safe-output-health.lock.yml | 212 ++++++++--------- .../schema-consistency-checker.lock.yml | 212 ++++++++--------- .github/workflows/scout.lock.yml | 212 ++++++++--------- .github/workflows/security-fix-pr.lock.yml | 212 ++++++++--------- .../semantic-function-refactor.lock.yml | 212 ++++++++--------- .github/workflows/smoke-claude.lock.yml | 212 ++++++++--------- .github/workflows/smoke-codex.lock.yml | 212 ++++++++--------- .github/workflows/smoke-copilot.lock.yml | 212 ++++++++--------- .github/workflows/smoke-detector.lock.yml | 212 ++++++++--------- .../workflows/static-analysis-report.lock.yml | 212 ++++++++--------- .github/workflows/super-linter.lock.yml | 212 ++++++++--------- .../workflows/technical-doc-writer.lock.yml | 212 ++++++++--------- .../test-ollama-threat-detection.lock.yml | 212 ++++++++--------- .github/workflows/tidy.lock.yml | 212 ++++++++--------- .github/workflows/typist.lock.yml | 212 ++++++++--------- .github/workflows/unbloat-docs.lock.yml | 212 ++++++++--------- .github/workflows/video-analyzer.lock.yml | 212 ++++++++--------- .../workflows/weekly-issue-summary.lock.yml | 214 ++++++++--------- pkg/workflow/compiler_jobs.go | 18 +- pkg/workflow/notify_comment.go | 30 +++ 72 files changed, 6830 insertions(+), 8076 deletions(-) diff --git a/.github/workflows/ai-triage-campaign.lock.yml b/.github/workflows/ai-triage-campaign.lock.yml index 2f5f6917143..a5645dc67ab 100644 --- a/.github/workflows/ai-triage-campaign.lock.yml +++ b/.github/workflows/ai-triage-campaign.lock.yml @@ -13,19 +13,15 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # update_project["update_project"] # activation --> agent # agent --> conclusion # activation --> conclusion # missing_tool --> conclusion # update_project --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> update_project # detection --> update_project # ``` @@ -3585,7 +3581,6 @@ jobs: - activation - missing_tool - update_project - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3593,6 +3588,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3616,6 +3613,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "AI Triage Campaign" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4152,116 +4244,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "AI Triage Campaign" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - update_project: needs: - agent diff --git a/.github/workflows/archie.lock.yml b/.github/workflows/archie.lock.yml index 8b5a2415a0b..aa301910fa3 100644 --- a/.github/workflows/archie.lock.yml +++ b/.github/workflows/archie.lock.yml @@ -18,7 +18,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -28,12 +27,9 @@ # activation --> conclusion # add_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4699,7 +4695,6 @@ jobs: - activation - add_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4707,6 +4702,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4730,6 +4727,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Archie" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5266,116 +5358,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Archie" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > (github.event_name == 'issues') && (contains(github.event.issue.body, '/archie')) || diff --git a/.github/workflows/artifacts-summary.lock.yml b/.github/workflows/artifacts-summary.lock.yml index 51bf5cd331d..117bee81c09 100644 --- a/.github/workflows/artifacts-summary.lock.yml +++ b/.github/workflows/artifacts-summary.lock.yml @@ -18,20 +18,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3898,7 +3894,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3906,6 +3901,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3929,6 +3926,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Artifacts Summary" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4739,113 +4831,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Artifacts Summary" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/audit-workflows.lock.yml b/.github/workflows/audit-workflows.lock.yml index 5f2f1e75327..aaa510cf46a 100644 --- a/.github/workflows/audit-workflows.lock.yml +++ b/.github/workflows/audit-workflows.lock.yml @@ -22,7 +22,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -30,14 +29,11 @@ # create_discussion --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4149,7 +4145,6 @@ jobs: - create_discussion - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4157,6 +4152,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4180,6 +4177,102 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Agentic Workflow Audit Agent" + GH_AW_CAMPAIGN: "audit-workflows-daily" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5001,117 +5094,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Agentic Workflow Audit Agent" - GH_AW_CAMPAIGN: "audit-workflows-daily" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/blog-auditor.lock.yml b/.github/workflows/blog-auditor.lock.yml index 10f05958ec2..9933e12de36 100644 --- a/.github/workflows/blog-auditor.lock.yml +++ b/.github/workflows/blog-auditor.lock.yml @@ -18,20 +18,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3486,7 +3482,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3494,6 +3489,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3517,6 +3514,102 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Blog Auditor" + GH_AW_CAMPAIGN: "blog-auditor-weekly" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4339,114 +4432,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Blog Auditor" - GH_AW_CAMPAIGN: "blog-auditor-weekly" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/brave.lock.yml b/.github/workflows/brave.lock.yml index d99e5e6baba..cc1f50f0847 100644 --- a/.github/workflows/brave.lock.yml +++ b/.github/workflows/brave.lock.yml @@ -18,7 +18,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -28,12 +27,9 @@ # activation --> conclusion # add_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4546,7 +4542,6 @@ jobs: - activation - add_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4554,6 +4549,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4577,6 +4574,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Brave Web Search Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5113,116 +5205,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Brave Web Search Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > (github.event_name == 'issue_comment') && ((contains(github.event.comment.body, '/brave')) && (github.event.issue.pull_request == null)) diff --git a/.github/workflows/changeset.lock.yml b/.github/workflows/changeset.lock.yml index 514616f976c..80b0a83856d 100644 --- a/.github/workflows/changeset.lock.yml +++ b/.github/workflows/changeset.lock.yml @@ -18,7 +18,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # push_to_pull_request_branch["push_to_pull_request_branch"] # pre_activation --> activation @@ -27,12 +26,9 @@ # activation --> conclusion # push_to_pull_request_branch --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> push_to_pull_request_branch # activation --> push_to_pull_request_branch # detection --> push_to_pull_request_branch @@ -4741,7 +4737,6 @@ jobs: - activation - push_to_pull_request_branch - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4749,6 +4744,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4772,6 +4769,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Changeset Generator" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5258,116 +5350,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Changeset Generator" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event.pull_request.base.ref == github.event.repository.default_branch) && ((github.event_name != 'pull_request') || diff --git a/.github/workflows/ci-doctor.lock.yml b/.github/workflows/ci-doctor.lock.yml index da0c0a0708e..6b06a1d8acf 100644 --- a/.github/workflows/ci-doctor.lock.yml +++ b/.github/workflows/ci-doctor.lock.yml @@ -19,7 +19,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -31,14 +30,11 @@ # create_issue --> conclusion # add_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4017,7 +4013,6 @@ jobs: - create_issue - add_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4025,6 +4020,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4048,6 +4045,103 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "CI Failure Doctor" + GH_AW_WORKFLOW_SOURCE: "githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d" + GH_AW_WORKFLOW_SOURCE_URL: "${{ github.server_url }}/githubnext/agentics/tree/ea350161ad5dcc9624cf510f134c6a9e39a6f94d/workflows/ci-doctor.md" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4944,118 +5038,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "CI Failure Doctor" - GH_AW_WORKFLOW_SOURCE: "githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d" - GH_AW_WORKFLOW_SOURCE_URL: "${{ github.server_url }}/githubnext/agentics/tree/ea350161ad5dcc9624cf510f134c6a9e39a6f94d/workflows/ci-doctor.md" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: ${{ github.event.workflow_run.conclusion == 'failure' }} runs-on: ubuntu-slim diff --git a/.github/workflows/cli-consistency-checker.lock.yml b/.github/workflows/cli-consistency-checker.lock.yml index a105a0812ca..e2e615af2b8 100644 --- a/.github/workflows/cli-consistency-checker.lock.yml +++ b/.github/workflows/cli-consistency-checker.lock.yml @@ -14,20 +14,16 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3936,7 +3932,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3944,6 +3939,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3967,6 +3964,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "CLI Consistency Checker" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4860,113 +4952,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "CLI Consistency Checker" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/cli-version-checker.lock.yml b/.github/workflows/cli-version-checker.lock.yml index a7a8b414d2d..342344e8fae 100644 --- a/.github/workflows/cli-version-checker.lock.yml +++ b/.github/workflows/cli-version-checker.lock.yml @@ -18,20 +18,16 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4126,7 +4122,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4134,6 +4129,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4157,6 +4154,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "CLI Version Checker" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5050,113 +5142,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "CLI Version Checker" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/cloclo.lock.yml b/.github/workflows/cloclo.lock.yml index 245dd55740a..a0c65b5e45a 100644 --- a/.github/workflows/cloclo.lock.yml +++ b/.github/workflows/cloclo.lock.yml @@ -19,7 +19,6 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # push_to_pull_request_branch["push_to_pull_request_branch"] # pre_activation --> activation @@ -33,15 +32,12 @@ # add_comment --> conclusion # push_to_pull_request_branch --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> push_to_pull_request_branch # activation --> push_to_pull_request_branch # detection --> push_to_pull_request_branch @@ -4793,7 +4789,6 @@ jobs: - add_comment - push_to_pull_request_branch - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4801,6 +4796,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4824,6 +4821,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Claude Command Processor - /cloclo" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5994,116 +6086,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Claude Command Processor - /cloclo" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > (github.event_name == 'issues') && (contains(github.event.issue.body, '/cloclo')) || diff --git a/.github/workflows/commit-changes-analyzer.lock.yml b/.github/workflows/commit-changes-analyzer.lock.yml index 2cfc693943a..26c08e2c46b 100644 --- a/.github/workflows/commit-changes-analyzer.lock.yml +++ b/.github/workflows/commit-changes-analyzer.lock.yml @@ -18,20 +18,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3417,7 +3413,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3425,6 +3420,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3448,6 +3445,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Commit Changes Analyzer" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4267,113 +4359,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Commit Changes Analyzer" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/copilot-agent-analysis.lock.yml b/.github/workflows/copilot-agent-analysis.lock.yml index ab4fa8d2b0a..4aea159ea49 100644 --- a/.github/workflows/copilot-agent-analysis.lock.yml +++ b/.github/workflows/copilot-agent-analysis.lock.yml @@ -20,20 +20,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3780,7 +3776,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3788,6 +3783,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3811,6 +3808,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Copilot Agent PR Analysis" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4630,113 +4722,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Copilot Agent PR Analysis" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/copilot-pr-nlp-analysis.lock.yml b/.github/workflows/copilot-pr-nlp-analysis.lock.yml index a2069d23a2c..526c1f64082 100644 --- a/.github/workflows/copilot-pr-nlp-analysis.lock.yml +++ b/.github/workflows/copilot-pr-nlp-analysis.lock.yml @@ -21,20 +21,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4673,7 +4669,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4681,6 +4676,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4704,6 +4701,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Copilot PR Conversation NLP Analysis" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5515,113 +5607,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Copilot PR Conversation NLP Analysis" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/copilot-pr-prompt-analysis.lock.yml b/.github/workflows/copilot-pr-prompt-analysis.lock.yml index 7169fba63d0..d487a089479 100644 --- a/.github/workflows/copilot-pr-prompt-analysis.lock.yml +++ b/.github/workflows/copilot-pr-prompt-analysis.lock.yml @@ -20,20 +20,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4239,7 +4235,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4247,6 +4242,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4270,6 +4267,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Copilot PR Prompt Pattern Analysis" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5081,113 +5173,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Copilot PR Prompt Pattern Analysis" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/copilot-session-insights.lock.yml b/.github/workflows/copilot-session-insights.lock.yml index 720391e711d..b4005e54405 100644 --- a/.github/workflows/copilot-session-insights.lock.yml +++ b/.github/workflows/copilot-session-insights.lock.yml @@ -21,7 +21,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -29,14 +28,11 @@ # create_discussion --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4698,7 +4694,6 @@ jobs: - create_discussion - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4706,6 +4701,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4729,6 +4726,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Copilot Session Insights" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5548,116 +5640,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Copilot Session Insights" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/craft.lock.yml b/.github/workflows/craft.lock.yml index 9d1c15b72de..59ff6c80873 100644 --- a/.github/workflows/craft.lock.yml +++ b/.github/workflows/craft.lock.yml @@ -14,7 +14,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # push_to_pull_request_branch["push_to_pull_request_branch"] # pre_activation --> activation @@ -26,12 +25,9 @@ # add_comment --> conclusion # push_to_pull_request_branch --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> push_to_pull_request_branch # activation --> push_to_pull_request_branch # detection --> push_to_pull_request_branch @@ -4832,7 +4828,6 @@ jobs: - add_comment - push_to_pull_request_branch - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4840,6 +4835,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4863,6 +4860,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Workflow Craft Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5399,116 +5491,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Workflow Craft Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: (github.event_name == 'issues') && (contains(github.event.issue.body, '/craft')) runs-on: ubuntu-slim diff --git a/.github/workflows/daily-code-metrics.lock.yml b/.github/workflows/daily-code-metrics.lock.yml index 13868220c26..4d8ddeb9dd3 100644 --- a/.github/workflows/daily-code-metrics.lock.yml +++ b/.github/workflows/daily-code-metrics.lock.yml @@ -18,20 +18,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3760,7 +3756,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3768,6 +3763,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3791,6 +3788,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Daily Code Metrics and Trend Tracking Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4609,113 +4701,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Daily Code Metrics and Trend Tracking Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/daily-doc-updater.lock.yml b/.github/workflows/daily-doc-updater.lock.yml index f25412b951e..71bd0a2bd68 100644 --- a/.github/workflows/daily-doc-updater.lock.yml +++ b/.github/workflows/daily-doc-updater.lock.yml @@ -14,21 +14,17 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_pull_request --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3477,7 +3473,6 @@ jobs: - activation - create_pull_request - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3485,6 +3480,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3508,6 +3505,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Daily Documentation Updater" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4691,113 +4783,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Daily Documentation Updater" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/daily-file-diet.lock.yml b/.github/workflows/daily-file-diet.lock.yml index 1921d318b86..c913cb5571f 100644 --- a/.github/workflows/daily-file-diet.lock.yml +++ b/.github/workflows/daily-file-diet.lock.yml @@ -19,7 +19,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # activation --> agent @@ -27,14 +26,11 @@ # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3094,7 +3090,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3102,6 +3097,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3125,6 +3122,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Daily File Diet" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4006,116 +4098,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Daily File Diet" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: runs-on: ubuntu-slim outputs: diff --git a/.github/workflows/daily-firewall-report.lock.yml b/.github/workflows/daily-firewall-report.lock.yml index f77be7b531f..2e192688240 100644 --- a/.github/workflows/daily-firewall-report.lock.yml +++ b/.github/workflows/daily-firewall-report.lock.yml @@ -20,7 +20,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -28,14 +27,11 @@ # create_discussion --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4665,7 +4661,6 @@ jobs: - create_discussion - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4673,6 +4668,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4696,6 +4693,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Daily Firewall Logs Collector and Reporter" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5506,116 +5598,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Daily Firewall Logs Collector and Reporter" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/daily-multi-device-docs-tester.lock.yml b/.github/workflows/daily-multi-device-docs-tester.lock.yml index 3f69d2e3527..c80c8d964e8 100644 --- a/.github/workflows/daily-multi-device-docs-tester.lock.yml +++ b/.github/workflows/daily-multi-device-docs-tester.lock.yml @@ -14,7 +14,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -22,14 +21,11 @@ # create_issue --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -3279,7 +3275,6 @@ jobs: - create_issue - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3287,6 +3282,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3310,6 +3307,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Multi-Device Docs Tester" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4210,116 +4302,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Multi-Device Docs Tester" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/daily-news.lock.yml b/.github/workflows/daily-news.lock.yml index b37a41a2d10..7d72325b162 100644 --- a/.github/workflows/daily-news.lock.yml +++ b/.github/workflows/daily-news.lock.yml @@ -22,7 +22,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -30,14 +29,11 @@ # create_discussion --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4674,7 +4670,6 @@ jobs: - create_discussion - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4682,6 +4677,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4705,6 +4702,102 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Daily News" + GH_AW_CAMPAIGN: "daily-news-weekday" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5518,117 +5611,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Daily News" - GH_AW_CAMPAIGN: "daily-news-weekday" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/daily-repo-chronicle.lock.yml b/.github/workflows/daily-repo-chronicle.lock.yml index d88dae8aa03..d7a0899d830 100644 --- a/.github/workflows/daily-repo-chronicle.lock.yml +++ b/.github/workflows/daily-repo-chronicle.lock.yml @@ -20,7 +20,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -28,14 +27,11 @@ # create_discussion --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4518,7 +4514,6 @@ jobs: - create_discussion - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4526,6 +4521,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4549,6 +4546,102 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "The Daily Repository Chronicle" + GH_AW_CAMPAIGN: "daily-repo-chronicle" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5362,117 +5455,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "The Daily Repository Chronicle" - GH_AW_CAMPAIGN: "daily-repo-chronicle" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/daily-team-status.lock.yml b/.github/workflows/daily-team-status.lock.yml index 1996d43df51..f73aa8bd954 100644 --- a/.github/workflows/daily-team-status.lock.yml +++ b/.github/workflows/daily-team-status.lock.yml @@ -26,7 +26,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # activation --> agent @@ -34,14 +33,11 @@ # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3462,7 +3458,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3470,6 +3465,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3493,6 +3490,103 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Daily Team Status" + GH_AW_WORKFLOW_SOURCE: "githubnext/agentics/workflows/daily-team-status.md@d3422bf940923ef1d43db5559652b8e1e71869f3" + GH_AW_WORKFLOW_SOURCE_URL: "${{ github.server_url }}/githubnext/agentics/tree/d3422bf940923ef1d43db5559652b8e1e71869f3/workflows/daily-team-status.md" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4308,118 +4402,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Daily Team Status" - GH_AW_WORKFLOW_SOURCE: "githubnext/agentics/workflows/daily-team-status.md@d3422bf940923ef1d43db5559652b8e1e71869f3" - GH_AW_WORKFLOW_SOURCE_URL: "${{ github.server_url }}/githubnext/agentics/tree/d3422bf940923ef1d43db5559652b8e1e71869f3/workflows/daily-team-status.md" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: runs-on: ubuntu-slim outputs: diff --git a/.github/workflows/dependabot-go-checker.lock.yml b/.github/workflows/dependabot-go-checker.lock.yml index 91cbd2b5f43..03244f44016 100644 --- a/.github/workflows/dependabot-go-checker.lock.yml +++ b/.github/workflows/dependabot-go-checker.lock.yml @@ -14,20 +14,16 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3603,7 +3599,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3611,6 +3606,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3634,6 +3631,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Dependabot Dependency Checker" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4527,113 +4619,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Dependabot Dependency Checker" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/dev-hawk.lock.yml b/.github/workflows/dev-hawk.lock.yml index 413ce3029ce..902761a5c1d 100644 --- a/.github/workflows/dev-hawk.lock.yml +++ b/.github/workflows/dev-hawk.lock.yml @@ -14,7 +14,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -24,12 +23,9 @@ # activation --> conclusion # add_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3906,7 +3902,6 @@ jobs: - activation - add_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -3914,6 +3909,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3937,6 +3934,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Dev Hawk" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4475,116 +4567,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Dev Hawk" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: ${{ github.event.workflow_run.event == 'workflow_dispatch' }} runs-on: ubuntu-slim diff --git a/.github/workflows/dev.lock.yml b/.github/workflows/dev.lock.yml index c5a982f78cb..f86272a5daa 100644 --- a/.github/workflows/dev.lock.yml +++ b/.github/workflows/dev.lock.yml @@ -13,7 +13,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # push_to_pull_request_branch["push_to_pull_request_branch"] # update_release["update_release"] @@ -24,12 +23,9 @@ # push_to_pull_request_branch --> conclusion # missing_tool --> conclusion # update_release --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> push_to_pull_request_branch # activation --> push_to_pull_request_branch # detection --> push_to_pull_request_branch @@ -3852,7 +3848,6 @@ jobs: - push_to_pull_request_branch - missing_tool - update_release - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3860,6 +3855,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3883,6 +3880,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Dev" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4680,116 +4772,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Dev" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: runs-on: ubuntu-slim outputs: diff --git a/.github/workflows/developer-docs-consolidator.lock.yml b/.github/workflows/developer-docs-consolidator.lock.yml index 0d6456dfb18..0af9c96fed3 100644 --- a/.github/workflows/developer-docs-consolidator.lock.yml +++ b/.github/workflows/developer-docs-consolidator.lock.yml @@ -20,14 +20,12 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # create_pull_request --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> create_pull_request @@ -36,8 +34,6 @@ # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4030,7 +4026,6 @@ jobs: - create_discussion - create_pull_request - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4038,6 +4033,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4061,6 +4058,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Developer Documentation Consolidator" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5502,113 +5594,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Developer Documentation Consolidator" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/dictation-prompt.lock.yml b/.github/workflows/dictation-prompt.lock.yml index 2d266579b22..e852bcb43b4 100644 --- a/.github/workflows/dictation-prompt.lock.yml +++ b/.github/workflows/dictation-prompt.lock.yml @@ -18,21 +18,17 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_pull_request --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3657,7 +3653,6 @@ jobs: - activation - create_pull_request - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3665,6 +3660,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3688,6 +3685,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Dictation Prompt Generator" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4849,113 +4941,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Dictation Prompt Generator" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/docs-noob-tester.lock.yml b/.github/workflows/docs-noob-tester.lock.yml index ba59d2d2d91..b2469f5c253 100644 --- a/.github/workflows/docs-noob-tester.lock.yml +++ b/.github/workflows/docs-noob-tester.lock.yml @@ -14,7 +14,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -22,14 +21,11 @@ # create_discussion --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -3958,7 +3954,6 @@ jobs: - create_discussion - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3966,6 +3961,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3989,6 +3986,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Documentation Noob Tester" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4799,116 +4891,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Documentation Noob Tester" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/duplicate-code-detector.lock.yml b/.github/workflows/duplicate-code-detector.lock.yml index b89439eb21c..c265a94ad88 100644 --- a/.github/workflows/duplicate-code-detector.lock.yml +++ b/.github/workflows/duplicate-code-detector.lock.yml @@ -18,20 +18,16 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3009,7 +3005,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3017,6 +3012,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3040,6 +3037,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Duplicate Code Detector" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -3981,113 +4073,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Duplicate Code Detector" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/example-workflow-analyzer.lock.yml b/.github/workflows/example-workflow-analyzer.lock.yml index 46f60924ea4..b2f79bb6c09 100644 --- a/.github/workflows/example-workflow-analyzer.lock.yml +++ b/.github/workflows/example-workflow-analyzer.lock.yml @@ -18,20 +18,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3199,7 +3195,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3207,6 +3202,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3230,6 +3227,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Weekly Workflow Analysis" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4049,113 +4141,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Weekly Workflow Analysis" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/github-mcp-tools-report.lock.yml b/.github/workflows/github-mcp-tools-report.lock.yml index 03925d459b8..25bcba83f96 100644 --- a/.github/workflows/github-mcp-tools-report.lock.yml +++ b/.github/workflows/github-mcp-tools-report.lock.yml @@ -19,14 +19,12 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # create_pull_request --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> create_pull_request @@ -35,8 +33,6 @@ # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3852,7 +3848,6 @@ jobs: - create_discussion - create_pull_request - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3860,6 +3855,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3883,6 +3880,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "GitHub MCP Remote Server Tools Report Generator" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5338,113 +5430,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "GitHub MCP Remote Server Tools Report Generator" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/go-logger.lock.yml b/.github/workflows/go-logger.lock.yml index 6f2b1690784..77be29e43d3 100644 --- a/.github/workflows/go-logger.lock.yml +++ b/.github/workflows/go-logger.lock.yml @@ -14,21 +14,17 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_pull_request --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3596,7 +3592,6 @@ jobs: - activation - create_pull_request - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3604,6 +3599,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3627,6 +3624,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Go Logger Enhancement" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4796,113 +4888,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Go Logger Enhancement" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/go-pattern-detector.lock.yml b/.github/workflows/go-pattern-detector.lock.yml index 88b41aa1ec4..8c46c479cf5 100644 --- a/.github/workflows/go-pattern-detector.lock.yml +++ b/.github/workflows/go-pattern-detector.lock.yml @@ -18,7 +18,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # activation --> agent @@ -26,14 +25,11 @@ # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3239,7 +3235,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3247,6 +3242,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3270,6 +3267,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Go Pattern Detector" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4169,116 +4261,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Go Pattern Detector" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: runs-on: ubuntu-slim outputs: diff --git a/.github/workflows/grumpy-reviewer.lock.yml b/.github/workflows/grumpy-reviewer.lock.yml index 82dcd2dc129..0d45da75a8e 100644 --- a/.github/workflows/grumpy-reviewer.lock.yml +++ b/.github/workflows/grumpy-reviewer.lock.yml @@ -15,7 +15,6 @@ # create_pr_review_comment["create_pr_review_comment"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -26,14 +25,11 @@ # add_comment --> conclusion # create_pr_review_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pr_review_comment # detection --> create_pr_review_comment # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4602,7 +4598,6 @@ jobs: - add_comment - create_pr_review_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4610,6 +4605,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4633,6 +4630,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Grumpy Code Reviewer 🔥" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5501,116 +5593,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Grumpy Code Reviewer 🔥" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > (github.event_name == 'issue_comment') && ((contains(github.event.comment.body, '/grumpy')) && (github.event.issue.pull_request != null)) || diff --git a/.github/workflows/instructions-janitor.lock.yml b/.github/workflows/instructions-janitor.lock.yml index 8acab3c8e65..4efe7b545cf 100644 --- a/.github/workflows/instructions-janitor.lock.yml +++ b/.github/workflows/instructions-janitor.lock.yml @@ -14,21 +14,17 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_pull_request --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3475,7 +3471,6 @@ jobs: - activation - create_pull_request - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3483,6 +3478,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3506,6 +3503,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Instructions Janitor" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4675,113 +4767,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Instructions Janitor" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/issue-classifier.lock.yml b/.github/workflows/issue-classifier.lock.yml index c6d538d1026..dc6ebc113bc 100644 --- a/.github/workflows/issue-classifier.lock.yml +++ b/.github/workflows/issue-classifier.lock.yml @@ -18,7 +18,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_labels @@ -28,12 +27,9 @@ # activation --> conclusion # add_labels --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3093,7 +3089,6 @@ jobs: - activation - add_labels - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3101,6 +3096,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3124,6 +3121,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Issue Classifier" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -3623,116 +3715,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Issue Classifier" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: runs-on: ubuntu-slim outputs: diff --git a/.github/workflows/lockfile-stats.lock.yml b/.github/workflows/lockfile-stats.lock.yml index 6e3ec2a4d37..7fde996d0fe 100644 --- a/.github/workflows/lockfile-stats.lock.yml +++ b/.github/workflows/lockfile-stats.lock.yml @@ -18,20 +18,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3554,7 +3550,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3562,6 +3557,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3585,6 +3582,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Lockfile Statistics Analysis Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4403,113 +4495,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Lockfile Statistics Analysis Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/mcp-inspector.lock.yml b/.github/workflows/mcp-inspector.lock.yml index e99c6d68560..219780c6959 100644 --- a/.github/workflows/mcp-inspector.lock.yml +++ b/.github/workflows/mcp-inspector.lock.yml @@ -34,7 +34,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # notion_add_comment["notion_add_comment"] # post_to_slack_channel["post_to_slack_channel"] # activation --> agent @@ -42,14 +41,11 @@ # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> notion_add_comment # detection --> notion_add_comment # agent --> post_to_slack_channel @@ -4471,7 +4467,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4479,6 +4474,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4502,6 +4499,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "MCP Inspector Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5312,116 +5404,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "MCP Inspector Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - notion_add_comment: needs: - agent diff --git a/.github/workflows/mergefest.lock.yml b/.github/workflows/mergefest.lock.yml index 458c4de0a4e..1e051747210 100644 --- a/.github/workflows/mergefest.lock.yml +++ b/.github/workflows/mergefest.lock.yml @@ -13,7 +13,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # push_to_pull_request_branch["push_to_pull_request_branch"] # pre_activation --> activation @@ -22,12 +21,9 @@ # activation --> conclusion # push_to_pull_request_branch --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> push_to_pull_request_branch # activation --> push_to_pull_request_branch # detection --> push_to_pull_request_branch @@ -4211,7 +4207,6 @@ jobs: - activation - push_to_pull_request_branch - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4219,6 +4214,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4242,6 +4239,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Mergefest" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4778,116 +4870,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Mergefest" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > (github.event_name == 'issue_comment') && ((contains(github.event.comment.body, '/mergefest')) && (github.event.issue.pull_request != null)) diff --git a/.github/workflows/pdf-summary.lock.yml b/.github/workflows/pdf-summary.lock.yml index 436a9e0e765..92441076d2c 100644 --- a/.github/workflows/pdf-summary.lock.yml +++ b/.github/workflows/pdf-summary.lock.yml @@ -18,7 +18,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -28,12 +27,9 @@ # activation --> conclusion # add_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4652,7 +4648,6 @@ jobs: - activation - add_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4660,6 +4655,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4683,6 +4680,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Resource Summarizer Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5219,116 +5311,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Resource Summarizer Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event_name == 'issue_comment' || github.event_name == 'issues') && ((github.event_name == 'issues') && diff --git a/.github/workflows/plan.lock.yml b/.github/workflows/plan.lock.yml index 25f652386d5..f3615c97d5a 100644 --- a/.github/workflows/plan.lock.yml +++ b/.github/workflows/plan.lock.yml @@ -14,7 +14,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # activation --> agent @@ -22,14 +21,11 @@ # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4127,7 +4123,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4135,6 +4130,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4158,6 +4155,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Plan Command" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5049,116 +5141,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Plan Command" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > (github.event_name == 'issue_comment') && ((contains(github.event.comment.body, '/plan')) && (github.event.issue.pull_request == null)) || diff --git a/.github/workflows/poem-bot.lock.yml b/.github/workflows/poem-bot.lock.yml index b7d5fb2ea6e..b16a44c7144 100644 --- a/.github/workflows/poem-bot.lock.yml +++ b/.github/workflows/poem-bot.lock.yml @@ -18,7 +18,6 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # push_to_pull_request_branch["push_to_pull_request_branch"] # update_issue["update_issue"] @@ -42,7 +41,6 @@ # push_to_pull_request_branch --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> create_pr_review_comment @@ -53,8 +51,6 @@ # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> push_to_pull_request_branch # activation --> push_to_pull_request_branch # detection --> push_to_pull_request_branch @@ -5068,7 +5064,6 @@ jobs: - push_to_pull_request_branch - missing_tool - upload_assets - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -5076,6 +5071,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -5099,6 +5096,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Poem Bot - A Creative Agentic Workflow" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -6964,116 +7056,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Poem Bot - A Creative Agentic Workflow" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event_name == 'issues') && ((github.event_name == 'issues') && (contains(github.event.issue.body, '/poem-bot')))) || diff --git a/.github/workflows/pr-nitpick-reviewer.lock.yml b/.github/workflows/pr-nitpick-reviewer.lock.yml index f6147dfa2f2..53a693994ca 100644 --- a/.github/workflows/pr-nitpick-reviewer.lock.yml +++ b/.github/workflows/pr-nitpick-reviewer.lock.yml @@ -20,7 +20,6 @@ # create_pr_review_comment["create_pr_review_comment"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -33,7 +32,6 @@ # add_comment --> conclusion # create_pr_review_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> create_pr_review_comment @@ -41,8 +39,6 @@ # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4662,7 +4658,6 @@ jobs: - add_comment - create_pr_review_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4670,6 +4665,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4693,6 +4690,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "PR Nitpick Reviewer 🔍" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5834,116 +5926,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "PR Nitpick Reviewer 🔍" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > (github.event_name == 'issues') && (contains(github.event.issue.body, '/nit')) || (github.event_name == 'issue_comment') && diff --git a/.github/workflows/prompt-clustering-analysis.lock.yml b/.github/workflows/prompt-clustering-analysis.lock.yml index 59761be6551..b132c00b9ea 100644 --- a/.github/workflows/prompt-clustering-analysis.lock.yml +++ b/.github/workflows/prompt-clustering-analysis.lock.yml @@ -21,20 +21,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3894,7 +3890,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3902,6 +3897,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3925,6 +3922,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Copilot Agent Prompt Clustering Analysis" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4744,113 +4836,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Copilot Agent Prompt Clustering Analysis" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/python-data-charts.lock.yml b/.github/workflows/python-data-charts.lock.yml index 9b8be469ed8..45f246104a0 100644 --- a/.github/workflows/python-data-charts.lock.yml +++ b/.github/workflows/python-data-charts.lock.yml @@ -20,7 +20,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -28,14 +27,11 @@ # create_discussion --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4838,7 +4834,6 @@ jobs: - create_discussion - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4846,6 +4841,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4869,6 +4866,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Python Data Visualization Generator" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5679,116 +5771,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Python Data Visualization Generator" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/q.lock.yml b/.github/workflows/q.lock.yml index fd1edefd63a..16f1566be09 100644 --- a/.github/workflows/q.lock.yml +++ b/.github/workflows/q.lock.yml @@ -21,7 +21,6 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -33,15 +32,12 @@ # create_pull_request --> conclusion # add_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -5125,7 +5121,6 @@ jobs: - create_pull_request - add_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -5133,6 +5128,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -5156,6 +5153,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Q" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -6331,116 +6423,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Q" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > (github.event_name == 'issues') && (contains(github.event.issue.body, '/q')) || (github.event_name == 'issue_comment') && diff --git a/.github/workflows/repo-tree-map.lock.yml b/.github/workflows/repo-tree-map.lock.yml index 67a6d50f4f1..1948ff6d6c2 100644 --- a/.github/workflows/repo-tree-map.lock.yml +++ b/.github/workflows/repo-tree-map.lock.yml @@ -18,20 +18,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3561,7 +3557,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3569,6 +3564,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3592,6 +3589,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Repository Tree Map Generator" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4402,113 +4494,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Repository Tree Map Generator" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/repository-quality-improver.lock.yml b/.github/workflows/repository-quality-improver.lock.yml index 28a7c521e4c..fb0dbedc3d0 100644 --- a/.github/workflows/repository-quality-improver.lock.yml +++ b/.github/workflows/repository-quality-improver.lock.yml @@ -19,20 +19,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4079,7 +4075,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4087,6 +4082,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4110,6 +4107,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Repository Quality Improvement Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4920,113 +5012,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Repository Quality Improvement Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/research.lock.yml b/.github/workflows/research.lock.yml index afe2f1bf5f8..22732f974dd 100644 --- a/.github/workflows/research.lock.yml +++ b/.github/workflows/research.lock.yml @@ -19,20 +19,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3862,7 +3858,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3870,6 +3865,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3893,6 +3890,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Basic Research Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4703,113 +4795,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Basic Research Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/safe-output-health.lock.yml b/.github/workflows/safe-output-health.lock.yml index 7f5e7a17de8..5c4267a3526 100644 --- a/.github/workflows/safe-output-health.lock.yml +++ b/.github/workflows/safe-output-health.lock.yml @@ -20,20 +20,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3687,7 +3683,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3695,6 +3690,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3718,6 +3715,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Safe Output Health Monitor" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4536,113 +4628,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Safe Output Health Monitor" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/schema-consistency-checker.lock.yml b/.github/workflows/schema-consistency-checker.lock.yml index 23eaaf08066..650d1d43723 100644 --- a/.github/workflows/schema-consistency-checker.lock.yml +++ b/.github/workflows/schema-consistency-checker.lock.yml @@ -18,20 +18,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3560,7 +3556,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3568,6 +3563,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3591,6 +3588,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Schema Consistency Checker" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4410,113 +4502,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Schema Consistency Checker" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/scout.lock.yml b/.github/workflows/scout.lock.yml index ec1cc4869e0..d79ce6d469e 100644 --- a/.github/workflows/scout.lock.yml +++ b/.github/workflows/scout.lock.yml @@ -25,7 +25,6 @@ # conclusion["conclusion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -35,12 +34,9 @@ # activation --> conclusion # add_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4674,7 +4670,6 @@ jobs: - activation - add_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4682,6 +4677,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4705,6 +4702,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Scout" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5249,116 +5341,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Scout" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event_name == 'issues' || github.event_name == 'issue_comment' || github.event_name == 'pull_request' || diff --git a/.github/workflows/security-fix-pr.lock.yml b/.github/workflows/security-fix-pr.lock.yml index 9021630de3f..f8198a5af7d 100644 --- a/.github/workflows/security-fix-pr.lock.yml +++ b/.github/workflows/security-fix-pr.lock.yml @@ -14,21 +14,17 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_pull_request --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3423,7 +3419,6 @@ jobs: - activation - create_pull_request - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3431,6 +3426,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3454,6 +3451,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Security Fix PR" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4637,113 +4729,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Security Fix PR" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/semantic-function-refactor.lock.yml b/.github/workflows/semantic-function-refactor.lock.yml index 651a801800c..df616cd809a 100644 --- a/.github/workflows/semantic-function-refactor.lock.yml +++ b/.github/workflows/semantic-function-refactor.lock.yml @@ -19,20 +19,16 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3648,7 +3644,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3656,6 +3651,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3679,6 +3676,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Semantic Function Refactoring" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4580,113 +4672,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Semantic Function Refactoring" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/smoke-claude.lock.yml b/.github/workflows/smoke-claude.lock.yml index d3a500635e1..691755793cc 100644 --- a/.github/workflows/smoke-claude.lock.yml +++ b/.github/workflows/smoke-claude.lock.yml @@ -18,7 +18,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # activation --> agent @@ -26,14 +25,11 @@ # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3207,7 +3203,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3215,6 +3210,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3238,6 +3235,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Smoke Claude" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4137,116 +4229,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Smoke Claude" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event_name != 'pull_request') || (github.event.pull_request.head.repo.id == github.repository_id)) && diff --git a/.github/workflows/smoke-codex.lock.yml b/.github/workflows/smoke-codex.lock.yml index fe81b7876f4..2b26f9d5315 100644 --- a/.github/workflows/smoke-codex.lock.yml +++ b/.github/workflows/smoke-codex.lock.yml @@ -14,7 +14,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # activation --> agent @@ -22,14 +21,11 @@ # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -2751,7 +2747,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -2759,6 +2754,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -2782,6 +2779,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Smoke Codex" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -3660,116 +3752,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Smoke Codex" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event_name != 'pull_request') || (github.event.pull_request.head.repo.id == github.repository_id)) && diff --git a/.github/workflows/smoke-copilot.lock.yml b/.github/workflows/smoke-copilot.lock.yml index b7eb5d8a2a1..cfda05d2c82 100644 --- a/.github/workflows/smoke-copilot.lock.yml +++ b/.github/workflows/smoke-copilot.lock.yml @@ -14,7 +14,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # activation --> agent @@ -22,14 +21,11 @@ # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3779,7 +3775,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3787,6 +3782,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3810,6 +3807,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Smoke Copilot" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4700,116 +4792,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Smoke Copilot" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event_name != 'pull_request') || (github.event.pull_request.head.repo.id == github.repository_id)) && diff --git a/.github/workflows/smoke-detector.lock.yml b/.github/workflows/smoke-detector.lock.yml index aebd2210262..fa8fd4548d8 100644 --- a/.github/workflows/smoke-detector.lock.yml +++ b/.github/workflows/smoke-detector.lock.yml @@ -20,7 +20,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # pre_activation --> activation # agent --> add_comment @@ -32,14 +31,11 @@ # create_issue --> conclusion # add_comment --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -4274,7 +4270,6 @@ jobs: - create_issue - add_comment - missing_tool - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4282,6 +4277,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4305,6 +4302,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Smoke Detector - Smoke Test Failure Investigator" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5206,116 +5298,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Smoke Detector - Smoke Test Failure Investigator" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: runs-on: ubuntu-slim outputs: diff --git a/.github/workflows/static-analysis-report.lock.yml b/.github/workflows/static-analysis-report.lock.yml index 7bb7837ec00..5530bb7a29c 100644 --- a/.github/workflows/static-analysis-report.lock.yml +++ b/.github/workflows/static-analysis-report.lock.yml @@ -19,20 +19,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3575,7 +3571,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3583,6 +3578,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3606,6 +3603,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Static Analysis Report" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4424,113 +4516,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Static Analysis Report" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/super-linter.lock.yml b/.github/workflows/super-linter.lock.yml index 4dae052ac26..ea4ea8010ef 100644 --- a/.github/workflows/super-linter.lock.yml +++ b/.github/workflows/super-linter.lock.yml @@ -18,7 +18,6 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # super_linter["super_linter"] # activation --> agent # super_linter --> agent @@ -26,14 +25,11 @@ # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # activation --> super_linter # ``` # @@ -3634,7 +3630,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3642,6 +3637,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3665,6 +3662,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Super Linter Report" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4558,116 +4650,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Super Linter Report" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - super_linter: needs: activation runs-on: ubuntu-latest diff --git a/.github/workflows/technical-doc-writer.lock.yml b/.github/workflows/technical-doc-writer.lock.yml index be8589cec09..e5aded62b96 100644 --- a/.github/workflows/technical-doc-writer.lock.yml +++ b/.github/workflows/technical-doc-writer.lock.yml @@ -20,7 +20,6 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # agent --> add_comment # create_pull_request --> add_comment @@ -32,15 +31,12 @@ # add_comment --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4814,7 +4810,6 @@ jobs: - add_comment - missing_tool - upload_assets - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4822,6 +4817,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4845,6 +4842,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Technical Doc Writer" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -6020,116 +6112,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Technical Doc Writer" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/.github/workflows/test-ollama-threat-detection.lock.yml b/.github/workflows/test-ollama-threat-detection.lock.yml index 94cf343881c..af91f80adf9 100644 --- a/.github/workflows/test-ollama-threat-detection.lock.yml +++ b/.github/workflows/test-ollama-threat-detection.lock.yml @@ -14,20 +14,16 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3357,7 +3353,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3365,6 +3360,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3388,6 +3385,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Test Ollama Threat Scanning" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4590,113 +4682,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Test Ollama Threat Scanning" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/tidy.lock.yml b/.github/workflows/tidy.lock.yml index 0950667f473..235c7463134 100644 --- a/.github/workflows/tidy.lock.yml +++ b/.github/workflows/tidy.lock.yml @@ -14,7 +14,6 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # push_to_pull_request_branch["push_to_pull_request_branch"] # pre_activation --> activation @@ -24,15 +23,12 @@ # create_pull_request --> conclusion # push_to_pull_request_branch --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> push_to_pull_request_branch # activation --> push_to_pull_request_branch # detection --> push_to_pull_request_branch @@ -4015,7 +4011,6 @@ jobs: - create_pull_request - push_to_pull_request_branch - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4023,6 +4018,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4046,6 +4043,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Tidy" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5221,116 +5313,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Tidy" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event_name == 'issue_comment') && ((github.event_name == 'issue_comment') && ((contains(github.event.comment.body, '/tidy')) && diff --git a/.github/workflows/typist.lock.yml b/.github/workflows/typist.lock.yml index b55428393ba..1b5a0df62b2 100644 --- a/.github/workflows/typist.lock.yml +++ b/.github/workflows/typist.lock.yml @@ -19,20 +19,16 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_discussion --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3718,7 +3714,6 @@ jobs: - activation - create_discussion - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3726,6 +3721,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3749,6 +3746,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Typist - Go Type Analysis" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4567,113 +4659,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Typist - Go Type Analysis" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/unbloat-docs.lock.yml b/.github/workflows/unbloat-docs.lock.yml index 05741dc2f61..b61dfbdc1c0 100644 --- a/.github/workflows/unbloat-docs.lock.yml +++ b/.github/workflows/unbloat-docs.lock.yml @@ -19,7 +19,6 @@ # create_pull_request["create_pull_request"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # pre_activation["pre_activation"] # upload_assets["upload_assets"] # pre_activation --> activation @@ -33,15 +32,12 @@ # add_comment --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_pull_request # activation --> create_pull_request # detection --> create_pull_request # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4509,7 +4505,6 @@ jobs: - add_comment - missing_tool - upload_assets - - noop if: ((always()) && (needs.agent.result != 'skipped')) && (!(needs.add_comment.outputs.comment_id)) runs-on: ubuntu-slim permissions: @@ -4517,6 +4512,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4540,6 +4537,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Documentation Unbloat" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5710,116 +5802,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Documentation Unbloat" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - pre_activation: if: > ((github.event_name == 'issue_comment') && ((github.event_name == 'issue_comment') && ((contains(github.event.comment.body, '/unbloat')) && diff --git a/.github/workflows/video-analyzer.lock.yml b/.github/workflows/video-analyzer.lock.yml index 142fabaa6c3..426042d2f2b 100644 --- a/.github/workflows/video-analyzer.lock.yml +++ b/.github/workflows/video-analyzer.lock.yml @@ -18,20 +18,16 @@ # create_issue["create_issue"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # activation --> agent # agent --> conclusion # activation --> conclusion # create_issue --> conclusion # missing_tool --> conclusion -# noop --> conclusion # agent --> create_issue # detection --> create_issue # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # ``` # # Pinned GitHub Actions: @@ -3648,7 +3644,6 @@ jobs: - activation - create_issue - missing_tool - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -3656,6 +3651,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -3679,6 +3676,101 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Video Analysis Agent" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -4572,113 +4664,3 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Video Analysis Agent" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - diff --git a/.github/workflows/weekly-issue-summary.lock.yml b/.github/workflows/weekly-issue-summary.lock.yml index 6aeb3be2a13..b8cd59fad72 100644 --- a/.github/workflows/weekly-issue-summary.lock.yml +++ b/.github/workflows/weekly-issue-summary.lock.yml @@ -20,7 +20,6 @@ # create_discussion["create_discussion"] # detection["detection"] # missing_tool["missing_tool"] -# noop["noop"] # upload_assets["upload_assets"] # activation --> agent # agent --> conclusion @@ -28,14 +27,11 @@ # create_discussion --> conclusion # missing_tool --> conclusion # upload_assets --> conclusion -# noop --> conclusion # agent --> create_discussion # detection --> create_discussion # agent --> detection # agent --> missing_tool # detection --> missing_tool -# agent --> noop -# detection --> noop # agent --> upload_assets # detection --> upload_assets # ``` @@ -4426,7 +4422,6 @@ jobs: - create_discussion - missing_tool - upload_assets - - noop if: (always()) && (needs.agent.result != 'skipped') runs-on: ubuntu-slim permissions: @@ -4434,6 +4429,8 @@ jobs: discussions: write issues: write pull-requests: write + outputs: + noop_message: ${{ steps.noop.outputs.noop_message }} steps: - name: Debug job inputs env: @@ -4457,6 +4454,102 @@ jobs: mkdir -p /tmp/gh-aw/safeoutputs/ find "/tmp/gh-aw/safeoutputs/" -type f -print echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" + - name: Process No-Op Messages + id: noop + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 + env: + GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} + GH_AW_NOOP_MAX: 1 + GH_AW_WORKFLOW_NAME: "Weekly Issue Summary" + GH_AW_CAMPAIGN: "weekly-issue-summary" + with: + github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} + script: | + const fs = require("fs"); + function loadAgentOutput() { + const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; + if (!agentOutputFile) { + core.info("No GH_AW_AGENT_OUTPUT environment variable found"); + return { success: false }; + } + let outputContent; + try { + outputContent = fs.readFileSync(agentOutputFile, "utf8"); + } catch (error) { + const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (outputContent.trim() === "") { + core.info("Agent output content is empty"); + return { success: false }; + } + core.info(`Agent output content length: ${outputContent.length}`); + let validatedOutput; + try { + validatedOutput = JSON.parse(outputContent); + } catch (error) { + const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; + core.error(errorMessage); + return { success: false, error: errorMessage }; + } + if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { + core.info("No valid items found in agent output"); + return { success: false }; + } + return { success: true, items: validatedOutput.items }; + } + async function main() { + const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; + const result = loadAgentOutput(); + if (!result.success) { + return; + } + const noopItems = result.items.filter( item => item.type === "noop"); + if (noopItems.length === 0) { + core.info("No noop items found in agent output"); + return; + } + core.info(`Found ${noopItems.length} noop item(s)`); + if (isStaged) { + let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; + summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + summaryContent += `### Message ${i + 1}\n`; + summaryContent += `${item.message}\n\n`; + summaryContent += "---\n\n"; + } + await core.summary.addRaw(summaryContent).write(); + core.info("📝 No-op message preview written to step summary"); + return; + } + let summaryContent = "\n\n## No-Op Messages\n\n"; + summaryContent += "The following messages were logged for transparency:\n\n"; + for (let i = 0; i < noopItems.length; i++) { + const item = noopItems[i]; + core.info(`No-op message ${i + 1}: ${item.message}`); + summaryContent += `- ${item.message}\n`; + } + await core.summary.addRaw(summaryContent).write(); + if (noopItems.length > 0) { + core.setOutput("noop_message", noopItems[0].message); + core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); + } + core.info(`Successfully processed ${noopItems.length} noop message(s)`); + } + await main(); + - name: Download agent output artifact + continue-on-error: true + uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 + with: + name: agent_output.json + path: /tmp/gh-aw/safeoutputs/ + - name: Setup agent output environment variable + run: | + mkdir -p /tmp/gh-aw/safeoutputs/ + find "/tmp/gh-aw/safeoutputs/" -type f -print + echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 @@ -5271,117 +5364,6 @@ jobs: core.setFailed(`Error processing missing-tool reports: ${error}`); }); - noop: - needs: - - agent - - detection - if: > - (((!cancelled()) && (needs.agent.result != 'skipped')) && (contains(needs.agent.outputs.output_types, 'noop'))) && - (needs.detection.outputs.success == 'true') - runs-on: ubuntu-slim - permissions: - contents: read - timeout-minutes: 5 - outputs: - noop_message: ${{ steps.noop.outputs.noop_message }} - steps: - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - - name: Process No-Op Messages - id: noop - uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 - env: - GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }} - GH_AW_NOOP_MAX: 1 - GH_AW_WORKFLOW_NAME: "Weekly Issue Summary" - GH_AW_CAMPAIGN: "weekly-issue-summary" - with: - github-token: ${{ secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }} - script: | - const fs = require("fs"); - function loadAgentOutput() { - const agentOutputFile = process.env.GH_AW_AGENT_OUTPUT; - if (!agentOutputFile) { - core.info("No GH_AW_AGENT_OUTPUT environment variable found"); - return { success: false }; - } - let outputContent; - try { - outputContent = fs.readFileSync(agentOutputFile, "utf8"); - } catch (error) { - const errorMessage = `Error reading agent output file: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (outputContent.trim() === "") { - core.info("Agent output content is empty"); - return { success: false }; - } - core.info(`Agent output content length: ${outputContent.length}`); - let validatedOutput; - try { - validatedOutput = JSON.parse(outputContent); - } catch (error) { - const errorMessage = `Error parsing agent output JSON: ${error instanceof Error ? error.message : String(error)}`; - core.error(errorMessage); - return { success: false, error: errorMessage }; - } - if (!validatedOutput.items || !Array.isArray(validatedOutput.items)) { - core.info("No valid items found in agent output"); - return { success: false }; - } - return { success: true, items: validatedOutput.items }; - } - async function main() { - const isStaged = process.env.GH_AW_SAFE_OUTPUTS_STAGED === "true"; - const result = loadAgentOutput(); - if (!result.success) { - return; - } - const noopItems = result.items.filter( item => item.type === "noop"); - if (noopItems.length === 0) { - core.info("No noop items found in agent output"); - return; - } - core.info(`Found ${noopItems.length} noop item(s)`); - if (isStaged) { - let summaryContent = "## 🎭 Staged Mode: No-Op Messages Preview\n\n"; - summaryContent += "The following messages would be logged if staged mode was disabled:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - summaryContent += `### Message ${i + 1}\n`; - summaryContent += `${item.message}\n\n`; - summaryContent += "---\n\n"; - } - await core.summary.addRaw(summaryContent).write(); - core.info("📝 No-op message preview written to step summary"); - return; - } - let summaryContent = "\n\n## No-Op Messages\n\n"; - summaryContent += "The following messages were logged for transparency:\n\n"; - for (let i = 0; i < noopItems.length; i++) { - const item = noopItems[i]; - core.info(`No-op message ${i + 1}: ${item.message}`); - summaryContent += `- ${item.message}\n`; - } - await core.summary.addRaw(summaryContent).write(); - if (noopItems.length > 0) { - core.setOutput("noop_message", noopItems[0].message); - core.exportVariable("GH_AW_NOOP_MESSAGE", noopItems[0].message); - } - core.info(`Successfully processed ${noopItems.length} noop message(s)`); - } - await main(); - upload_assets: needs: - agent diff --git a/pkg/workflow/compiler_jobs.go b/pkg/workflow/compiler_jobs.go index ab8bfd43349..edbeb995b57 100644 --- a/pkg/workflow/compiler_jobs.go +++ b/pkg/workflow/compiler_jobs.go @@ -410,23 +410,7 @@ func (c *Compiler) buildSafeOutputsJobs(data *WorkflowData, jobName, markdownPat safeOutputJobNames = append(safeOutputJobNames, updateProjectJob.Name) } - // Build noop job (always enabled when SafeOutputs exists) - if data.SafeOutputs.NoOp != nil { - noopJob, err := c.buildCreateOutputNoOpJob(data, jobName) - if err != nil { - return fmt.Errorf("failed to build noop job: %w", err) - } - // Safe-output jobs should depend on agent job (always) AND detection job (if enabled) - if threatDetectionEnabled { - noopJob.Needs = append(noopJob.Needs, constants.DetectionJobName) - // Add detection success check to the job condition - noopJob.If = AddDetectionSuccessCheck(noopJob.If) - } - if err := c.jobManager.AddJob(noopJob); err != nil { - return fmt.Errorf("failed to add noop job: %w", err) - } - safeOutputJobNames = append(safeOutputJobNames, noopJob.Name) - } + // Note: noop processing is now handled inside the conclusion job, not as a separate job // Build conclusion job if add-comment is configured OR if command trigger is configured with reactions // This job runs last, after all safe output jobs, to update the activation comment on failure diff --git a/pkg/workflow/notify_comment.go b/pkg/workflow/notify_comment.go index 53bd1ad4005..996ee624359 100644 --- a/pkg/workflow/notify_comment.go +++ b/pkg/workflow/notify_comment.go @@ -57,6 +57,29 @@ func (c *Compiler) buildConclusionJob(data *WorkflowData, mainJobName string, sa steps = append(steps, " echo \"Agent Output Types: $AGENT_OUTPUT_TYPES\"\n") steps = append(steps, " echo \"Agent Conclusion: $AGENT_CONCLUSION\"\n") + // Add noop processing step if noop is configured + if data.SafeOutputs.NoOp != nil { + // Build custom environment variables specific to noop + var noopEnvVars []string + if data.SafeOutputs.NoOp.Max > 0 { + noopEnvVars = append(noopEnvVars, fmt.Sprintf(" GH_AW_NOOP_MAX: %d\n", data.SafeOutputs.NoOp.Max)) + } + + // Add workflow metadata for consistency + noopEnvVars = append(noopEnvVars, buildWorkflowMetadataEnvVarsWithCampaign(data.Name, data.Source, data.Campaign)...) + + // Build the noop processing step + noopSteps := c.buildGitHubScriptStep(data, GitHubScriptStepConfig{ + StepName: "Process No-Op Messages", + StepID: "noop", + MainJobName: mainJobName, + CustomEnvVars: noopEnvVars, + Script: getNoOpScript(), + Token: data.SafeOutputs.NoOp.GitHubToken, + }) + steps = append(steps, noopSteps...) + } + // Build environment variables for the script var customEnvVars []string customEnvVars = append(customEnvVars, fmt.Sprintf(" GH_AW_COMMENT_ID: ${{ needs.%s.outputs.comment_id }}\n", constants.ActivationJobName)) @@ -134,6 +157,12 @@ func (c *Compiler) buildConclusionJob(data *WorkflowData, mainJobName string, sa notifyCommentLog.Printf("Job built successfully: dependencies_count=%d", len(needs)) + // Create outputs for the job (include noop output if configured) + outputs := map[string]string{} + if data.SafeOutputs.NoOp != nil { + outputs["noop_message"] = "${{ steps.noop.outputs.noop_message }}" + } + job := &Job{ Name: "conclusion", If: condition.Render(), @@ -141,6 +170,7 @@ func (c *Compiler) buildConclusionJob(data *WorkflowData, mainJobName string, sa Permissions: NewPermissionsContentsReadIssuesWritePRWriteDiscussionsWrite().RenderToYAML(), Steps: steps, Needs: needs, + Outputs: outputs, } return job, nil From f198b1fb5a03daf9464ec694649d29bda42b3ade Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:49:42 +0000 Subject: [PATCH 3/8] Add test to verify noop step is in conclusion job - Created noop_in_conclusion_test.go to validate the new structure - Test verifies no separate noop job exists - Test verifies noop step is in conclusion job - Test verifies conclusion job has noop_message output - Test verifies conclusion job does not depend on noop job - Test passes successfully Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- pkg/workflow/noop_in_conclusion_test.go | 84 +++++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 pkg/workflow/noop_in_conclusion_test.go diff --git a/pkg/workflow/noop_in_conclusion_test.go b/pkg/workflow/noop_in_conclusion_test.go new file mode 100644 index 00000000000..d1d54fa5680 --- /dev/null +++ b/pkg/workflow/noop_in_conclusion_test.go @@ -0,0 +1,84 @@ +package workflow + +import ( +"os" +"path/filepath" +"strings" +"testing" + +"github.com/githubnext/gh-aw/pkg/testutil" +) + +func TestNoopStepInConclusionJob(t *testing.T) { +// Create temporary directory for test files +tmpDir := testutil.TempDir(t, "noop-in-conclusion-test") + +// Create a test markdown file with noop safe output +testContent := `--- +on: + issues: + types: [opened] +permissions: + contents: read +engine: copilot +safe-outputs: + noop: + max: 5 +--- + +# Test Noop in Conclusion + +Test that noop step is generated inside the conclusion job. +` + +testFile := filepath.Join(tmpDir, "test-noop.md") +if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil { +t.Fatal(err) +} + +compiler := NewCompiler(false, "", "test") + +// Compile the workflow +if err := compiler.CompileWorkflow(testFile); err != nil { +t.Fatalf("Failed to compile workflow: %v", err) +} + +// Read the compiled workflow +lockFile := filepath.Join(tmpDir, "test-noop.lock.yml") +compiledBytes, err := os.ReadFile(lockFile) +if err != nil { +t.Fatalf("Failed to read compiled workflow: %v", err) +} +compiled := string(compiledBytes) + +// Verify that there is NO separate noop job +if strings.Contains(compiled, "\n noop:") { +t.Error("There should NOT be a separate noop job") +} + +// Verify that conclusion job exists +if !strings.Contains(compiled, "\n conclusion:") { +t.Error("Conclusion job should exist") +} + +// Verify that "Process No-Op Messages" step is in the conclusion job +conclusionSection := extractJobSection(compiled, "conclusion") +if !strings.Contains(conclusionSection, "Process No-Op Messages") { +t.Error("Conclusion job should contain 'Process No-Op Messages' step") +} + +// Verify that conclusion job has noop_message output +if !strings.Contains(conclusionSection, "noop_message:") { +t.Error("Conclusion job should have 'noop_message' output") +} + +// Verify that conclusion job does NOT depend on noop job +if strings.Contains(conclusionSection, "- noop") { +t.Error("Conclusion job should NOT depend on 'noop' job") +} + +// Verify that conclusion job depends on agent job +if !strings.Contains(conclusionSection, "- agent") { +t.Error("Conclusion job should depend on 'agent' job") +} +} From 15a7c63900ff0f21680d381ee17e18f3ef4d1ded Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:50:24 +0000 Subject: [PATCH 4/8] Format noop_in_conclusion_test.go --- pkg/workflow/noop_in_conclusion_test.go | 118 ++++++++++++------------ 1 file changed, 59 insertions(+), 59 deletions(-) diff --git a/pkg/workflow/noop_in_conclusion_test.go b/pkg/workflow/noop_in_conclusion_test.go index d1d54fa5680..eded9915ac7 100644 --- a/pkg/workflow/noop_in_conclusion_test.go +++ b/pkg/workflow/noop_in_conclusion_test.go @@ -1,20 +1,20 @@ package workflow import ( -"os" -"path/filepath" -"strings" -"testing" + "os" + "path/filepath" + "strings" + "testing" -"github.com/githubnext/gh-aw/pkg/testutil" + "github.com/githubnext/gh-aw/pkg/testutil" ) func TestNoopStepInConclusionJob(t *testing.T) { -// Create temporary directory for test files -tmpDir := testutil.TempDir(t, "noop-in-conclusion-test") + // Create temporary directory for test files + tmpDir := testutil.TempDir(t, "noop-in-conclusion-test") -// Create a test markdown file with noop safe output -testContent := `--- + // Create a test markdown file with noop safe output + testContent := `--- on: issues: types: [opened] @@ -31,54 +31,54 @@ safe-outputs: Test that noop step is generated inside the conclusion job. ` -testFile := filepath.Join(tmpDir, "test-noop.md") -if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil { -t.Fatal(err) -} - -compiler := NewCompiler(false, "", "test") - -// Compile the workflow -if err := compiler.CompileWorkflow(testFile); err != nil { -t.Fatalf("Failed to compile workflow: %v", err) -} - -// Read the compiled workflow -lockFile := filepath.Join(tmpDir, "test-noop.lock.yml") -compiledBytes, err := os.ReadFile(lockFile) -if err != nil { -t.Fatalf("Failed to read compiled workflow: %v", err) -} -compiled := string(compiledBytes) - -// Verify that there is NO separate noop job -if strings.Contains(compiled, "\n noop:") { -t.Error("There should NOT be a separate noop job") -} - -// Verify that conclusion job exists -if !strings.Contains(compiled, "\n conclusion:") { -t.Error("Conclusion job should exist") -} - -// Verify that "Process No-Op Messages" step is in the conclusion job -conclusionSection := extractJobSection(compiled, "conclusion") -if !strings.Contains(conclusionSection, "Process No-Op Messages") { -t.Error("Conclusion job should contain 'Process No-Op Messages' step") -} - -// Verify that conclusion job has noop_message output -if !strings.Contains(conclusionSection, "noop_message:") { -t.Error("Conclusion job should have 'noop_message' output") -} - -// Verify that conclusion job does NOT depend on noop job -if strings.Contains(conclusionSection, "- noop") { -t.Error("Conclusion job should NOT depend on 'noop' job") -} - -// Verify that conclusion job depends on agent job -if !strings.Contains(conclusionSection, "- agent") { -t.Error("Conclusion job should depend on 'agent' job") -} + testFile := filepath.Join(tmpDir, "test-noop.md") + if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil { + t.Fatal(err) + } + + compiler := NewCompiler(false, "", "test") + + // Compile the workflow + if err := compiler.CompileWorkflow(testFile); err != nil { + t.Fatalf("Failed to compile workflow: %v", err) + } + + // Read the compiled workflow + lockFile := filepath.Join(tmpDir, "test-noop.lock.yml") + compiledBytes, err := os.ReadFile(lockFile) + if err != nil { + t.Fatalf("Failed to read compiled workflow: %v", err) + } + compiled := string(compiledBytes) + + // Verify that there is NO separate noop job + if strings.Contains(compiled, "\n noop:") { + t.Error("There should NOT be a separate noop job") + } + + // Verify that conclusion job exists + if !strings.Contains(compiled, "\n conclusion:") { + t.Error("Conclusion job should exist") + } + + // Verify that "Process No-Op Messages" step is in the conclusion job + conclusionSection := extractJobSection(compiled, "conclusion") + if !strings.Contains(conclusionSection, "Process No-Op Messages") { + t.Error("Conclusion job should contain 'Process No-Op Messages' step") + } + + // Verify that conclusion job has noop_message output + if !strings.Contains(conclusionSection, "noop_message:") { + t.Error("Conclusion job should have 'noop_message' output") + } + + // Verify that conclusion job does NOT depend on noop job + if strings.Contains(conclusionSection, "- noop") { + t.Error("Conclusion job should NOT depend on 'noop' job") + } + + // Verify that conclusion job depends on agent job + if !strings.Contains(conclusionSection, "- agent") { + t.Error("Conclusion job should depend on 'agent' job") + } } From 27569b209fc2b9f0d3f11246256eb93c2cd0fe72 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:53:51 +0000 Subject: [PATCH 5/8] Remove unused buildCreateOutputNoOpJob function from noop.go - Removed buildCreateOutputNoOpJob function that is no longer used - Removed unused fmt import - Noop job is now generated inside conclusion job instead - All linter checks pass - All unit tests pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- pkg/workflow/noop.go | 52 -------------------------------------------- 1 file changed, 52 deletions(-) diff --git a/pkg/workflow/noop.go b/pkg/workflow/noop.go index b5b6280ede4..d1f5fdb5443 100644 --- a/pkg/workflow/noop.go +++ b/pkg/workflow/noop.go @@ -1,62 +1,10 @@ package workflow -import ( - "fmt" -) - // NoOpConfig holds configuration for no-op safe output (logging only) type NoOpConfig struct { BaseSafeOutputConfig `yaml:",inline"` } -// buildCreateOutputNoOpJob creates the noop job -func (c *Compiler) buildCreateOutputNoOpJob(data *WorkflowData, mainJobName string) (*Job, error) { - if data.SafeOutputs == nil || data.SafeOutputs.NoOp == nil { - return nil, fmt.Errorf("safe-outputs.noop configuration is required") - } - - // Build custom environment variables specific to noop - var customEnvVars []string - if data.SafeOutputs.NoOp.Max > 0 { - customEnvVars = append(customEnvVars, fmt.Sprintf(" GH_AW_NOOP_MAX: %d\n", data.SafeOutputs.NoOp.Max)) - } - - // Add workflow metadata for consistency - customEnvVars = append(customEnvVars, buildWorkflowMetadataEnvVarsWithCampaign(data.Name, data.Source, data.Campaign)...) - - // Build the GitHub Script step using the common helper - steps := c.buildGitHubScriptStep(data, GitHubScriptStepConfig{ - StepName: "Process No-Op Messages", - StepID: "noop", - MainJobName: mainJobName, - CustomEnvVars: customEnvVars, - Script: getNoOpScript(), - Token: data.SafeOutputs.NoOp.GitHubToken, - }) - - // Create outputs for the job - outputs := map[string]string{ - "noop_message": "${{ steps.noop.outputs.noop_message }}", - } - - // Build the job condition using BuildSafeOutputType - jobCondition := BuildSafeOutputType("noop").Render() - - // Create the job - job := &Job{ - Name: "noop", - RunsOn: c.formatSafeOutputsRunsOn(data.SafeOutputs), - If: jobCondition, - Permissions: NewPermissionsContentsRead().RenderToYAML(), - TimeoutMinutes: 5, // Short timeout since it's just logging - Steps: steps, - Outputs: outputs, - Needs: []string{mainJobName}, // Depend on the main workflow job - } - - return job, nil -} - // parseNoOpConfig handles noop configuration func (c *Compiler) parseNoOpConfig(outputMap map[string]any) *NoOpConfig { if configData, exists := outputMap["noop"]; exists { From 0cc0eb23713c95696ee786d44a1d07b642221c0d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:58:32 +0000 Subject: [PATCH 6/8] Move noop processing step from separate job into conclusion job Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .../docs/reference/frontmatter-full.md | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/docs/src/content/docs/reference/frontmatter-full.md b/docs/src/content/docs/reference/frontmatter-full.md index ae03889de15..0ed6543467e 100644 --- a/docs/src/content/docs/reference/frontmatter-full.md +++ b/docs/src/content/docs/reference/frontmatter-full.md @@ -548,6 +548,12 @@ on: # (optional) stop-after: "example-value" + # GitHub search query string to check before running workflow. If the search + # returns any results, the workflow will be skipped. Query is automatically scoped + # to the current repository. Example: 'is:issue is:open label:bug' + # (optional) + skip-if-match: "example-value" + # Environment name that requires manual approval before the workflow can run. Must # match a valid environment configured in the repository settings. # (optional) @@ -1680,6 +1686,28 @@ safe-outputs: # (optional) # This field supports multiple formats (oneOf): + # Option 1: Configuration for no-op safe output (logging only, no GitHub API + # calls). Always available as a fallback to ensure human-visible artifacts. + noop: + # Maximum number of noop messages (default: 1) + # (optional) + max: 1 + + # GitHub token to use for this specific output type. Overrides global github-token + # if specified. + # (optional) + github-token: "${{ secrets.GITHUB_TOKEN }}" + + # Option 2: Enable noop output with default configuration (max: 1) + noop: null + + # Option 3: Explicitly disable noop output (false). Noop is enabled by default + # when safe-outputs is configured. + noop: true + + # (optional) + # This field supports multiple formats (oneOf): + # Option 1: Configuration for publishing assets to an orphaned git branch upload-assets: # Branch name (default: 'assets/${{ github.workflow }}') From d42afa8570ee972252ab47c3683b06e2613471b0 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 19 Nov 2025 07:10:53 +0000 Subject: [PATCH 7/8] Fix duplicate artifact download steps in conclusion job - Added buildGitHubScriptStepWithoutDownload helper function - Artifact download steps now added once at beginning of conclusion job - Both noop and conclusion steps share the same artifact download - Eliminates duplicate "Download agent output artifact" steps - All workflows compile successfully with no duplicate downloads Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- .github/workflows/ai-triage-campaign.lock.yml | 11 ----- .github/workflows/archie.lock.yml | 11 ----- .github/workflows/artifacts-summary.lock.yml | 11 ----- .github/workflows/audit-workflows.lock.yml | 11 ----- .github/workflows/blog-auditor.lock.yml | 11 ----- .github/workflows/brave.lock.yml | 11 ----- .github/workflows/changeset.lock.yml | 11 ----- .github/workflows/ci-doctor.lock.yml | 11 ----- .../cli-consistency-checker.lock.yml | 11 ----- .../workflows/cli-version-checker.lock.yml | 11 ----- .github/workflows/cloclo.lock.yml | 11 ----- .../commit-changes-analyzer.lock.yml | 11 ----- .../workflows/copilot-agent-analysis.lock.yml | 11 ----- .../copilot-pr-nlp-analysis.lock.yml | 11 ----- .../copilot-pr-prompt-analysis.lock.yml | 11 ----- .../copilot-session-insights.lock.yml | 11 ----- .github/workflows/craft.lock.yml | 11 ----- .github/workflows/daily-code-metrics.lock.yml | 11 ----- .github/workflows/daily-doc-updater.lock.yml | 11 ----- .github/workflows/daily-file-diet.lock.yml | 11 ----- .../workflows/daily-firewall-report.lock.yml | 11 ----- .../daily-multi-device-docs-tester.lock.yml | 11 ----- .github/workflows/daily-news.lock.yml | 11 ----- .../workflows/daily-repo-chronicle.lock.yml | 11 ----- .github/workflows/daily-team-status.lock.yml | 11 ----- .../workflows/dependabot-go-checker.lock.yml | 11 ----- .github/workflows/dev-hawk.lock.yml | 11 ----- .github/workflows/dev.lock.yml | 11 ----- .../developer-docs-consolidator.lock.yml | 11 ----- .github/workflows/dictation-prompt.lock.yml | 11 ----- .github/workflows/docs-noob-tester.lock.yml | 11 ----- .../duplicate-code-detector.lock.yml | 11 ----- .../example-workflow-analyzer.lock.yml | 11 ----- .../github-mcp-tools-report.lock.yml | 11 ----- .github/workflows/go-logger.lock.yml | 11 ----- .../workflows/go-pattern-detector.lock.yml | 11 ----- .github/workflows/grumpy-reviewer.lock.yml | 11 ----- .../workflows/instructions-janitor.lock.yml | 11 ----- .github/workflows/issue-classifier.lock.yml | 11 ----- .github/workflows/lockfile-stats.lock.yml | 11 ----- .github/workflows/mcp-inspector.lock.yml | 11 ----- .github/workflows/mergefest.lock.yml | 11 ----- .github/workflows/pdf-summary.lock.yml | 11 ----- .github/workflows/plan.lock.yml | 11 ----- .github/workflows/poem-bot.lock.yml | 11 ----- .../workflows/pr-nitpick-reviewer.lock.yml | 11 ----- .../prompt-clustering-analysis.lock.yml | 11 ----- .github/workflows/python-data-charts.lock.yml | 11 ----- .github/workflows/q.lock.yml | 11 ----- .github/workflows/repo-tree-map.lock.yml | 11 ----- .../repository-quality-improver.lock.yml | 11 ----- .github/workflows/research.lock.yml | 11 ----- .github/workflows/safe-output-health.lock.yml | 11 ----- .../schema-consistency-checker.lock.yml | 11 ----- .github/workflows/scout.lock.yml | 11 ----- .github/workflows/security-fix-pr.lock.yml | 11 ----- .../semantic-function-refactor.lock.yml | 11 ----- .github/workflows/smoke-claude.lock.yml | 11 ----- .github/workflows/smoke-codex.lock.yml | 11 ----- .github/workflows/smoke-copilot.lock.yml | 11 ----- .github/workflows/smoke-detector.lock.yml | 11 ----- .../workflows/static-analysis-report.lock.yml | 11 ----- .github/workflows/super-linter.lock.yml | 11 ----- .../workflows/technical-doc-writer.lock.yml | 11 ----- .../test-ollama-threat-detection.lock.yml | 11 ----- .github/workflows/tidy.lock.yml | 11 ----- .github/workflows/typist.lock.yml | 11 ----- .github/workflows/unbloat-docs.lock.yml | 11 ----- .github/workflows/video-analyzer.lock.yml | 11 ----- .../workflows/weekly-issue-summary.lock.yml | 11 ----- pkg/workflow/notify_comment.go | 13 +++--- pkg/workflow/safe_outputs.go | 41 +++++++++++++++++++ 72 files changed, 49 insertions(+), 775 deletions(-) diff --git a/.github/workflows/ai-triage-campaign.lock.yml b/.github/workflows/ai-triage-campaign.lock.yml index a5645dc67ab..6b43ed4546a 100644 --- a/.github/workflows/ai-triage-campaign.lock.yml +++ b/.github/workflows/ai-triage-campaign.lock.yml @@ -3697,17 +3697,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/archie.lock.yml b/.github/workflows/archie.lock.yml index aa301910fa3..36d43109b01 100644 --- a/.github/workflows/archie.lock.yml +++ b/.github/workflows/archie.lock.yml @@ -4811,17 +4811,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/artifacts-summary.lock.yml b/.github/workflows/artifacts-summary.lock.yml index 117bee81c09..46c4418c78a 100644 --- a/.github/workflows/artifacts-summary.lock.yml +++ b/.github/workflows/artifacts-summary.lock.yml @@ -4010,17 +4010,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/audit-workflows.lock.yml b/.github/workflows/audit-workflows.lock.yml index aaa510cf46a..4e738f365da 100644 --- a/.github/workflows/audit-workflows.lock.yml +++ b/.github/workflows/audit-workflows.lock.yml @@ -4262,17 +4262,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/blog-auditor.lock.yml b/.github/workflows/blog-auditor.lock.yml index 9933e12de36..31532c5391e 100644 --- a/.github/workflows/blog-auditor.lock.yml +++ b/.github/workflows/blog-auditor.lock.yml @@ -3599,17 +3599,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/brave.lock.yml b/.github/workflows/brave.lock.yml index cc1f50f0847..1f1eb505ca8 100644 --- a/.github/workflows/brave.lock.yml +++ b/.github/workflows/brave.lock.yml @@ -4658,17 +4658,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/changeset.lock.yml b/.github/workflows/changeset.lock.yml index 80b0a83856d..ad643935ccf 100644 --- a/.github/workflows/changeset.lock.yml +++ b/.github/workflows/changeset.lock.yml @@ -4853,17 +4853,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/ci-doctor.lock.yml b/.github/workflows/ci-doctor.lock.yml index 6b06a1d8acf..96aedb2a303 100644 --- a/.github/workflows/ci-doctor.lock.yml +++ b/.github/workflows/ci-doctor.lock.yml @@ -4131,17 +4131,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/cli-consistency-checker.lock.yml b/.github/workflows/cli-consistency-checker.lock.yml index e2e615af2b8..c7e573f9d76 100644 --- a/.github/workflows/cli-consistency-checker.lock.yml +++ b/.github/workflows/cli-consistency-checker.lock.yml @@ -4048,17 +4048,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/cli-version-checker.lock.yml b/.github/workflows/cli-version-checker.lock.yml index 342344e8fae..dbca0100560 100644 --- a/.github/workflows/cli-version-checker.lock.yml +++ b/.github/workflows/cli-version-checker.lock.yml @@ -4238,17 +4238,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/cloclo.lock.yml b/.github/workflows/cloclo.lock.yml index a0c65b5e45a..0983ced0fdf 100644 --- a/.github/workflows/cloclo.lock.yml +++ b/.github/workflows/cloclo.lock.yml @@ -4905,17 +4905,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/commit-changes-analyzer.lock.yml b/.github/workflows/commit-changes-analyzer.lock.yml index 26c08e2c46b..ceef8e7aa31 100644 --- a/.github/workflows/commit-changes-analyzer.lock.yml +++ b/.github/workflows/commit-changes-analyzer.lock.yml @@ -3529,17 +3529,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/copilot-agent-analysis.lock.yml b/.github/workflows/copilot-agent-analysis.lock.yml index 4aea159ea49..3de65985ab9 100644 --- a/.github/workflows/copilot-agent-analysis.lock.yml +++ b/.github/workflows/copilot-agent-analysis.lock.yml @@ -3892,17 +3892,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/copilot-pr-nlp-analysis.lock.yml b/.github/workflows/copilot-pr-nlp-analysis.lock.yml index 526c1f64082..b81b2fa3399 100644 --- a/.github/workflows/copilot-pr-nlp-analysis.lock.yml +++ b/.github/workflows/copilot-pr-nlp-analysis.lock.yml @@ -4785,17 +4785,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/copilot-pr-prompt-analysis.lock.yml b/.github/workflows/copilot-pr-prompt-analysis.lock.yml index d487a089479..adaf7dd959a 100644 --- a/.github/workflows/copilot-pr-prompt-analysis.lock.yml +++ b/.github/workflows/copilot-pr-prompt-analysis.lock.yml @@ -4351,17 +4351,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/copilot-session-insights.lock.yml b/.github/workflows/copilot-session-insights.lock.yml index b4005e54405..334e9a8b619 100644 --- a/.github/workflows/copilot-session-insights.lock.yml +++ b/.github/workflows/copilot-session-insights.lock.yml @@ -4810,17 +4810,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/craft.lock.yml b/.github/workflows/craft.lock.yml index 59ff6c80873..ab061831ce3 100644 --- a/.github/workflows/craft.lock.yml +++ b/.github/workflows/craft.lock.yml @@ -4944,17 +4944,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/daily-code-metrics.lock.yml b/.github/workflows/daily-code-metrics.lock.yml index 4d8ddeb9dd3..73ce5a11fa0 100644 --- a/.github/workflows/daily-code-metrics.lock.yml +++ b/.github/workflows/daily-code-metrics.lock.yml @@ -3872,17 +3872,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/daily-doc-updater.lock.yml b/.github/workflows/daily-doc-updater.lock.yml index 71bd0a2bd68..cb2a6bc0224 100644 --- a/.github/workflows/daily-doc-updater.lock.yml +++ b/.github/workflows/daily-doc-updater.lock.yml @@ -3589,17 +3589,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/daily-file-diet.lock.yml b/.github/workflows/daily-file-diet.lock.yml index c913cb5571f..707b2edb10e 100644 --- a/.github/workflows/daily-file-diet.lock.yml +++ b/.github/workflows/daily-file-diet.lock.yml @@ -3206,17 +3206,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/daily-firewall-report.lock.yml b/.github/workflows/daily-firewall-report.lock.yml index 2e192688240..c46b53ecda9 100644 --- a/.github/workflows/daily-firewall-report.lock.yml +++ b/.github/workflows/daily-firewall-report.lock.yml @@ -4777,17 +4777,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/daily-multi-device-docs-tester.lock.yml b/.github/workflows/daily-multi-device-docs-tester.lock.yml index c80c8d964e8..ff0137cd2b6 100644 --- a/.github/workflows/daily-multi-device-docs-tester.lock.yml +++ b/.github/workflows/daily-multi-device-docs-tester.lock.yml @@ -3391,17 +3391,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/daily-news.lock.yml b/.github/workflows/daily-news.lock.yml index 7d72325b162..fb428d17563 100644 --- a/.github/workflows/daily-news.lock.yml +++ b/.github/workflows/daily-news.lock.yml @@ -4787,17 +4787,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/daily-repo-chronicle.lock.yml b/.github/workflows/daily-repo-chronicle.lock.yml index d7a0899d830..7e8b97b0296 100644 --- a/.github/workflows/daily-repo-chronicle.lock.yml +++ b/.github/workflows/daily-repo-chronicle.lock.yml @@ -4631,17 +4631,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/daily-team-status.lock.yml b/.github/workflows/daily-team-status.lock.yml index f73aa8bd954..50468a0d1fe 100644 --- a/.github/workflows/daily-team-status.lock.yml +++ b/.github/workflows/daily-team-status.lock.yml @@ -3576,17 +3576,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/dependabot-go-checker.lock.yml b/.github/workflows/dependabot-go-checker.lock.yml index 03244f44016..dcd1f8da0bd 100644 --- a/.github/workflows/dependabot-go-checker.lock.yml +++ b/.github/workflows/dependabot-go-checker.lock.yml @@ -3715,17 +3715,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/dev-hawk.lock.yml b/.github/workflows/dev-hawk.lock.yml index 902761a5c1d..e39d1737e63 100644 --- a/.github/workflows/dev-hawk.lock.yml +++ b/.github/workflows/dev-hawk.lock.yml @@ -4018,17 +4018,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/dev.lock.yml b/.github/workflows/dev.lock.yml index f86272a5daa..cadc2825949 100644 --- a/.github/workflows/dev.lock.yml +++ b/.github/workflows/dev.lock.yml @@ -3964,17 +3964,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/developer-docs-consolidator.lock.yml b/.github/workflows/developer-docs-consolidator.lock.yml index 0af9c96fed3..830e70ea8e4 100644 --- a/.github/workflows/developer-docs-consolidator.lock.yml +++ b/.github/workflows/developer-docs-consolidator.lock.yml @@ -4142,17 +4142,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/dictation-prompt.lock.yml b/.github/workflows/dictation-prompt.lock.yml index e852bcb43b4..a8621b4081c 100644 --- a/.github/workflows/dictation-prompt.lock.yml +++ b/.github/workflows/dictation-prompt.lock.yml @@ -3769,17 +3769,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/docs-noob-tester.lock.yml b/.github/workflows/docs-noob-tester.lock.yml index b2469f5c253..d0c486f94d7 100644 --- a/.github/workflows/docs-noob-tester.lock.yml +++ b/.github/workflows/docs-noob-tester.lock.yml @@ -4070,17 +4070,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/duplicate-code-detector.lock.yml b/.github/workflows/duplicate-code-detector.lock.yml index c265a94ad88..660652dbc2d 100644 --- a/.github/workflows/duplicate-code-detector.lock.yml +++ b/.github/workflows/duplicate-code-detector.lock.yml @@ -3121,17 +3121,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/example-workflow-analyzer.lock.yml b/.github/workflows/example-workflow-analyzer.lock.yml index b2f79bb6c09..8ca064648a3 100644 --- a/.github/workflows/example-workflow-analyzer.lock.yml +++ b/.github/workflows/example-workflow-analyzer.lock.yml @@ -3311,17 +3311,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/github-mcp-tools-report.lock.yml b/.github/workflows/github-mcp-tools-report.lock.yml index 25bcba83f96..91b2a14ccb4 100644 --- a/.github/workflows/github-mcp-tools-report.lock.yml +++ b/.github/workflows/github-mcp-tools-report.lock.yml @@ -3964,17 +3964,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/go-logger.lock.yml b/.github/workflows/go-logger.lock.yml index 77be29e43d3..34bf9287631 100644 --- a/.github/workflows/go-logger.lock.yml +++ b/.github/workflows/go-logger.lock.yml @@ -3708,17 +3708,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/go-pattern-detector.lock.yml b/.github/workflows/go-pattern-detector.lock.yml index 8c46c479cf5..cf3910a36a9 100644 --- a/.github/workflows/go-pattern-detector.lock.yml +++ b/.github/workflows/go-pattern-detector.lock.yml @@ -3351,17 +3351,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/grumpy-reviewer.lock.yml b/.github/workflows/grumpy-reviewer.lock.yml index 0d45da75a8e..a65d86c926f 100644 --- a/.github/workflows/grumpy-reviewer.lock.yml +++ b/.github/workflows/grumpy-reviewer.lock.yml @@ -4714,17 +4714,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/instructions-janitor.lock.yml b/.github/workflows/instructions-janitor.lock.yml index 4efe7b545cf..d0cfba2933f 100644 --- a/.github/workflows/instructions-janitor.lock.yml +++ b/.github/workflows/instructions-janitor.lock.yml @@ -3587,17 +3587,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/issue-classifier.lock.yml b/.github/workflows/issue-classifier.lock.yml index dc6ebc113bc..aa25f0271f3 100644 --- a/.github/workflows/issue-classifier.lock.yml +++ b/.github/workflows/issue-classifier.lock.yml @@ -3205,17 +3205,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/lockfile-stats.lock.yml b/.github/workflows/lockfile-stats.lock.yml index 7fde996d0fe..b33bf8ea360 100644 --- a/.github/workflows/lockfile-stats.lock.yml +++ b/.github/workflows/lockfile-stats.lock.yml @@ -3666,17 +3666,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/mcp-inspector.lock.yml b/.github/workflows/mcp-inspector.lock.yml index 219780c6959..52d356671dd 100644 --- a/.github/workflows/mcp-inspector.lock.yml +++ b/.github/workflows/mcp-inspector.lock.yml @@ -4583,17 +4583,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/mergefest.lock.yml b/.github/workflows/mergefest.lock.yml index 1e051747210..ddb8aeb2f3c 100644 --- a/.github/workflows/mergefest.lock.yml +++ b/.github/workflows/mergefest.lock.yml @@ -4323,17 +4323,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/pdf-summary.lock.yml b/.github/workflows/pdf-summary.lock.yml index 92441076d2c..faa3f1dd200 100644 --- a/.github/workflows/pdf-summary.lock.yml +++ b/.github/workflows/pdf-summary.lock.yml @@ -4764,17 +4764,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/plan.lock.yml b/.github/workflows/plan.lock.yml index f3615c97d5a..fa7eb66e193 100644 --- a/.github/workflows/plan.lock.yml +++ b/.github/workflows/plan.lock.yml @@ -4239,17 +4239,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/poem-bot.lock.yml b/.github/workflows/poem-bot.lock.yml index b16a44c7144..ba18cde71c3 100644 --- a/.github/workflows/poem-bot.lock.yml +++ b/.github/workflows/poem-bot.lock.yml @@ -5180,17 +5180,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/pr-nitpick-reviewer.lock.yml b/.github/workflows/pr-nitpick-reviewer.lock.yml index 53a693994ca..f36836bede0 100644 --- a/.github/workflows/pr-nitpick-reviewer.lock.yml +++ b/.github/workflows/pr-nitpick-reviewer.lock.yml @@ -4774,17 +4774,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/prompt-clustering-analysis.lock.yml b/.github/workflows/prompt-clustering-analysis.lock.yml index b132c00b9ea..371046730a2 100644 --- a/.github/workflows/prompt-clustering-analysis.lock.yml +++ b/.github/workflows/prompt-clustering-analysis.lock.yml @@ -4006,17 +4006,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/python-data-charts.lock.yml b/.github/workflows/python-data-charts.lock.yml index 45f246104a0..24f981f42a7 100644 --- a/.github/workflows/python-data-charts.lock.yml +++ b/.github/workflows/python-data-charts.lock.yml @@ -4950,17 +4950,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/q.lock.yml b/.github/workflows/q.lock.yml index 16f1566be09..f6e859a7d7b 100644 --- a/.github/workflows/q.lock.yml +++ b/.github/workflows/q.lock.yml @@ -5237,17 +5237,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/repo-tree-map.lock.yml b/.github/workflows/repo-tree-map.lock.yml index 1948ff6d6c2..e192c471e23 100644 --- a/.github/workflows/repo-tree-map.lock.yml +++ b/.github/workflows/repo-tree-map.lock.yml @@ -3673,17 +3673,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/repository-quality-improver.lock.yml b/.github/workflows/repository-quality-improver.lock.yml index fb0dbedc3d0..578512221ed 100644 --- a/.github/workflows/repository-quality-improver.lock.yml +++ b/.github/workflows/repository-quality-improver.lock.yml @@ -4191,17 +4191,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/research.lock.yml b/.github/workflows/research.lock.yml index 22732f974dd..c45aad41a73 100644 --- a/.github/workflows/research.lock.yml +++ b/.github/workflows/research.lock.yml @@ -3974,17 +3974,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/safe-output-health.lock.yml b/.github/workflows/safe-output-health.lock.yml index 5c4267a3526..4f93031d59f 100644 --- a/.github/workflows/safe-output-health.lock.yml +++ b/.github/workflows/safe-output-health.lock.yml @@ -3799,17 +3799,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/schema-consistency-checker.lock.yml b/.github/workflows/schema-consistency-checker.lock.yml index 650d1d43723..7b539224f41 100644 --- a/.github/workflows/schema-consistency-checker.lock.yml +++ b/.github/workflows/schema-consistency-checker.lock.yml @@ -3672,17 +3672,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/scout.lock.yml b/.github/workflows/scout.lock.yml index d79ce6d469e..77695103992 100644 --- a/.github/workflows/scout.lock.yml +++ b/.github/workflows/scout.lock.yml @@ -4786,17 +4786,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/security-fix-pr.lock.yml b/.github/workflows/security-fix-pr.lock.yml index f8198a5af7d..572abd2a725 100644 --- a/.github/workflows/security-fix-pr.lock.yml +++ b/.github/workflows/security-fix-pr.lock.yml @@ -3535,17 +3535,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/semantic-function-refactor.lock.yml b/.github/workflows/semantic-function-refactor.lock.yml index df616cd809a..afe38ac0257 100644 --- a/.github/workflows/semantic-function-refactor.lock.yml +++ b/.github/workflows/semantic-function-refactor.lock.yml @@ -3760,17 +3760,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/smoke-claude.lock.yml b/.github/workflows/smoke-claude.lock.yml index 691755793cc..7d45101b027 100644 --- a/.github/workflows/smoke-claude.lock.yml +++ b/.github/workflows/smoke-claude.lock.yml @@ -3319,17 +3319,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/smoke-codex.lock.yml b/.github/workflows/smoke-codex.lock.yml index 2b26f9d5315..0fca60b4173 100644 --- a/.github/workflows/smoke-codex.lock.yml +++ b/.github/workflows/smoke-codex.lock.yml @@ -2863,17 +2863,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/smoke-copilot.lock.yml b/.github/workflows/smoke-copilot.lock.yml index cfda05d2c82..07a422961f4 100644 --- a/.github/workflows/smoke-copilot.lock.yml +++ b/.github/workflows/smoke-copilot.lock.yml @@ -3891,17 +3891,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/smoke-detector.lock.yml b/.github/workflows/smoke-detector.lock.yml index fa8fd4548d8..4279d956ebd 100644 --- a/.github/workflows/smoke-detector.lock.yml +++ b/.github/workflows/smoke-detector.lock.yml @@ -4386,17 +4386,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/static-analysis-report.lock.yml b/.github/workflows/static-analysis-report.lock.yml index 5530bb7a29c..1edaabbb655 100644 --- a/.github/workflows/static-analysis-report.lock.yml +++ b/.github/workflows/static-analysis-report.lock.yml @@ -3687,17 +3687,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/super-linter.lock.yml b/.github/workflows/super-linter.lock.yml index ea4ea8010ef..57f1f93abec 100644 --- a/.github/workflows/super-linter.lock.yml +++ b/.github/workflows/super-linter.lock.yml @@ -3746,17 +3746,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/technical-doc-writer.lock.yml b/.github/workflows/technical-doc-writer.lock.yml index e5aded62b96..222c3ae40d3 100644 --- a/.github/workflows/technical-doc-writer.lock.yml +++ b/.github/workflows/technical-doc-writer.lock.yml @@ -4926,17 +4926,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/test-ollama-threat-detection.lock.yml b/.github/workflows/test-ollama-threat-detection.lock.yml index af91f80adf9..8d906445bec 100644 --- a/.github/workflows/test-ollama-threat-detection.lock.yml +++ b/.github/workflows/test-ollama-threat-detection.lock.yml @@ -3469,17 +3469,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/tidy.lock.yml b/.github/workflows/tidy.lock.yml index 235c7463134..f1b49f319d2 100644 --- a/.github/workflows/tidy.lock.yml +++ b/.github/workflows/tidy.lock.yml @@ -4127,17 +4127,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/typist.lock.yml b/.github/workflows/typist.lock.yml index 1b5a0df62b2..8682be4b9c3 100644 --- a/.github/workflows/typist.lock.yml +++ b/.github/workflows/typist.lock.yml @@ -3830,17 +3830,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/unbloat-docs.lock.yml b/.github/workflows/unbloat-docs.lock.yml index b61dfbdc1c0..c1010711c8b 100644 --- a/.github/workflows/unbloat-docs.lock.yml +++ b/.github/workflows/unbloat-docs.lock.yml @@ -4621,17 +4621,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/video-analyzer.lock.yml b/.github/workflows/video-analyzer.lock.yml index 426042d2f2b..ab92facb471 100644 --- a/.github/workflows/video-analyzer.lock.yml +++ b/.github/workflows/video-analyzer.lock.yml @@ -3760,17 +3760,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/.github/workflows/weekly-issue-summary.lock.yml b/.github/workflows/weekly-issue-summary.lock.yml index b8cd59fad72..36adbf98091 100644 --- a/.github/workflows/weekly-issue-summary.lock.yml +++ b/.github/workflows/weekly-issue-summary.lock.yml @@ -4539,17 +4539,6 @@ jobs: core.info(`Successfully processed ${noopItems.length} noop message(s)`); } await main(); - - name: Download agent output artifact - continue-on-error: true - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6 - with: - name: agent_output.json - path: /tmp/gh-aw/safeoutputs/ - - name: Setup agent output environment variable - run: | - mkdir -p /tmp/gh-aw/safeoutputs/ - find "/tmp/gh-aw/safeoutputs/" -type f -print - echo "GH_AW_AGENT_OUTPUT=/tmp/gh-aw/safeoutputs/agent_output.json" >> "$GITHUB_ENV" - name: Update reaction comment with completion status id: conclusion uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 diff --git a/pkg/workflow/notify_comment.go b/pkg/workflow/notify_comment.go index 996ee624359..44a247ea24a 100644 --- a/pkg/workflow/notify_comment.go +++ b/pkg/workflow/notify_comment.go @@ -57,6 +57,9 @@ func (c *Compiler) buildConclusionJob(data *WorkflowData, mainJobName string, sa steps = append(steps, " echo \"Agent Output Types: $AGENT_OUTPUT_TYPES\"\n") steps = append(steps, " echo \"Agent Conclusion: $AGENT_CONCLUSION\"\n") + // Add artifact download steps once (shared by noop and conclusion steps) + steps = append(steps, buildAgentOutputDownloadSteps()...) + // Add noop processing step if noop is configured if data.SafeOutputs.NoOp != nil { // Build custom environment variables specific to noop @@ -68,8 +71,8 @@ func (c *Compiler) buildConclusionJob(data *WorkflowData, mainJobName string, sa // Add workflow metadata for consistency noopEnvVars = append(noopEnvVars, buildWorkflowMetadataEnvVarsWithCampaign(data.Name, data.Source, data.Campaign)...) - // Build the noop processing step - noopSteps := c.buildGitHubScriptStep(data, GitHubScriptStepConfig{ + // Build the noop processing step (without artifact downloads - already added above) + noopSteps := c.buildGitHubScriptStepWithoutDownload(data, GitHubScriptStepConfig{ StepName: "Process No-Op Messages", StepID: "noop", MainJobName: mainJobName, @@ -80,7 +83,7 @@ func (c *Compiler) buildConclusionJob(data *WorkflowData, mainJobName string, sa steps = append(steps, noopSteps...) } - // Build environment variables for the script + // Build environment variables for the conclusion script var customEnvVars []string customEnvVars = append(customEnvVars, fmt.Sprintf(" GH_AW_COMMENT_ID: ${{ needs.%s.outputs.comment_id }}\n", constants.ActivationJobName)) customEnvVars = append(customEnvVars, fmt.Sprintf(" GH_AW_COMMENT_REPO: ${{ needs.%s.outputs.comment_repo }}\n", constants.ActivationJobName)) @@ -98,8 +101,8 @@ func (c *Compiler) buildConclusionJob(data *WorkflowData, mainJobName string, sa token = data.SafeOutputs.AddComments.GitHubToken } - // Build the GitHub Script step using the common helper - scriptSteps := c.buildGitHubScriptStep(data, GitHubScriptStepConfig{ + // Build the conclusion GitHub Script step (without artifact downloads - already added above) + scriptSteps := c.buildGitHubScriptStepWithoutDownload(data, GitHubScriptStepConfig{ StepName: "Update reaction comment with completion status", StepID: "conclusion", MainJobName: mainJobName, diff --git a/pkg/workflow/safe_outputs.go b/pkg/workflow/safe_outputs.go index bb29a61d3a6..93d40e59ce3 100644 --- a/pkg/workflow/safe_outputs.go +++ b/pkg/workflow/safe_outputs.go @@ -629,6 +629,47 @@ func (c *Compiler) buildGitHubScriptStep(data *WorkflowData, config GitHubScript return steps } +// buildGitHubScriptStepWithoutDownload creates a GitHub Script step without artifact download steps +// This is useful when multiple script steps are needed in the same job and artifact downloads +// should only happen once at the beginning +func (c *Compiler) buildGitHubScriptStepWithoutDownload(data *WorkflowData, config GitHubScriptStepConfig) []string { + var steps []string + + // Step name and metadata (no artifact download steps) + steps = append(steps, fmt.Sprintf(" - name: %s\n", config.StepName)) + steps = append(steps, fmt.Sprintf(" id: %s\n", config.StepID)) + steps = append(steps, fmt.Sprintf(" uses: %s\n", GetActionPin("actions/github-script"))) + + // Environment variables section + steps = append(steps, " env:\n") + + // Read GH_AW_AGENT_OUTPUT from environment (set by artifact download step) + // instead of directly from job outputs which may be masked by GitHub Actions + steps = append(steps, " GH_AW_AGENT_OUTPUT: ${{ env.GH_AW_AGENT_OUTPUT }}\n") + + // Add custom environment variables specific to this safe output type + steps = append(steps, config.CustomEnvVars...) + + // Add custom environment variables from safe-outputs.env + c.addCustomSafeOutputEnvVars(&steps, data) + + // With section for github-token + steps = append(steps, " with:\n") + if config.UseCopilotToken { + c.addSafeOutputCopilotGitHubTokenForConfig(&steps, data, config.Token) + } else { + c.addSafeOutputGitHubTokenForConfig(&steps, data, config.Token) + } + + steps = append(steps, " script: |\n") + + // Add the formatted JavaScript script + formattedScript := FormatJavaScriptForYAML(config.Script) + steps = append(steps, formattedScript...) + + return steps +} + // buildAgentOutputDownloadSteps creates steps to download the agent output artifact // and set the GH_AW_AGENT_OUTPUT environment variable for safe-output jobs func buildAgentOutputDownloadSteps() []string { From 68789ac0edbae198a97599b0b27dc476a6290aed Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Wed, 19 Nov 2025 07:12:01 +0000 Subject: [PATCH 8/8] Add changeset [skip-ci] --- .changeset/patch-consolidate-noop-in-conclusion-job.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/patch-consolidate-noop-in-conclusion-job.md diff --git a/.changeset/patch-consolidate-noop-in-conclusion-job.md b/.changeset/patch-consolidate-noop-in-conclusion-job.md new file mode 100644 index 00000000000..2853aca4ce4 --- /dev/null +++ b/.changeset/patch-consolidate-noop-in-conclusion-job.md @@ -0,0 +1,5 @@ +--- +"gh-aw": patch +--- + +Move noop processing step from separate job into conclusion job