diff --git a/actions/setup/js/add_reaction.cjs b/actions/setup/js/add_reaction.cjs index ad857c6324e..df3a561c6de 100644 --- a/actions/setup/js/add_reaction.cjs +++ b/actions/setup/js/add_reaction.cjs @@ -30,9 +30,8 @@ async function main() { core.info(`Adding reaction: ${reaction}`); // Validate reaction type - const validReactions = Object.keys(REACTION_MAP); - if (!validReactions.includes(reaction)) { - core.setFailed(`${ERR_VALIDATION}: Invalid reaction type: ${reaction}. Valid reactions are: ${validReactions.join(", ")}`); + if (!Object.prototype.hasOwnProperty.call(REACTION_MAP, reaction)) { + core.setFailed(`${ERR_VALIDATION}: Invalid reaction type: ${reaction}. Valid reactions are: ${Object.keys(REACTION_MAP).join(", ")}`); return; } diff --git a/actions/setup/js/add_reaction_and_edit_comment.cjs b/actions/setup/js/add_reaction_and_edit_comment.cjs index d8e2ef266cd..b4ab19bc419 100644 --- a/actions/setup/js/add_reaction_and_edit_comment.cjs +++ b/actions/setup/js/add_reaction_and_edit_comment.cjs @@ -9,7 +9,7 @@ const { ERR_API, ERR_NOT_FOUND, ERR_VALIDATION } = require("./error_codes.cjs"); const { buildWorkflowRunUrl } = require("./workflow_metadata_helpers.cjs"); const { createDiscussionComment, resolveTopLevelDiscussionCommentId } = require("./github_api_helpers.cjs"); const { resolveInvocationContext } = require("./invocation_context_helpers.cjs"); -const { addReaction, addDiscussionReaction, getDiscussionNodeId } = require("./add_reaction.cjs"); +const { addReaction, addDiscussionReaction, getDiscussionNodeId, REACTION_MAP } = require("./add_reaction.cjs"); /** * Event type descriptions for comment messages @@ -25,7 +25,7 @@ const EVENT_TYPE_DESCRIPTIONS = { }; /** Valid GitHub reaction types */ -const VALID_REACTIONS = Object.freeze(["+1", "-1", "laugh", "confused", "heart", "hooray", "rocket", "eyes"]); +const VALID_REACTIONS = Object.freeze(Object.keys(REACTION_MAP)); /** * Resolve the reaction and comment API endpoints for a given event.