From a8daf222f8a8d409dd59c1931770e2c2138df3ad Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 8 Jul 2026 15:11:08 +0000 Subject: [PATCH] =?UTF-8?q?chore:=20remove=20dead=20functions=20=E2=80=94?= =?UTF-8?q?=201=20function=20removed?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove renderMarkdownMetricsTrend which was unreachable (no non-test callers) and its exclusive test TestRenderMarkdownMetricsTrend_IncludesTurnsWithoutTokens. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- pkg/cli/audit_cross_run_render.go | 4 ---- pkg/cli/audit_cross_run_test.go | 24 ------------------------ 2 files changed, 28 deletions(-) diff --git a/pkg/cli/audit_cross_run_render.go b/pkg/cli/audit_cross_run_render.go index 4e698ffd068..149e3ada650 100644 --- a/pkg/cli/audit_cross_run_render.go +++ b/pkg/cli/audit_cross_run_render.go @@ -59,10 +59,6 @@ func renderMarkdownExecutiveSummaryToWriter(w io.Writer, report *CrossRunAuditRe fmt.Fprintln(w) } -func renderMarkdownMetricsTrend(mt MetricsTrendData) { - renderMarkdownMetricsTrendToWriter(os.Stdout, mt) -} - func renderMarkdownMetricsTrendToWriter(w io.Writer, mt MetricsTrendData) { if mt.TotalTokens == 0 && mt.TotalTurns == 0 && mt.AvgDurationNs == 0 { return diff --git a/pkg/cli/audit_cross_run_test.go b/pkg/cli/audit_cross_run_test.go index 42639d0f5bb..ec438ca28ad 100644 --- a/pkg/cli/audit_cross_run_test.go +++ b/pkg/cli/audit_cross_run_test.go @@ -312,30 +312,6 @@ func TestRenderCrossRunReportMarkdown(t *testing.T) { assert.Contains(t, output, "api.github.com:443", "Should contain the domain") } -func TestRenderMarkdownMetricsTrend_IncludesTurnsWithoutTokens(t *testing.T) { - oldStdout := os.Stdout - r, w, err := os.Pipe() - require.NoError(t, err, "should create stdout pipe") - os.Stdout = w - - renderMarkdownMetricsTrend(MetricsTrendData{ - TotalTurns: 9, - AvgTurns: 4.5, - MaxTurns: 6, - }) - - w.Close() - os.Stdout = oldStdout - - var buf bytes.Buffer - _, err = buf.ReadFrom(r) - require.NoError(t, err, "should read captured stdout") - output := buf.String() - - assert.Contains(t, output, "## Metrics Trends", "Should render metrics section when turn metrics exist") - assert.Contains(t, output, "| Turns | 9 | 4.5 | — | 6 | — |", "Should render turns row without tokens") -} - func TestRenderPrettyMetricsTrend_IncludesDurationWithoutTokens(t *testing.T) { oldStderr := os.Stderr r, w, err := os.Pipe()