feat(ir): add typed builder for PipAuthenticate@1#1142
Merged
Conversation
Add a typed builder struct for `PipAuthenticate@1` to
`src/compile/ir/tasks/pip_authenticate.rs`, following the same pattern
as `NuGetAuthenticate` and `CargoAuthenticate`.
Also migrate `src/runtimes/python/extension.rs` from the stringly-typed
`TaskStep::new("PipAuthenticate@1", ...)` call to the new typed builder.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed builder struct for
PipAuthenticate@1to the ado-aw IR, and migrates the Python runtime extension from a stringly-typedTaskStep::new(...)call to the new builder.Motivation
Previously, the Python runtime extension emitted the pip authentication step by hand-crafting
TaskStep::new("PipAuthenticate@1", ...).with_input("artifactFeeds", "")with raw string input keys. This PR introduces a typed builder struct (new()+ typed optional setters +into_step()) so all inputs are type-checked, optional inputs are only emitted when explicitly set, and call sites stop using stringly-typed keys — consistent with the existingNuGetAuthenticateandCargoAuthenticatebuilders.Changes
src/compile/ir/tasks/pip_authenticate.rs: newPipAuthenticatebuilder struct with typed optional setters for all five inputs (azureDevOpsServiceConnection,feedUrl,artifactFeeds,pythonDownloadServiceConnections,onlyAddExtraIndex) and a full#[cfg(test)] mod testssrc/compile/ir/tasks/mod.rs:pub mod pip_authenticate;declaration (alphabetical order)src/runtimes/python/extension.rs: migratedpip_authenticate_task_step()from rawTaskStep::new(...)toPipAuthenticate::new().artifact_feeds("").with_display_name(...).into_step()ADO Task Reference
PipAuthenticate@1azureDevOpsServiceConnection,feedUrl,artifactFeeds,pythonDownloadServiceConnections,onlyAddExtraIndex(bool, defaultfalse)Validation
cargo build --all-targetscargo testcargo clippy --all-targets --all-features --workspace -- -D warningsCreated by the ado-task-ir-contributor workflow.
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comspsprodweu4.vssps.visualstudio.comSee Network Configuration for more information.