feat(ir): add typed builder for MavenAuthenticate@0#1161
Merged
Conversation
Adds a typed builder struct for `MavenAuthenticate@0` to the ado-aw IR, following the established pattern from `NuGetAuthenticate@1`, `PipAuthenticate@1`, `CargoAuthenticate@0`, and `TwineAuthenticate@1`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a typed builder struct for
MavenAuthenticate@0to the ado-aw IR, completing the authentication-task family alongsideNuGetAuthenticate@1,PipAuthenticate@1,CargoAuthenticate@0,npmAuthenticate@0, andTwineAuthenticate@1.Motivation
Previously, any code that needed to emit a
MavenAuthenticate@0step had to hand-craftTaskStep::new(...)with raw string input keys. This PR introduces a typed builder struct (new()+ typed optional setters +into_step()) so inputs and their semantics are explicit and type-checked.Changes
src/compile/ir/tasks/maven_authenticate.rs: newMavenAuthenticatebuilder struct and its#[cfg(test)] mod tests(9 unit tests)src/compile/ir/tasks/mod.rs:pub mod maven_authenticate;declaration (alphabetical order, betweenjava_tool_installerandnpm)ADO Task Reference
MavenAuthenticate@0artifactsFeeds— comma-separated Azure Artifacts feed names to authenticatemavenServiceConnections— comma-separated Maven service connection names for external repositories (ignored whenworkloadIdentityServiceConnectionis set)workloadIdentityServiceConnection— Entra Workload Identity-backed service connectionValidation
cargo build --all-targetscargo test(all 18 test suites pass, 9 new unit tests added)cargo clippy --all-targets --all-features --workspace -- -D warningsCreated by the ado-task-ir-contributor workflow.
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
spsprodeus21.vssps.visualstudio.comspsprodweu4.vssps.visualstudio.comSee Network Configuration for more information.