From e62761f74d6511e8b485d22e2e51d5af5ee61b48 Mon Sep 17 00:00:00 2001 From: HouXiaoxuan Date: Sat, 9 Nov 2024 00:44:23 +0800 Subject: [PATCH 1/2] fix: GitLFSError ignore content Signed-off-by: HouXiaoxuan --- common/src/errors.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/common/src/errors.rs b/common/src/errors.rs index 7bb306c7c..4a9f2e83d 100644 --- a/common/src/errors.rs +++ b/common/src/errors.rs @@ -75,9 +75,8 @@ impl From for MegaError { } #[derive(Error, Debug)] -#[allow(unused)] pub enum GitLFSError { - #[error("Something went wrong in Git LFS")] + #[error("Something went wrong in Git LFS: {0}")] GeneralError(String), } From de23af645c6215e3ec6c95a2544b523e39005daa Mon Sep 17 00:00:00 2001 From: Qihang Cai Date: Sat, 9 Nov 2024 00:53:07 +0800 Subject: [PATCH 2/2] fix: create parent dirs for `path` in `download_object_p2p` Signed-off-by: Qihang Cai --- libra/src/internal/protocol/lfs_client.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libra/src/internal/protocol/lfs_client.rs b/libra/src/internal/protocol/lfs_client.rs index 8b7105403..85c914e35 100644 --- a/libra/src/internal/protocol/lfs_client.rs +++ b/libra/src/internal/protocol/lfs_client.rs @@ -472,6 +472,9 @@ impl LFSClient { // infer that all chunks share same size! (except last one) let chunk_size = chunks.first().unwrap().size as usize; let mut checksum = Context::new(&SHA256); + if let Some(parent) = path.as_ref().parent() { + tokio::fs::create_dir_all(parent).await?; + } let mut file = tokio::fs::File::create(path).await?; for (i, chunk) in chunks.iter().enumerate() { // TODO parallel download println!("- part: {}/{}", i + 1, chunks.len());