Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Dec 20, 2025

  • Replace fomantic form CSS with custom module
  • Moved code in form.css to modules/form.css, removed around 70% of the previous module.
  • Moved captcha styles previously in form.css to its own file.

There is probably more unused CSS, like form error state colors which to my knowledge is not used anywhere, but I'm not sure about that one so I kept it.

One notable change is the removal of type combinator here, which lowers the selector specificity and I noticed one issue where selector .ui.search > .prompt was winning, so I added a workaround for that until the search module can be removed as well.

.ui.form .fields.error .field input:not([type])
.ui.form .fields.error .field input[type="date"]

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 20, 2025
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed modifies/frontend labels Dec 20, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 21, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 23, 2025
@lunny lunny added this to the 1.26.0 milestone Dec 23, 2025
@silverwind silverwind merged commit eddf875 into go-gitea:main Dec 23, 2025
24 checks passed
@silverwind silverwind deleted the rmform branch December 23, 2025 17:21
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 23, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 26, 2025
* giteaofficial/main:
  Fix panic when get editor config file (go-gitea#36241)
  Refactor compare router param parse (go-gitea#36105)
  [skip ci] Updated translations via Crowdin
  Use flatten translation keys (go-gitea#36225)
  Replace CSRF cookie with `CrossOriginProtection` (go-gitea#36183)
  Remove fomantic form module (go-gitea#36222)
  Fix panic in blame view when a file has only a single commit (go-gitea#36230)
  fix: spelling error in migrate-storage cmd utility (go-gitea#36226)

# Conflicts:
#	templates/user/settings/security/twofa.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants