test(condition): fixed flaky test (#40)

fredbi · web-flow · commit 178304f36678 · 2026-01-23T23:27:31.000+01:00
* fixes #38 Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
diff --git a/internal/assertions/condition_test.go b/internal/assertions/condition_test.go
@@ -238,7 +238,7 @@ func TestConditionEventuallyWithT(t *testing.T) {
 		Len(t, mock.errors, expectedErrors, "expected 2 errors from the condition, and 2 additional errors from Eventually")
 
 		expectedCalls := int(testTimeout / testTick)
-		if counter != expectedCalls && counter != expectedCalls+1 { // it may be 5 or 6 depending on how the test schedules
+		if counter < expectedCalls-1 || counter > expectedCalls+1 { // it may be 4, 5 or 6 depending on how the test schedules
 			t.Errorf("expected %d calls to the condition, but got %d", expectedCalls, counter)
 		}
 	})

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ func TestConditionEventuallyWithT(t *testing.T) {`
`238`	`238`	`Len(t, mock.errors, expectedErrors, "expected 2 errors from the condition, and 2 additional errors from Eventually")`
`239`	`239`
`240`	`240`	`expectedCalls := int(testTimeout / testTick)`
`241`		`- if counter != expectedCalls && counter != expectedCalls+1 { // it may be 5 or 6 depending on how the test schedules`
	`241`	`+ if counter < expectedCalls-1 \|\| counter > expectedCalls+1 { // it may be 4, 5 or 6 depending on how the test schedules`
`242`	`242`	`t.Errorf("expected %d calls to the condition, but got %d", expectedCalls, counter)`
`243`	`243`	`}`
`244`	`244`	`})`