Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ff983b9c42bc9fbf91556e191cc8efb585c16908
Choose a base ref
...
head repository: golang/crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 74369b46fc6756741c016591724fd1cb8e26845f
Choose a head ref
  • 11 commits
  • 18 files changed
  • 10 contributors

Commits on Jan 22, 2019

  1. blake2b: fix comments in grammar

    Change-Id: Idacdbf5ee847be6e21ecce0c9d41818e643c4835
    GitHub-Last-Rev: bf1a719
    GitHub-Pull-Request: #73
    Reviewed-on: https://go-review.googlesource.com/c/158837
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    rasa authored and bradfitz committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    6407268 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. crypto/ssh/knownhosts: fix out-of-date documentation for checkAddr

    Change-Id: I03e9cf1ee82b38f15232a48992bae0234bd51f1a
    GitHub-Last-Rev: fd7b92d
    GitHub-Pull-Request: #71
    Reviewed-on: https://go-review.googlesource.com/c/156878
    Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
    Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    jaytaylor authored and hanwen committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    057139c View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. ssh/terminal: support ^N and ^P

    This makes it possible to navigate the history without leaving
    the home row on the keyboard.
    
    Change-Id: Id24c43f8eb6090520ab37bf8126264901b70c489
    Reviewed-on: https://go-review.googlesource.com/c/33618
    Run-TryBot: Matt Layher <mdlayher@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Matt Layher <mdlayher@gmail.com>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    mibk authored and bradfitz committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    c7b33c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. pkcs12: add a DecodeAll method

    Addition of a DecodeAll function as it was mentioned in #14015.
    
    This solves a need many people seem to have, where there is no effective
    way loading PKCS12 files that contain more than one certificate and one
    private key.
    
    The utility functions used by Decode are all internal, which makes
    implementing this on the user-side tedious, hence the suggestion of
    providing a more liberal version of the function: DecodeAll.
    
    Fixes golang/go#14015
    
    Change-Id: I03c541553b6cb488c2c59d39575342a43136e592
    GitHub-Last-Rev: 05f6847
    GitHub-Pull-Request: #38
    Reviewed-on: https://go-review.googlesource.com/c/105876
    Reviewed-by: Adam Shannon <adamkshannon@gmail.com>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    ereOn authored and bradfitz committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    bf88e3f View commit details
    Browse the repository at this point in the history
  2. Revert "pkcs12: add a DecodeAll method"

    This reverts commit bf88e3f.
    
    Reason for revert: https://go-review.googlesource.com/c/crypto/+/105876/12#message-0dad31af2b487e895ee6926ded82f85ac81c74f8
    
    Updates golang/go#14015
    
    Change-Id: I8eb3ed73f78ac11841ad73435bba00a330d59b58
    Reviewed-on: https://go-review.googlesource.com/c/160257
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    FiloSottile committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    54b0dbb View commit details
    Browse the repository at this point in the history
  3. pkcs12: note that this package is frozen and point to an alternative

    Change-Id: Ia4d87b816f176194cd9e37efb42e273d678a84b7
    Reviewed-on: https://go-review.googlesource.com/c/160259
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    FiloSottile committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    ccddf37 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. acme: support IP address authorization type

    This change extends the Client to allow users request
    certificate issuance for IP addresses.
    
    See the ACME spec extension for details about IP address
    identifiers: https://tools.ietf.org/html/draft-ietf-acme-ip.
    
    Change-Id: I92a8d8fae048487168906c14892c6dd33af10c07
    Reviewed-on: https://go-review.googlesource.com/c/160197
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
    Alex Vaghin committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    b01c7a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. pkcs12: add a note suggesting ToPEM for multiple certificates/keys

    Updates golang/go#14015
    
    Change-Id: Iffe73540c5d74e4b3d0664035a1bdce5b47663ee
    Reviewed-on: https://go-review.googlesource.com/c/160258
    Reviewed-by: Bryan C. Mills <bcmills@google.com>
    FiloSottile committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    9c16a03 View commit details
    Browse the repository at this point in the history
  2. all: fix ineffectual assignments

    audited using ineffassign tool from
    github.com/gordonklaus/ineffassign
    go generate does not generate any changes
    
    Change-Id: Iabbec9ec1aae39081289d503d79fd7b4caadf17b
    GitHub-Last-Rev: acd17cc
    GitHub-Pull-Request: #70
    Reviewed-on: https://go-review.googlesource.com/c/155942
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    mikecook authored and FiloSottile committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    b8fe169 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. curve25519: mask high bit when loading group point

    Comparison against BoringSSL-generated test vectors showed mismatches
    with the pure Go implementation of curve25519. The problem was narrowed
    down to a missing mask in feFromBytes(). This diff adds the mask,
    bringing this back in line with the reference implementation and
    RFC 7748:
    
        When receiving such an array, implementations of X25519 (but not
        X448) MUST mask the most significant bit in the final byte.  This is
        done to preserve compatibility with point formats that reserve the
        sign bit for use in other protocols and to increase resistance to
        implementation fingerprinting.
    
    Fixes golang/go#30095
    
    Change-Id: If7efc0e2acd6efb761d6e3cb89cec359d7d81cb1
    Reviewed-on: https://go-review.googlesource.com/c/161257
    Run-TryBot: Filippo Valsorda <filippo@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    mmcloughlin authored and josharian committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    193df9c View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. internal/chacha20: add SIMD implementation on arm64

    Inspired by Vectorization of ChaCha Stream Cipher
    https://eprint.iacr.org/2013/759.pdf
    
    name            old time/op    new time/op    delta
    ChaCha20/32        690ns ± 0%     872ns ± 0%   +26.38%  (p=0.000 n=10+10)
    ChaCha20/63        750ns ± 0%     987ns ± 0%   +31.53%  (p=0.000 n=10+10)
    ChaCha20/64        674ns ± 0%     879ns ± 0%   +30.42%  (p=0.000 n=8+10)
    ChaCha20/256      2.28µs ± 0%    0.82µs ± 0%   -64.13%  (p=0.000 n=10+10)
    ChaCha20/1024     8.64µs ± 0%    2.92µs ± 0%   -66.15%  (p=0.000 n=9+9)
    ChaCha20/1350     11.9µs ± 0%     4.5µs ± 0%   -62.51%  (p=0.000 n=10+8)
    ChaCha20/65536     554µs ± 0%     181µs ± 0%   -67.33%  (p=0.000 n=10+10)
    
    name            old speed      new speed      delta
    ChaCha20/32     46.3MB/s ± 0%  36.7MB/s ± 0%   -20.87%  (p=0.000 n=10+9)
    ChaCha20/63     83.9MB/s ± 0%  63.8MB/s ± 0%   -23.97%  (p=0.000 n=10+10)
    ChaCha20/64     94.9MB/s ± 0%  72.8MB/s ± 0%   -23.31%  (p=0.000 n=10+10)
    ChaCha20/256     112MB/s ± 0%   312MB/s ± 0%  +178.74%  (p=0.000 n=10+10)
    ChaCha20/1024    119MB/s ± 0%   350MB/s ± 0%  +195.31%  (p=0.000 n=10+9)
    ChaCha20/1350    114MB/s ± 0%   303MB/s ± 0%  +166.73%  (p=0.000 n=8+8)
    ChaCha20/65536   118MB/s ± 0%   362MB/s ± 0%  +206.12%  (p=0.000 n=10+10)
    
    Updates golang/go#22809
    Change-Id: I487487faa2ae4ff29de6fd8eb1317740c2939c10
    Reviewed-on: https://go-review.googlesource.com/c/107628
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    mengzhuo authored and FiloSottile committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    74369b4 View commit details
    Browse the repository at this point in the history
Loading