Make FLV video seekable by a seekMap.#7378
Merged
kim-vde merged 5 commits intogoogle:dev-v2from Oct 13, 2020
Merged
Conversation
Contributor
|
Any news for the tests? |
Contributor
|
Is this ready to be reviewed? I see that some parts of the code are commented. |
Contributor
Author
|
Just checked in. Now it's ready to be reviewed. Thanks. |
kim-vde
added a commit
that referenced
this pull request
Oct 13, 2020
Otherwise, some extractor tests are seeking without making sure that the extractor has retrieved the formats. This is needed for PR Issue: #7378. PiperOrigin-RevId: 335934326
Contributor
|
I cleaned the pull request and merged the part about seeking in FLV files. I didn't merge the part about parsing the frame rate and adding it to the format because:
|
ojw28
pushed a commit
that referenced
this pull request
Oct 21, 2020
Otherwise, some extractor tests are seeking without making sure that the extractor has retrieved the formats. This is needed for PR Issue: #7378. PiperOrigin-RevId: 335934326
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested and works fine.