Change Dagger generated Factory/MembersInjector constructors from public to private.

These classes have public `create` methods that should be used instead of the constructors. This is part of an effort to minimize the public API of our generated classes to align with requirements for Kotlin codegen.

RELNOTES=Change Dagger generated Factory/MembersInjector constructors from public to private.
PiperOrigin-RevId: 764757731

Author: bcorso

dagger-compiler/main/java/dagger/internal/codegen/writing/FactoryGenerator.java

@@ -181,7 +181,7 @@ private static XClassName instanceHolderClassName(ContributionBinding binding) {
     return generatedClassNameForBinding(binding).nestedClass("InstanceHolder");
   }
 
-  // public FooModule_ProvidesFooFactory(
+  // private FooModule_ProvidesFooFactory(
   //     FooModule module,
   //     Provider<Bar> barProvider,
   //     Provider<Baz> bazProvider) {
@@ -190,8 +190,7 @@ private static XClassName instanceHolderClassName(ContributionBinding binding) {
   //   this.bazProvider = bazProvider;
   // }
   private XFunSpec constructorMethod(FactoryFields factoryFields) {
-    // TODO(bcorso): Make the constructor private?
-    XFunSpecs.Builder constructor = constructorBuilder().addModifiers(PUBLIC);
+    XFunSpecs.Builder constructor = constructorBuilder().addModifiers(PRIVATE);
     factoryFields
         .getAll()
         .forEach(

dagger-compiler/main/java/dagger/internal/codegen/writing/MembersInjectorGenerator.java

@@ -44,6 +44,7 @@
 import static dagger.internal.codegen.xprocessing.XTypeElements.typeVariableNames;
 import static dagger.internal.codegen.xprocessing.XTypeNames.membersInjectorOf;
 import static javax.lang.model.element.Modifier.FINAL;
+import static javax.lang.model.element.Modifier.PRIVATE;
 import static javax.lang.model.element.Modifier.PUBLIC;
 import static javax.lang.model.element.Modifier.STATIC;
 
@@ -227,7 +228,7 @@ private static XCodeBlock copyInstance(
     return useObject ? XCodeBlock.of("(%L)", instance) : instance;
   }
 
-  // MyClass(
+  // private MyClass_MembersInjector(
   //     Provider<Dep1> dep1Provider,
   //     Provider<Dep2> dep2Provider,
   //     // Note: The raw type can happen if Dep3 is injected in a super type and not accessible to
@@ -241,7 +242,7 @@ private static XCodeBlock copyInstance(
   private XFunSpec constructor(ImmutableMap<DependencyRequest, XPropertySpec> frameworkFields) {
     ImmutableList<XParameterSpec> parameters = constructorParameters(frameworkFields);
     return constructorBuilder()
-        .addModifiers(PUBLIC)
+        .addModifiers(PRIVATE)
         .addParameters(parameters)
         .addCode(
             parameters.stream()

javatests/dagger/functional/kotlinsrc/membersinject/MembersInjectTest.kt

@@ -79,7 +79,7 @@ class MembersInjectTest {
   fun testNonRequestedMembersInjector() {
     val child = NonRequestedChild()
     val provider = Provider { "field!" }
-    val injector = NonRequestedChild_MembersInjector(provider)
+    val injector = NonRequestedChild_MembersInjector.create(provider)
     injector.injectMembers(child)
     assertThat(child.t).isEqualTo("field!")
   }

javatests/dagger/functional/membersinject/MembersInjectTest.java

@@ -90,7 +90,8 @@ public String get() {
             return "field!";
           }
         };
-    MembersInjector<NonRequestedChild> injector = new NonRequestedChild_MembersInjector(provider);
+    MembersInjector<NonRequestedChild> injector =
+        NonRequestedChild_MembersInjector.create(provider);
     injector.injectMembers(child);
     assertThat(child.t).isEqualTo("field!");
   }

javatests/dagger/internal/codegen/ModuleFactoryGeneratorTest.java

@@ -392,7 +392,7 @@ public void kotlinNullableProvides() {
                           + " Factory<String> {",
                       "  private final TestModule module;",
                       "",
-                      "  public TestModule_ProvideStringFactory(TestModule module) {",
+                      "  private TestModule_ProvideStringFactory(TestModule module) {",
                       "    this.module = module;",
                       "  }",
                       "",

javatests/dagger/internal/codegen/goldens/AssistedFactoryTest_testFactoryGeneratorDuplicatedParamNames_DEFAULT_MODE_test.Foo_Factory

@@ -25,7 +25,7 @@ import javax.annotation.processing.Generated;
 public final class Foo_Factory {
   private final Provider<Bar> argProvider;
 
-  public Foo_Factory(Provider<Bar> argProvider) {
+  private Foo_Factory(Provider<Bar> argProvider) {
     this.argProvider = argProvider;
   }
 

javatests/dagger/internal/codegen/goldens/AssistedFactoryTest_testFactoryGeneratorDuplicatedParamNames_FAST_INIT_MODE_test.Foo_Factory

@@ -25,7 +25,7 @@ import javax.annotation.processing.Generated;
 public final class Foo_Factory {
   private final Provider<Bar> argProvider;
 
-  public Foo_Factory(Provider<Bar> argProvider) {
+  private Foo_Factory(Provider<Bar> argProvider) {
     this.argProvider = argProvider;
   }
 

javatests/dagger/internal/codegen/goldens/InjectConstructorFactoryGeneratorTest_basicNameCollision_test.InjectConstructor_Factory

@@ -26,7 +26,7 @@ import javax.annotation.processing.Generated;
 public final class InjectConstructor_Factory implements Factory<InjectConstructor> {
   private final Provider<other.pkg.Factory> factoryProvider;
 
-  public InjectConstructor_Factory(Provider<other.pkg.Factory> factoryProvider) {
+  private InjectConstructor_Factory(Provider<other.pkg.Factory> factoryProvider) {
     this.factoryProvider = factoryProvider;
   }
 

javatests/dagger/internal/codegen/goldens/InjectConstructorFactoryGeneratorTest_boundedGenerics_test.GenericClass_Factory

@@ -31,7 +31,8 @@ public final class GenericClass_Factory<A extends Number & Comparable<A>, B exte
 
   private final Provider<C> cProvider;
 
-  public GenericClass_Factory(Provider<A> aProvider, Provider<B> bProvider, Provider<C> cProvider) {
+  private GenericClass_Factory(Provider<A> aProvider, Provider<B> bProvider,
+      Provider<C> cProvider) {
     this.aProvider = aProvider;
     this.bProvider = bProvider;
     this.cProvider = cProvider;

javatests/dagger/internal/codegen/goldens/InjectConstructorFactoryGeneratorTest_fieldAndMethodGenerics_test.GenericClass_Factory

@@ -28,7 +28,7 @@ public final class GenericClass_Factory<A, B> implements Factory<GenericClass<A,
 
   private final Provider<B> bProvider;
 
-  public GenericClass_Factory(Provider<A> aProvider, Provider<B> bProvider) {
+  private GenericClass_Factory(Provider<A> aProvider, Provider<B> bProvider) {
     this.aProvider = aProvider;
     this.bProvider = bProvider;
   }