From 158f3aaed71230408e317e02141a57bcf527c2af Mon Sep 17 00:00:00 2001 From: Leo Sale Date: Thu, 23 Nov 2023 10:42:56 +0100 Subject: [PATCH 1/2] Fix secondary rate limits URL --- github/github.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/github/github.go b/github/github.go index 9c1bf084d35..be7d5423bfa 100644 --- a/github/github.go +++ b/github/github.go @@ -1133,7 +1133,7 @@ func (ae *AcceptedError) Is(target error) bool { } // AbuseRateLimitError occurs when GitHub returns 403 Forbidden response with the -// "documentation_url" field value equal to "https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits". +// "documentation_url" field value equal to "https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits". type AbuseRateLimitError struct { Response *http.Response // HTTP response that caused this error Message string `json:"message"` // error message @@ -1259,7 +1259,8 @@ func CheckResponse(r *http.Response) error { } case r.StatusCode == http.StatusForbidden && (strings.HasSuffix(errorResponse.DocumentationURL, "#abuse-rate-limits") || - strings.HasSuffix(errorResponse.DocumentationURL, "#secondary-rate-limits")): + strings.HasSuffix(errorResponse.DocumentationURL, "#secondary-rate-limits") || + strings.HasSuffix(errorResponse.DocumentationURL, "#about-secondary-rate-limits")): abuseRateLimitError := &AbuseRateLimitError{ Response: errorResponse.Response, Message: errorResponse.Message, From adf78914d5b97934795f0be7c2fb77c480884e58 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Sal=C3=A9?= Date: Fri, 24 Nov 2023 15:16:33 +0100 Subject: [PATCH 2/2] Update github/github.go Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com> --- github/github.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/github/github.go b/github/github.go index be7d5423bfa..c2706b0f10a 100644 --- a/github/github.go +++ b/github/github.go @@ -1259,8 +1259,7 @@ func CheckResponse(r *http.Response) error { } case r.StatusCode == http.StatusForbidden && (strings.HasSuffix(errorResponse.DocumentationURL, "#abuse-rate-limits") || - strings.HasSuffix(errorResponse.DocumentationURL, "#secondary-rate-limits") || - strings.HasSuffix(errorResponse.DocumentationURL, "#about-secondary-rate-limits")): + strings.HasSuffix(errorResponse.DocumentationURL, "secondary-rate-limits")): abuseRateLimitError := &AbuseRateLimitError{ Response: errorResponse.Response, Message: errorResponse.Message,