Demo: auto-select offline copy of asset after storing

[beaufortfrancois]

FIX: #996

[joeyparrish]

Looks great otherwise!

[joeyparrish]

Since this returns a value now, please update the annotations with @return {!Promise}

[beaufortfrancois]

Done in e3af7f1

[beaufortfrancois]

@joeyparrish We should be good now ;)

[joeyparrish]

Thanks! Doing a test pass on the build bot now.

[shaka-bot]

Test Failure:

Generating Closure dependencies...
Running Closure linter...
195 files checked, no errors found.
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
Running htmlhint...

Config loaded: /var/lib/jenkins/jobs/Manual PR Test (local-tests)/workspace/.htmlhintrc

Config loaded: /var/lib/jenkins/jobs/Manual PR Test (local-tests)/workspace/.htmlhintrc

Config loaded: /var/lib/jenkins/jobs/Manual PR Test (local-tests)/workspace/.htmlhintrc

Scanned 3 files, no errors found (42 ms).
Checking that the build files are complete...
Checking the tests for type errors...
/var/lib/jenkins/jobs/Manual PR Test (local-tests)/workspace/demo/offline_section.js:184: ERROR - Violation: Using "Element.children" is not allowed: use Node.childNodes instead
for (var i = 0; i < group.children.length; i++) {
^^^^^^^^^^^^^^

/var/lib/jenkins/jobs/Manual PR Test (local-tests)/workspace/demo/offline_section.js:185: ERROR - Violation: Using "Element.children" is not allowed: use Node.childNodes instead
var option = group.children[i];
^^^^^^^^^^^^^^

2 error(s), 0 warning(s), 96.1% typed
Build failed
END-BUILD: FAILURE

[joeyparrish]

There are a couple of build failures about children vs childElements (children attribute is not present on all platforms we support).

I also did some manual testing of your change locally, and it's not working correctly for me. After storing something, the store button goes gray and the help text says The asset is stored offline. Checkout the "Offline" section in the "Asset" list. The URI hash has changed to asset=offline:0, but the original asset is still selected in the drop-down list itself. Perhaps you're missing some call to update the list to match?

[joeyparrish]

Sorry, not childElements. I meant to say childNodes.

[joeyparrish]

And now it's working for me locally. Maybe I had something cached. Sorry for the noise.

[beaufortfrancois]

I believe it is now fixed. @joeyparrish WDYT?

[joeyparrish]

Looks good. Running tests now. Thanks!

[shaka-bot]

All tests passed!

[joeyparrish]

Merged. Thanks for your contribution!

[joeyparrish]

I am planning to cherry-pick this to v2.2.2.

[joeyparrish]

This has been cherry-picked and will be released in v2.2.2.