Load without errors in IE 9

[spiralman]

This ports our fixes back into the Shaka source.

@ustudio/dev Can somebody review this, before I open a PR back to the upstream source?

[joeyparrish]

I think this doesn't need to be quoted. Dot notation should work fine, since closure will not rename browser-built-ins and thingThatExists.nonExistentMember will be undefined, but not cause an exception. Please correct me if I missed something.

[spiralman]

You're right. For some reason, I thought IE had tripped up when I didn't quote it, but I can't reproduce that behavior, so there must have been something else wrong.

[joeyparrish]

Ping! Please fix, should not need to be quoted.

[joeyparrish]

Also, please read CONTRIBUTING and follow the instructions there. You'll need to sign a license agreement and add yourself to AUTHORS & CONTRIBUTORS. Thanks!

[spiralman]

@joeyparrish Thanks for the feedback. WRT CONTRIBUTORS/AUTHORS, since I'm doing this for uStudio I need to wait for somebody else to agree to the Corporate CLA, so I left it out of the PR for now.

I actually intended to open this against our fork, so one of our other devs could review it, so you didn't have to deal with the fiddly stuff, but I guess GitHub doesn't allow that.

[joeyparrish]

Sounds good on the CLA. Just ping me when you're ready for me to take another look, and thanks for your contribution!

[spiralman]

@joeyparrish Your comments should be addressed, other than the contributor stuff. I'll update those files and ping you again when we get that sorted out on our end.

Thanks again!

[spiralman]

@joeyparrish We finally got the CLA taken care of, so I've pushed the new AUTHORS and CONTRIBUTORS file, so it should be GTG.

[joeyparrish]

Please use single quotes on these ready states. I was breaking our own style rules in the original. :-)

[joeyparrish]

If you can fix the quoted console['assert'] and change support.js's double quotes to single quotes, everything else looks good to me. Thanks!

[joeyparrish]

I spoke too soon. You'll also need to fix the errors reported by the compiler & linter. Just run ./build/all.sh to see them:

./build/all.sh
0 error(s), 0 warning(s), 98.1% typed
----- FILE : /var/lib/jenkins/jobs/Shaka Player GitHub PR Build/workspace/lib/debug/asserts.js -----
Line 46, E:0220: No docs found for member 'shaka.asserts.patchAssert_'
Line 55, E:0011: Missing semicolon after function assigned to a variable
----- FILE : /var/lib/jenkins/jobs/Shaka Player GitHub PR Build/workspace/lib/debug/log.js -----
Line 72, E:0220: No docs found for member 'shaka.log.patchConsole_'
Line 82, E:0011: Missing semicolon after function assigned to a variable
Found 4 errors, including 0 new errors, in 2 files (107 files OK).

[spiralman]

@joeyparrish Sorry about all the back and forth, but hopefully I have it all fixed now.

[joeyparrish]

You can drop the "type" annotation here.

[joeyparrish]

Looks great, just one small tweak.

[spiralman]

Ok, @joeyparrish I think I have it.

[joeyparrish]

I'm so sorry. I know closure is new for lots of people. I meant that only @Private is needed for a private function with no arguments and no return value. We don't generally use @type for functions unless it's a callback.

[spiralman]

@joeyparrish No problem; back to you.

[joeyparrish]

Looks good to me. I'm going to see if the CI system I'm experimenting with will pick this up and test it: ok to test

If not, I'll give it a manual test run and merge later today. Thanks for your hard work on this!

[spiralman]

No problem; thanks for sticking with all the back and forth!

[joeyparrish]

CI isn't working yet, but I ran the tests manually and everything's passing. Thanks for the contribution!