Correct instantiation of HttpVideoSource with no content protection.#292
Merged
joeyparrish merged 1 commit intoshaka-project:masterfrom Feb 27, 2016
Merged
Correct instantiation of HttpVideoSource with no content protection.#292joeyparrish merged 1 commit intoshaka-project:masterfrom
joeyparrish merged 1 commit intoshaka-project:masterfrom
Conversation
Passing an empty config object is no longer acceptable because the keySystem property is mandatory on drmConfig objects. Also modified HttpVideoSource constructor comment so that the drmConfig comments are the single source of truth regarding well-formed drmConfig objects.
Member
|
Looks good, but be warned: HttpVideoSource was originally used for testing purposes. We've deprecated it and no equivalent is planned for v2. |
joeyparrish
added a commit
that referenced
this pull request
Feb 27, 2016
Correct instantiation of HttpVideoSource with no content protection.
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing an empty config object is no longer acceptable because the
keySystem property is mandatory on drmConfig objects.
Also modified HttpVideoSource constructor comment so that the drmConfig
comments are the single source of truth regarding well-formed drmConfig
objects.