Fix of TTML bug for white-space div with no content#650
Merged
joeyparrish merged 2 commits intoshaka-project:masterfrom Jan 10, 2017
TobbeEdgeware:fix-ttml-whitespace-in-empty-div
Merged
Fix of TTML bug for white-space div with no content#650joeyparrish merged 2 commits intoshaka-project:masterfrom TobbeEdgeware:fix-ttml-whitespace-in-empty-div
joeyparrish merged 2 commits intoshaka-project:masterfrom
TobbeEdgeware:fix-ttml-whitespace-in-empty-div
Conversation
Member
|
Looks good to me. I'll run it through the build bot. |
Collaborator
|
Testing in progress... |
Collaborator
|
All tests passed! |
Member
|
Thanks! |
joeyparrish
pushed a commit
that referenced
this pull request
Jan 19, 2017
A div element with no timing and only whitespace should be considered empty. Closes #646
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #646.
A div element with no timing and only whitespace should be considered empty.
Added a test that checks this.