Improve store/delete button UX on mobile#995
Merged
joeyparrish merged 2 commits intoshaka-project:masterfrom Aug 29, 2017
Merged
Improve store/delete button UX on mobile#995joeyparrish merged 2 commits intoshaka-project:masterfrom
joeyparrish merged 2 commits intoshaka-project:masterfrom
Conversation
joeyparrish
reviewed
Aug 28, 2017
| else if (button.disabled) | ||
| button.title = 'Selected asset is already stored offline'; | ||
| helpText.textContent = 'The asset is stored offline. ' + | ||
| 'Checkout the "Offline" section in the "Asset" list'; |
joeyparrish
approved these changes
Aug 28, 2017
Member
|
Running tests on the build bot now. |
Collaborator
|
All tests passed! |
Member
|
Cherry-picked to v2.2.1 |
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
titleonstoreDeletebutton in the demo is not helpful on a mobile device. This CL improves it by moving it in a separate<span>element.