This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: only set unset fields if they are query params#1130
Merged
software-dov merged 3 commits intogoogleapis:masterfrom Jan 18, 2022
Merged
fix: only set unset fields if they are query params#1130software-dov merged 3 commits intogoogleapis:masterfrom
software-dov merged 3 commits intogoogleapis:masterfrom
Conversation
software-dov
requested review from
a team,
atulep,
busunkim96,
kbandes and
vam-google
software-dov
force-pushed
the
required-path-params
branch
from
9e8fc1e to
00919dd
Compare
busunkim96
reviewed
Jan 14, 2022
gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
Show resolved
Hide resolved
busunkim96
approved these changes
Jan 14, 2022
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.