This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Merged
Conversation
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
vchudnov-g
approved these changes
Apr 14, 2023
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
See note about a possible workaround, or filing a follow-up issue. LGTM otherwise.
gapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2
Outdated
Show resolved
Hide resolved
vchudnov-g
reviewed
Apr 14, 2023
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
Do we need to do this for ads templates as well?
Contributor
Author
|
These changes are specific to async and Ads doesn't support async so no changes are needed for Ads. There is a separate issue to track adding async support for Ads. googleapis/google-cloud-python#16458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #1644
See #1174 (comment) for background on why
# pragma: no branchis used.