From 875a1ecc636a141e7f8fece99a3c7ef7de426e92 Mon Sep 17 00:00:00 2001 From: Victor Chudnovsky Date: Fri, 12 Aug 2022 13:18:12 -0700 Subject: [PATCH] feat: When requesting numeric enums in responses, also send them in requests --- .../%version/%sub/services/%service/transports/rest.py.j2 | 8 ++++---- .../%sub/services/%service/transports/rest.py.j2 | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/rest.py.j2 b/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/rest.py.j2 index feaa18f44b..2240ffbbe3 100644 --- a/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/rest.py.j2 +++ b/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/rest.py.j2 @@ -318,12 +318,12 @@ class {{service.name}}RestTransport({{service.name}}Transport): body = {% if body_spec == '*' -%} {{method.input.ident}}.to_json( {{method.input.ident}}(transcoded_request['body']), - {%- else -%} + {% else -%} {{method.input.fields[body_spec].type.ident}}.to_json( {{method.input.fields[body_spec].type.ident}}(transcoded_request['body']), - {%- endif %}{# body_spec == "*" #} + {% endif %}{# body_spec == "*" #} including_default_value_fields=False, - use_integers_for_enums=False + use_integers_for_enums={{ opts.rest_numeric_enums }} ) {%- endif %}{# body_spec #} @@ -334,7 +334,7 @@ class {{service.name}}RestTransport({{service.name}}Transport): query_params = json.loads({{method.input.ident}}.to_json( {{method.input.ident}}(transcoded_request['query_params']), including_default_value_fields=False, - use_integers_for_enums=False + use_integers_for_enums={{ opts.rest_numeric_enums }} )) {% if method.input.required_fields %} diff --git a/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2 b/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2 index ea1d45af0f..2c94a9f820 100644 --- a/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2 +++ b/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2 @@ -326,12 +326,12 @@ class {{service.name}}RestTransport({{service.name}}Transport): body = {% if body_spec == '*' -%} {{method.input.ident}}.to_json( {{method.input.ident}}(transcoded_request['body']), - {%- else -%} + {% else -%} {{method.input.fields[body_spec].type.ident}}.to_json( {{method.input.fields[body_spec].type.ident}}(transcoded_request['body']), - {%- endif %}{# body_spec == "*" #} + {% endif %}{# body_spec == "*" #} including_default_value_fields=False, - use_integers_for_enums=False + use_integers_for_enums={{ opts.rest_numeric_enums }} ) {%- endif %}{# body_spec #} @@ -342,7 +342,7 @@ class {{service.name}}RestTransport({{service.name}}Transport): query_params = json.loads({{method.input.ident}}.to_json( {{method.input.ident}}(transcoded_request['query_params']), including_default_value_fields=False, - use_integers_for_enums=False + use_integers_for_enums={{ opts.rest_numeric_enums }} )) {% if method.input.required_fields %}