From 442fbfa31dd197aab4513a51a40440579e14a423 Mon Sep 17 00:00:00 2001 From: henribru <6639509+henribru@users.noreply.github.com> Date: Thu, 13 Oct 2022 20:21:39 +0200 Subject: [PATCH] fix: add context manager return types --- .../%name/%version/%sub/services/%service/client.py.j2 | 2 +- .../%name_%version/%sub/services/%service/client.py.j2 | 2 +- .../google/cloud/asset_v1/services/asset_service/client.py | 2 +- .../iam/credentials_v1/services/iam_credentials/client.py | 2 +- .../google/cloud/eventarc_v1/services/eventarc/client.py | 2 +- .../cloud/logging_v2/services/config_service_v2/client.py | 2 +- .../cloud/logging_v2/services/logging_service_v2/client.py | 2 +- .../cloud/logging_v2/services/metrics_service_v2/client.py | 2 +- .../redis/google/cloud/redis_v1/services/cloud_redis/client.py | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 b/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 index 4666ab3e0f..e5a3f9f06d 100644 --- a/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 +++ b/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2 @@ -175,7 +175,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta): """ return self._transport - def __enter__(self): + def __enter__(self) -> "{{ service.client_name }}": return self def __exit__(self, type, value, traceback): diff --git a/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 b/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 index be54b73db8..98d4a1dd4e 100644 --- a/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 +++ b/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 @@ -376,7 +376,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta): {% endif %} {% endfor %} - def __enter__(self): + def __enter__(self) -> "{{ service.client_name }}": return self def __exit__(self, type, value, traceback): diff --git a/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py b/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py index 7d4ee39dac..6b5bc5dd04 100755 --- a/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py +++ b/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py @@ -1831,7 +1831,7 @@ def sample_analyze_iam_policy_longrunning(): # Done; return the response. return response - def __enter__(self): + def __enter__(self) -> "AssetServiceClient": return self def __exit__(self, type, value, traceback): diff --git a/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/client.py b/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/client.py index 6f6e7c1a96..d8b401dc89 100755 --- a/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/client.py +++ b/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/client.py @@ -956,7 +956,7 @@ def sample_sign_jwt(): # Done; return the response. return response - def __enter__(self): + def __enter__(self) -> "IAMCredentialsClient": return self def __exit__(self, type, value, traceback): diff --git a/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/client.py b/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/client.py index 64156b8d95..94d75497e2 100755 --- a/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/client.py +++ b/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/client.py @@ -1032,7 +1032,7 @@ def sample_delete_trigger(): # Done; return the response. return response - def __enter__(self): + def __enter__(self) -> "EventarcClient": return self def __exit__(self, type, value, traceback): diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/client.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/client.py index 393c816a60..d144aa6549 100755 --- a/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/client.py +++ b/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/client.py @@ -2829,7 +2829,7 @@ def sample_update_cmek_settings(): # Done; return the response. return response - def __enter__(self): + def __enter__(self) -> "ConfigServiceV2Client": return self def __exit__(self, type, value, traceback): diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/client.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/client.py index 899efe1781..2dd6317d0b 100755 --- a/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/client.py +++ b/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/client.py @@ -1111,7 +1111,7 @@ def request_generator(): # Done; return the response. return response - def __enter__(self): + def __enter__(self) -> "LoggingServiceV2Client": return self def __exit__(self, type, value, traceback): diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/client.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/client.py index 2ad30449f7..a91276fc4e 100755 --- a/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/client.py +++ b/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/client.py @@ -959,7 +959,7 @@ def sample_delete_log_metric(): metadata=metadata, ) - def __enter__(self): + def __enter__(self) -> "MetricsServiceV2Client": return self def __exit__(self, type, value, traceback): diff --git a/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/client.py b/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/client.py index 25f00e1b77..d2f3366316 100755 --- a/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/client.py +++ b/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/client.py @@ -1594,7 +1594,7 @@ def sample_delete_instance(): # Done; return the response. return response - def __enter__(self): + def __enter__(self) -> "CloudRedisClient": return self def __exit__(self, type, value, traceback):