Skip to content

Commit 2a249ce

Browse files
authored
fix(generator): handle preview version pkg name (#3511)
1 parent 26ea889 commit 2a249ce

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

google-api-go-generator/gen.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,9 @@ func renameVersion(version string) string {
467467
if version == "alpha" || version == "beta" {
468468
return "v0." + version
469469
}
470+
if version == "preview" {
471+
return "v1.preview"
472+
}
470473
if m := oddVersionRE.FindStringSubmatch(version); m != nil {
471474
return m[1] + "/" + m[2]
472475
}

google-api-go-generator/gen_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,18 @@ func TestRenameVersion(t *testing.T) {
237237
version: "my_api_v1.2",
238238
want: "my_api/v1.2",
239239
},
240+
{
241+
version: "alpha",
242+
want: "v0.alpha",
243+
},
244+
{
245+
version: "beta",
246+
want: "v0.beta",
247+
},
248+
{
249+
version: "preview",
250+
want: "v1.preview",
251+
},
240252
}
241253
for _, test := range tests {
242254
if got := renameVersion(test.version); got != test.want {

0 commit comments

Comments
 (0)