From 7b0a2ef4999f3ba1957f3c0335032a79032073f3 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Mon, 16 Jun 2025 19:00:59 -0700 Subject: [PATCH 1/4] fix broken type --- src/generator/disclaimer.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/generator/disclaimer.ts b/src/generator/disclaimer.ts index dcb290db32f..132abe4c94e 100644 --- a/src/generator/disclaimer.ts +++ b/src/generator/disclaimer.ts @@ -52,12 +52,15 @@ export const gfs = { */ export async function main() { const res = await request({url: libraryListUrl}); - const disclaimers = res.data.map(lib => { - return { - api: lib.api_id.split('.')[0], - package: lib.distribution_name, - }; - }); + // console.log(typeof res.data) + const disclaimers = JSON.parse(res.data as unknown as string).map( + (lib: LibraryMetadata) => { + return { + api: lib.api_id.split('.')[0], + package: lib.distribution_name, + }; + }, + ); gfs.writeFileSync('./disclaimers.json', JSON.stringify(disclaimers, null, 2)); } From 12e9cd737a7b12dce41220f2d4fb7ad7b0b31ac2 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Mon, 16 Jun 2025 19:02:14 -0700 Subject: [PATCH 2/4] remove logging --- src/generator/disclaimer.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/generator/disclaimer.ts b/src/generator/disclaimer.ts index 132abe4c94e..faf7132584e 100644 --- a/src/generator/disclaimer.ts +++ b/src/generator/disclaimer.ts @@ -52,7 +52,6 @@ export const gfs = { */ export async function main() { const res = await request({url: libraryListUrl}); - // console.log(typeof res.data) const disclaimers = JSON.parse(res.data as unknown as string).map( (lib: LibraryMetadata) => { return { From 45cb72217550bf11f0ea2420c8fa7aafe3732131 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Tue, 17 Jun 2025 18:27:04 -0700 Subject: [PATCH 3/4] update test --- test/test.disclaimer.ts | 39 +++++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/test/test.disclaimer.ts b/test/test.disclaimer.ts index f8c541e3eb4..b526f634980 100644 --- a/test/test.disclaimer.ts +++ b/test/test.disclaimer.ts @@ -19,24 +19,27 @@ import * as nock from 'nock'; import {URL} from 'url'; import * as disclaimer from '../src/generator/disclaimer'; -const mockResponse = [ +const mockResponse = `[ { - name: 'asset', - name_pretty: 'Asset Inventory', - product_documentation: - 'https://cloud.google.com/resource-manager/docs/cloud-asset-inventory/overview', - client_documentation: 'https://googleapis.dev/nodejs/asset/latest', - issue_tracker: 'https://issuetracker.google.com/savedsearches/559757', - release_level: 'ga', - language: 'nodejs', - repo: 'googleapis/nodejs-asset', - distribution_name: '@google-cloud/asset', - api_id: 'cloudasset.googleapis.com', - requires_billing: true, - support_documentation: - 'https://cloud.google.com/resource-manager/docs/getting-support', - }, -]; + "name": "cloudasset", + "name_pretty": "Asset Inventory", + "product_documentation": "https://cloud.google.com/resource-manager/docs/cloud-asset-inventory/overview", + "client_documentation": "https://cloud.google.com/nodejs/docs/reference/asset/latest", + "issue_tracker": "https://issuetracker.google.com/savedsearches/559757", + "release_level": "stable", + "language": "nodejs", + "repo": "googleapis/google-cloud-node", + "distribution_name": "@google-cloud/asset", + "api_id": "cloudasset.googleapis.com", + "requires_billing": true, + "default_version": "v1", + "codeowner_team": "@googleapis/cloud-asset-team", + "api_shortname": "cloudasset", + "library_type": "GAPIC_AUTO", + "linkToRepoHomepage": "https://github.com/googleapis/google-cloud-node/tree/main/packages/google-cloud-asset", + "support_documentation": "https://cloud.google.com/resource-manager/docs/getting-support" + } +]`; nock.disableNetConnect(); @@ -46,7 +49,7 @@ describe(__filename, () => { nock.cleanAll(); sandbox.restore(); }); - it('should update disclaimers', async () => { + it.only('should update disclaimers', async () => { const url = new URL(disclaimer.libraryListUrl); const scope = nock(url.origin).get(url.pathname).reply(200, mockResponse); const expected = [ From 2a3acc4e5047c15a4508c5995f944cebc2e5c2ce Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Wed, 18 Jun 2025 10:39:25 -0700 Subject: [PATCH 4/4] remove only --- test/test.disclaimer.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test.disclaimer.ts b/test/test.disclaimer.ts index b526f634980..7e139dcdfab 100644 --- a/test/test.disclaimer.ts +++ b/test/test.disclaimer.ts @@ -49,7 +49,7 @@ describe(__filename, () => { nock.cleanAll(); sandbox.restore(); }); - it.only('should update disclaimers', async () => { + it('should update disclaimers', async () => { const url = new URL(disclaimer.libraryListUrl); const scope = nock(url.origin).get(url.pathname).reply(200, mockResponse); const expected = [