google-apis-core 1.0.0 error for batched request: Content-Length not given and Transfer-Encoding is not `chunked'

[mohamedhafez]

Environment details

• OS: macOS 15.6
• Ruby version: jruby-9.4.12.0
• Gem name and version: google-apis-core 1.0.0

Steps to reproduce

Making batched calendar requests to add events leads to a Content-Length not given and Transfer-Encoding is not 'chunked' error

Code example

I have code that boils down to the code below, and has worked for years with google-apis-core < 1.0.0, but now gives this error.

             gclient = Google::Apis::CalendarV3::CalendarService.new
             gclient.authorization = valid_access_token

             gclient.batch {|gclient|
                    gclient.insert_event("primary", body1, &batch_request_proc)
                    gclient.insert_event("primary", body2, &batch_request_proc)
             }

and i end up with a stack trace like

	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/net-http-0.5.0/lib/net/http/generic_request.rb:202:in `exec'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/net-http-0.5.0/lib/net/http.rb:2413:in `block in transport_request'
	from org/jruby/RubyKernel.java:1426:in `catch'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/net-http-0.5.0/lib/net/http.rb:2411:in `transport_request'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/net-http-0.5.0/lib/net/http.rb:2384:in `request'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-net_http-3.4.1/lib/faraday/adapter/net_http.rb:113:in `block in request_with_wrapped_block'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/net-http-0.5.0/lib/net/http.rb:1632:in `start'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-net_http-3.4.1/lib/faraday/adapter/net_http.rb:112:in `request_with_wrapped_block'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-net_http-3.4.1/lib/faraday/adapter/net_http.rb:102:in `perform_request'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-net_http-3.4.1/lib/faraday/adapter/net_http.rb:66:in `block in call'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-2.13.4/lib/faraday/adapter.rb:45:in `connection'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-net_http-3.4.1/lib/faraday/adapter/net_http.rb:65:in `call'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-follow_redirects-0.3.0/lib/faraday/follow_redirects/middleware.rb:77:in `perform_with_redirection'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-follow_redirects-0.3.0/lib/faraday/follow_redirects/middleware.rb:65:in `call'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-2.13.4/lib/faraday/rack_builder.rb:153:in `build_response'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/faraday-2.13.4/lib/faraday/connection.rb:452:in `run_request'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/google-apis-core-1.0.0/lib/google/apis/core/http_command.rb:317:in `execute_once'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/google-apis-core-1.0.0/lib/google/apis/core/http_command.rb:132:in `block in do_retry'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/retriable-3.1.2/lib/retriable.rb:61:in `block in retriable'
	from org/jruby/RubyFixnum.java:311:in `times'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/retriable-3.1.2/lib/retriable.rb:56:in `retriable'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/google-apis-core-1.0.0/lib/google/apis/core/http_command.rb:129:in `block in do_retry'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/retriable-3.1.2/lib/retriable.rb:61:in `block in retriable'
	from org/jruby/RubyFixnum.java:311:in `times'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/retriable-3.1.2/lib/retriable.rb:56:in `retriable'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/google-apis-core-1.0.0/lib/google/apis/core/http_command.rb:119:in `do_retry'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/google-apis-core-1.0.0/lib/google/apis/core/http_command.rb:110:in `execute'
	from /Users/mohamed/.rbenv/versions/jruby-9.4.12.0/lib/ruby/gems/shared/gems/google-apis-core-1.0.0/lib/google/apis/core/base_service.rb:231:in `batch'
	from /Users/mohamed/rubyprojects/substitutealert/app/models/gcal.rb:238:in `block in sync'

[mohamedhafez]

Ok, this only seems to happen when body is a Google::Apis::Core::CompositeIO at

google-api-ruby-client/google-apis-core/lib/google/apis/core/http_command.rb

Line 317 in e300f9d

@http_res = client.run_request(method, url.to_s, body, request_header)

I replaced body with make_body_str in that line, to call the method below to just convert the Google::Apis::Core::CompositeIO into a String, and then things work perfectly again.

        def make_body_str
          if body.respond_to?(:rewind)
            body_str = ""
            body.read(nil,body_str)
          elsif body.nil? || body.is_a?(String)
            body_str = body
          else
            raise "unexpected body class: #{body.class}"
          end

          body_str
        end

I'm guessing this wouldn't be an ideal fix since reading directly from the IO object is probably more efficient, but in that case some kind of fix to have Faraday be able to do that seems to be needed

[dazuma]

@mohamedhafez Thanks for the report! I'll take a look. Might need to detect this case and set the content-transfer-encoding header.

[dazuma]

Now that I look at this more closely, we're not streaming, just doing a simple post, so we should still send content-length. CompositeIO implements size so that should be doable.

[dazuma]

google-apis-core 1.0.1 released.