Skip to content

fix(core): Compute and send content-length header when posting a CompositeIO #23864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dazuma merged 1 commit into from
Aug 8, 2025
Merged

fix(core): Compute and send content-length header when posting a CompositeIO #23864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions google-apis-core/lib/google/apis/core/http_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ def prepare!
end

self.body = '' if self.body.nil? && [:post, :put, :patch].include?(method)
if defined?(::Google::Apis::Core::CompositeIO) && body.is_a?(::Google::Apis::Core::CompositeIO)
header["Content-Length"] ||= body.size.to_s
end
end

# Release any resources used by this command
Expand Down
5 changes: 4 additions & 1 deletion google-apis-core/spec/google/apis/core/batch_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,10 @@
--123abc--

EOF
expect(a_request(:post, 'https://www.googleapis.com/batch').with(body: expected_body)).to have_been_made
expect(
a_request(:post, 'https://www.googleapis.com/batch')
.with(body: expected_body, headers: {"Content-Length" => expected_body.size.to_s})
).to have_been_made
end

it 'should send content with authorization header when set' do
Expand Down
Loading