pubsub: rename newBuilder to defaultBuilder (#1873)

Fixes #1853.

Author: pongad

google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/PubSubExample.java

@@ -315,7 +315,7 @@ private static class PublishMessagesAction extends PubSubAction<Tuple<String, Li
         public void run(Tuple<String, List<PubsubMessage>> params) throws Exception {
             String topic = params.x();
             TopicName topicName = TopicName.create(projectId, topic);
-            Publisher publisher = Publisher.newBuilder(topicName).build();
+            Publisher publisher = Publisher.defaultBuilder(topicName).build();
             List<PubsubMessage> messages = params.y();
             for (PubsubMessage message : messages) {
                 ApiFuture<String> messageIdFuture = publisher.publish(message);
@@ -526,7 +526,7 @@ public void receiveMessage(PubsubMessage message, AckReplyConsumer consumer) {
             SubscriptionName subscriptionName = params.x();
             Subscriber subscriber = null;
             try {
-                subscriber = Subscriber.newBuilder(subscriptionName, receiver).build();
+                subscriber = Subscriber.defaultBuilder(subscriptionName, receiver).build();
                 subscriber.addListener(
                         new Subscriber.Listener() {
                             @Override

google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateSubscriptionAndPullMessages.java

@@ -51,7 +51,7 @@ public void receiveMessage(PubsubMessage message, AckReplyConsumer consumer) {
         };
     Subscriber subscriber = null;
     try {
-      subscriber = Subscriber.newBuilder(subscription, receiver).build();
+      subscriber = Subscriber.defaultBuilder(subscription, receiver).build();
       subscriber.addListener(
           new Subscriber.Listener() {
             @Override

google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateTopicAndPublishMessages.java

@@ -39,7 +39,7 @@ public static void main(String... args) throws Exception {
 
     Publisher publisher = null;
     try {
-      publisher = Publisher.newBuilder(topic).build();
+      publisher = Publisher.defaultBuilder(topic).build();
       List<String> messages = Arrays.asList("first message", "second message");
       List<ApiFuture<String>> messageIds = new ArrayList<>();
       for (String message : messages) {

google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java

@@ -65,7 +65,7 @@ public void onFailure(Throwable t) {
   public static void newBuilder(String projectName, String topicName) throws Exception {
     // [START newBuilder]
     TopicName topic = TopicName.create(projectName, topicName);
-    Publisher publisher = Publisher.newBuilder(topic).build();
+    Publisher publisher = Publisher.defaultBuilder(topic).build();
     try {
       // ...
     } finally {

google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java

@@ -53,7 +53,7 @@ public SubscriberSnippets(
   // [TARGET startAsync()]
   public void startAndWait() throws Exception {
     // [START startAsync]
-    Subscriber subscriber = Subscriber.newBuilder(subscription, receiver).build();
+    Subscriber subscriber = Subscriber.defaultBuilder(subscription, receiver).build();
     subscriber.addListener(new Subscriber.Listener() {
       public void failed(Subscriber.State from, Throwable failure) {
         // Handle error.

google-cloud-examples/src/test/java/com/google/cloud/examples/pubsub/snippets/ITPubSubSnippets.java

@@ -75,7 +75,7 @@ private void testPublisherSubscriberHelper(TopicName topicName, SubscriptionName
 
     Publisher publisher = null;
     try {
-      publisher = Publisher.newBuilder(topicName).build();
+      publisher = Publisher.defaultBuilder(topicName).build();
       PublisherSnippets snippets = new PublisherSnippets(publisher);
       final SettableApiFuture<Void> done = SettableApiFuture.create();
       ApiFutures.addCallback(

google-cloud-examples/src/test/java/com/google/cloud/examples/pubsub/snippets/ITSubscriptionAdminClientSnippets.java

@@ -170,7 +170,7 @@ private void createTopic(String name) throws Exception {
 
   private Set<String> publishMessages(String topicName, int numMessages) throws Exception {
     Set<String> messages = new HashSet<>();
-    Publisher publisher = Publisher.newBuilder(TopicName.create(projectId, topicName)).build();
+    Publisher publisher = Publisher.defaultBuilder(TopicName.create(projectId, topicName)).build();
     for (int i = 1; i<= numMessages; i++) {
       String message = formatForTest("message-" + i);
       PubsubMessage pubsubMessage = PubsubMessage.newBuilder().setData(

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java

@@ -509,7 +509,7 @@ interface LongRandom {
    * String projectName = "my_project";
    * String topicName = "my_topic";
    * TopicName topic = TopicName.create(projectName, topicName);
-   * Publisher publisher = Publisher.newBuilder(topic).build();
+   * Publisher publisher = Publisher.defaultBuilder(topic).build();
    * try {
    *   // ...
    * } finally {
@@ -519,7 +519,7 @@ interface LongRandom {
    * }</pre>
    *
    */
-  public static Builder newBuilder(TopicName topicName) {
+  public static Builder defaultBuilder(TopicName topicName) {
     return new Builder(topicName);
   }
 

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java

@@ -165,7 +165,7 @@ public void close() throws IOException {
    * @param receiver an implementation of {@link MessageReceiver} used to process the received
    *     messages
    */
-  public static Builder newBuilder(SubscriptionName subscription, MessageReceiver receiver) {
+  public static Builder defaultBuilder(SubscriptionName subscription, MessageReceiver receiver) {
     return new Builder(subscription, receiver);
   }
 
@@ -189,7 +189,7 @@ public FlowControlSettings getFlowControlSettings() {
    *
    * <p>Example of receiving a specific number of messages.
    * <pre> {@code
-   * Subscriber subscriber = Subscriber.newBuilder(subscription, receiver).build();
+   * Subscriber subscriber = Subscriber.defaultBuilder(subscription, receiver).build();
    * subscriber.addListener(new Subscriber.Listener() {
    *   public void failed(Subscriber.State from, Throwable failure) {
    *     // Handle error.

google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/it/ITPubSubTest.java

@@ -109,7 +109,7 @@ public void testPublishSubscribe() throws Exception {
 
     final SettableApiFuture<PubsubMessage> received = SettableApiFuture.create();
     Subscriber subscriber =
-        Subscriber.newBuilder(
+        Subscriber.defaultBuilder(
                 subscriptionName,
                 new MessageReceiver() {
                   @Override
@@ -132,7 +132,7 @@ public void failed(Subscriber.State from, Throwable failure) {
         MoreExecutors.directExecutor());
     subscriber.startAsync();
 
-    Publisher publisher = Publisher.newBuilder(topicName).build();
+    Publisher publisher = Publisher.defaultBuilder(topicName).build();
     publisher.publish(message).get();
     publisher.shutdown();