From f0b1bd67aa14c32c6a8b7e4334e6c682719e25e7 Mon Sep 17 00:00:00 2001 From: Michael Darakananda Date: Sun, 22 Jan 2017 15:39:29 +1100 Subject: [PATCH 1/2] hide Publisher and Subscriber's getStats() The methods are not yet implemented, so there is no reason to expose it. Another way out is to delete it for the time being. --- .../main/java/com/google/cloud/pubsub/spi/v1/Publisher.java | 4 ++-- .../java/com/google/cloud/pubsub/spi/v1/PublisherStats.java | 2 +- .../main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java | 2 +- .../java/com/google/cloud/pubsub/spi/v1/SubscriberStats.java | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java index ad1d7af7c5bc..5ea82d1d9606 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java @@ -467,8 +467,8 @@ public boolean failOnFlowControlLimits() { return failOnFlowControlLimits; } - /** Retrieves a snapshot of the publisher current {@link PublisherStats statistics}. */ - public PublisherStats getStats() { + /** Retrieves a snapshot of the publisher current statistics. */ + private PublisherStats getStats() { // TODO: Implement this. throw new UnsupportedOperationException(); } diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherStats.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherStats.java index 915e914acb99..d15dcfed45a5 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherStats.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherStats.java @@ -23,7 +23,7 @@ * Publisher}. */ @AutoValue -public abstract class PublisherStats { +abstract class PublisherStats { /** Number of successfully published messages. */ public abstract long getAckedMessages(); diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java index 13d1931ce151..b606a9ca81a4 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java @@ -356,7 +356,7 @@ public void run() { } } - public SubscriberStats getStats() { + private SubscriberStats getStats() { // TODO: Implement me return null; } diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/SubscriberStats.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/SubscriberStats.java index a96aff1d04b6..f0614f79a8f2 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/SubscriberStats.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/SubscriberStats.java @@ -23,8 +23,8 @@ * Subscriber}. */ @AutoValue -public abstract class SubscriberStats { - +abstract class SubscriberStats { + @AutoValue //TODO: Finish implementation. public abstract static class Stats {} From 24999225a6f656c2b977feec78cf7e2092ba3a28 Mon Sep 17 00:00:00 2001 From: Michael Darakananda Date: Tue, 24 Jan 2017 10:19:11 +1100 Subject: [PATCH 2/2] delete the methods --- .../main/java/com/google/cloud/pubsub/spi/v1/Publisher.java | 6 ------ .../java/com/google/cloud/pubsub/spi/v1/Subscriber.java | 5 ----- 2 files changed, 11 deletions(-) diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java index 5ea82d1d9606..4765039fadb8 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java @@ -467,12 +467,6 @@ public boolean failOnFlowControlLimits() { return failOnFlowControlLimits; } - /** Retrieves a snapshot of the publisher current statistics. */ - private PublisherStats getStats() { - // TODO: Implement this. - throw new UnsupportedOperationException(); - } - /** * Schedules immediate publishing of any outstanding messages and waits until all are processed. * diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java index b606a9ca81a4..81d1a60f4e0d 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java @@ -356,11 +356,6 @@ public void run() { } } - private SubscriberStats getStats() { - // TODO: Implement me - return null; - } - public String getSubscription() { return subscription; }