feat(pubsub): add support for streaming pull keepalives from the server - #7819
Merged
Conversation
hongalex
reviewed
Mar 18, 2026
| this.emit('data', data); | ||
| } | ||
|
|
||
| private _resetPingTimer(index: number): void { |
Member
There was a problem hiding this comment.
I haven't thought about the exact practical differences between what's written here and what's in the Java client, but I think we should probably just mimic the behavior of the latter.
Contributor
Author
There was a problem hiding this comment.
This is updated now. Take a look?
feywind
marked this pull request as ready for review
March 31, 2026 20:19
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
feywind
added
the
do not merge
Contributor
Author
|
We're not proceeding with this for now. |
feywind
removed
the
do not merge
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
pearigee
approved these changes
Jun 3, 2026
Contributor
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces server keepalive support in MessageStream by setting the protocol version and client ID, tracking ping/response times, and adding tests. The feedback suggests optimizing the keepalive mechanism by replacing the setInterval polling with a precise setTimeout triggered on pings, reusing the _clearAliveTimer helper to reduce duplication, avoiding starting the timer prematurely on initial connection, and updating the unit tests accordingly.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
quirogas
added a commit
that referenced
this pull request
Jul 10, 2026
…#8845) * feat(pubsub): add support for streaming pull keepalives from the server (#7819) * feat(pubsub): add support for streaming pull keepalives from the server * feat(pubsub): update algorithm to match Java impl * fix(pubsub): correct clientId value * chore: improve comment * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: accept gemini suggestion for setTimeout * fix: accept gemini suggestion * fix: accept gemini suggestion Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * fix: accept gemini suggestion * fix: accept gemini test suggestion * fix: pull timeout into a constant --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * chore(main): release projectify 5.1.0 (#8741) :robot: I have created a release *beep* *boop* --- ## [5.1.0](https://togithub.com/googleapis/google-cloud-node/compare/projectify-v5.0.1...projectify-v5.1.0) (2026-06-24) ### Features * Update API sources and regenerate ([#8672](https://togithub.com/googleapis/google-cloud-node/issues/8672)) ([3391fd2](https://togithub.com/googleapis/google-cloud-node/commit/3391fd27d1c15e051293207a07c6db00e760d370)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). * chore: standardize node engines semver range to >=18 across all package manifests (#8842) Standardize the Node.js engine requirement under "engines.node" to ">=18" across all 122 package manifests in the repository. Previously, package manifests across the monorepo used a mix of format variations (such as ">=18.0.0", ">=v18", or legacy ranges like ">=14"). While npm's semver parser silently strips leading "v" characters and trailing zeroes, official Semantic Versioning (SemVer 2.0.0) specifications and strict manifest validators require numeric version strings without letter prefixes. --------- Co-authored-by: feywind <57276408+feywind@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the keepalive support.
Fixes #7818 🦕