fix(storage): set application/json Content-Type for impersonated ADC requests - #8419
Merged
Dhriti07 merged 11 commits intoJun 22, 2026
Merged
Conversation
…t when json is present and header is missing
…tting content-type and skip test if Headers is undefined
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds logic to automatically set the 'Content-Type' header to 'application/json' when a JSON body is present in the request options, supporting both plain objects and Headers instances, and includes corresponding unit tests. The feedback suggests avoiding direct mutation of the user-provided headers object to prevent side-effects, recommending a shallow copy instead.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
thiyaguk09
marked this pull request as ready for review
June 3, 2026 11:35
Dhriti07
approved these changes
Jun 21, 2026
shivanee-p
pushed a commit
that referenced
this pull request
Aug 11, 2026
🤖 I have created a release *beep* *boop* --- ## [7.22.0](storage-v7.21.0...storage-v7.22.0) (2026-08-11) ### Features * **storage:** Add deleteSourceObjects option to combine/compose method ([#8444](#8444)) ([43abc45](43abc45)) ### Bug Fixes * **storage:** Destroy local read stream on upload write failure to prevent resource leaks ([#8752](#8752)) ([77dab53](77dab53)), refs [#7325](#7325) * **storage:** Pass signingEndpoint to URLSigner in file.getSignedUrl ([#8982](#8982)) ([b001807](b001807)) * **storage:** Resolve Node compatibility crashes, security vulnerability, and stream hangs ([#8622](#8622)) ([512ba79](512ba79)) * **storage:** Set application/json Content-Type for impersonated ADC requests ([#8419](#8419)) ([292c688](292c688)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that the
Content-Typeheader is correctly set toapplication/jsonfor metadata requests when using Application Default Credentials (ADC) with service account impersonation.Problem
When the SDK is initialized with Impersonated ADC, certain metadata-only operations (like
bucket.create()) were incorrectly sending aContent-Type: text/plainheader. Because the request body contains a JSON payload, the Google Cloud Storage API would fail to parse the request and return a400 Parse Error. This issue was specifically observed as a regression in version 7.17.3.Fix
The
decorateRequestmethod has been updated to check for the presence of a JSON payload. If a JSON body is present and noContent-Typeheader has been specified, the SDK now explicitly sets the header toapplication/json(source). This ensures that the GCS API can correctly interpret the request regardless of the authentication method being used.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #7336