chore!: upgrade to Node 18 - #8824
Merged
Merged
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
Author
|
@danieljbruce after your PR #8811, are the kokoro changes needed? Doesn't seem like these kokoro workflows are run but doesn't hurt to make these changes for consistency. |
psx95
approved these changes
Jul 7, 2026
aabmass
force-pushed
the
push-xprolqxuswro
branch
2 times, most recently
from
July 7, 2026 17:30
aff5859 to
fef8d8f
Compare
Contributor
Author
|
I realized now that the tests were disabled in 9a260ce so I want to re-enable them before release. Will push it to a new PR. |
aabmass
force-pushed
the
push-xprolqxuswro
branch
from
July 8, 2026 15:20
fef8d8f to
2b48121
Compare
BREAKING CHANGE: Drop support for Node.js versions < 18.
aabmass
force-pushed
the
push-xprolqxuswro
branch
from
July 8, 2026 16:48
2b48121 to
e3c7a35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop support for Node.js versions < 18.
Should have done this in #8822, since
pprofhas now dropped support for older node versions.