feat(firestore-api): add explicit ./protos/protos package subpath export - #9105
Merged
quirogas merged 3 commits intoAug 7, 2026
Merged
Conversation
…a files - Add ./protos/protos subpath export mapping directly to compiled protos declarations and implementations - Add ./protos/* subpath wildcard export to expose raw proto schemas and JSON definitions - Retain backward-compatible ./build/protos/* aliases
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds subpath exports for ./protos/protos, ./protos/*, and ./build/protos/* to the package.json of @google-cloud/firestore-api. However, because this package is an auto-generated client library, manually editing its configuration will result in these changes being overwritten during the next regeneration cycle. It is recommended to apply these changes upstream in the generator or templates.
- Add explicit ./protos/protos subpath export mapping directly to compiled protos declarations and implementations - Keep strictly explicit subpath definitions without wildcards
MarkDuckworth
approved these changes
Aug 6, 2026
quirogas
enabled auto-merge (squash)
August 7, 2026 00:16
shivanee-p
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit
./protos/protossubpath export to@google-cloud/firestore-apito support clean proto imports withoutbuild/directory exposure:./build/protos/protosand./protosentries for compatibility.Verification
npm pack --dry-run: successfully validated package export targets.